Re: [PATCH v2 02/13] OMAP: McBSP: Convert McBSP to platform device model

2011-02-01 Thread Peter Ujfalusi
On 01/31/2011 04:50 PM, ext Kishon Vijay Abraham I wrote:
> Implement McBSP as platform device and add support for
> registering through platform device layer using resource
> structures.
> 
> Later in this patch series, OMAP2+ McBSP driver would be modified to
> use hwmod framework after populating the omap2+ hwmod database.
> 
> Signed-off-by: Kishon Vijay Abraham I 
> ---
>  arch/arm/mach-omap1/mcbsp.c |  383 ++---
>  arch/arm/mach-omap2/mcbsp.c |  704 +-
>  arch/arm/plat-omap/devices.c|   10 +-
>  arch/arm/plat-omap/include/plat/mcbsp.h |   14 +-
>  arch/arm/plat-omap/mcbsp.c  |   60 +++-
>  5 files changed, 966 insertions(+), 205 deletions(-)

Looks good,

Acked-by: Peter Ujfalusi 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 02/13] OMAP: McBSP: Convert McBSP to platform device model

2011-01-31 Thread Kishon Vijay Abraham I
Implement McBSP as platform device and add support for
registering through platform device layer using resource
structures.

Later in this patch series, OMAP2+ McBSP driver would be modified to
use hwmod framework after populating the omap2+ hwmod database.

Signed-off-by: Kishon Vijay Abraham I 
---
 arch/arm/mach-omap1/mcbsp.c |  383 ++---
 arch/arm/mach-omap2/mcbsp.c |  704 +-
 arch/arm/plat-omap/devices.c|   10 +-
 arch/arm/plat-omap/include/plat/mcbsp.h |   14 +-
 arch/arm/plat-omap/mcbsp.c  |   60 +++-
 5 files changed, 966 insertions(+), 205 deletions(-)

diff --git a/arch/arm/mach-omap1/mcbsp.c b/arch/arm/mach-omap1/mcbsp.c
index 8209736..2b89ebd 100644
--- a/arch/arm/mach-omap1/mcbsp.c
+++ b/arch/arm/mach-omap1/mcbsp.c
@@ -10,6 +10,7 @@
  *
  * Multichannel mode not supported.
  */
+#include 
 #include 
 #include 
 #include 
@@ -78,100 +79,344 @@ static struct omap_mcbsp_ops omap1_mcbsp_ops = {
 };
 
 #if defined(CONFIG_ARCH_OMAP730) || defined(CONFIG_ARCH_OMAP850)
+struct resource omap7xx_mcbsp_res[][6] = {
+   {
+   {
+   .name  = "mpu",
+   .start = OMAP7XX_MCBSP1_BASE,
+   .end   = OMAP7XX_MCBSP1_BASE + SZ_256,
+   .flags = IORESOURCE_MEM,
+   },
+   {
+   .name  = "dma",
+   .start = OMAP7XX_MCBSP1_BASE,
+   .end   = OMAP7XX_MCBSP1_BASE + SZ_256,
+   .flags = IORESOURCE_MEM,
+   },
+   {
+   .name  = "rx",
+   .start = INT_7XX_McBSP1RX,
+   .flags = IORESOURCE_IRQ,
+   },
+   {
+   .name  = "tx",
+   .start = INT_7XX_McBSP1TX,
+   .flags = IORESOURCE_IRQ,
+   },
+   {
+   .name  = "rx",
+   .start = OMAP_DMA_MCBSP1_RX,
+   .flags = IORESOURCE_DMA,
+   },
+   {
+   .name  = "tx",
+   .start = OMAP_DMA_MCBSP1_TX,
+   .flags = IORESOURCE_DMA,
+   },
+   },
+   {
+   {
+   .name  = "mpu",
+   .start = OMAP7XX_MCBSP2_BASE,
+   .end   = OMAP7XX_MCBSP2_BASE + SZ_256,
+   .flags = IORESOURCE_MEM,
+   },
+   {
+   .name  = "dma",
+   .start = OMAP7XX_MCBSP2_BASE,
+   .end   = OMAP7XX_MCBSP2_BASE + SZ_256,
+   .flags = IORESOURCE_MEM,
+   },
+   {
+   .name  = "rx",
+   .start = INT_7XX_McBSP2RX,
+   .flags = IORESOURCE_IRQ,
+   },
+   {
+   .name  = "tx",
+   .start = INT_7XX_McBSP2TX,
+   .flags = IORESOURCE_IRQ,
+   },
+   {
+   .name  = "rx",
+   .start = OMAP_DMA_MCBSP3_RX,
+   .flags = IORESOURCE_DMA,
+   },
+   {
+   .name  = "tx",
+   .start = OMAP_DMA_MCBSP3_TX,
+   .flags = IORESOURCE_DMA,
+   },
+   },
+};
+
 static struct omap_mcbsp_platform_data omap7xx_mcbsp_pdata[] = {
{
-   .phys_base  = OMAP7XX_MCBSP1_BASE,
-   .dma_rx_sync= OMAP_DMA_MCBSP1_RX,
-   .dma_tx_sync= OMAP_DMA_MCBSP1_TX,
-   .rx_irq = INT_7XX_McBSP1RX,
-   .tx_irq = INT_7XX_McBSP1TX,
.ops= &omap1_mcbsp_ops,
},
{
-   .phys_base  = OMAP7XX_MCBSP2_BASE,
-   .dma_rx_sync= OMAP_DMA_MCBSP3_RX,
-   .dma_tx_sync= OMAP_DMA_MCBSP3_TX,
-   .rx_irq = INT_7XX_McBSP2RX,
-   .tx_irq = INT_7XX_McBSP2TX,
.ops= &omap1_mcbsp_ops,
},
 };
-#define OMAP7XX_MCBSP_PDATA_SZ ARRAY_SIZE(omap7xx_mcbsp_pdata)
-#define OMAP7XX_MCBSP_REG_NUM  (OMAP_MCBSP_REG_XCERH / sizeof(u16) + 1)
+#define OMAP7XX_MCBSP_RES_SZ   ARRAY_SIZE(omap7xx_mcbsp_res[1])
+#define OMAP7XX_MCBSP_COUNTARRAY_SIZE(omap7xx_mcbsp_res)
 #else
+#define omap7xx_mcbsp_res  NULL
 #define omap7xx_mcbsp_pdataNULL
-#define OMAP7XX_MCBSP_PDATA_SZ 0
-#define OMAP7XX_MCBSP_REG_NUM  0
+#define OMAP7XX_MCBSP_RES_SZ   0
+#define OMAP7XX_MCBSP_COUNT0
 #endif
 
 #ifdef CONFIG_ARCH_OMAP15XX
+struct resource omap15xx_mcbsp_res[][6] = {
+   {
+   {
+