Re: [PATCH v2 09/10] arm/dts: omap3-beagle: Add twl4030 and i2c EEPROM

2012-01-10 Thread Cousson, Benoit

On 1/10/2012 12:24 AM, Tabi Timur-B04825 wrote:

On Fri, Dec 9, 2011 at 8:02 AM, Benoit Coussonb-cous...@ti.com  wrote:


+   eeprom@50 {
+   compatible = ti,eeprom;
+   reg =0x50;
+   };


Why is this ti,?  For EDID, isn't the I2C device actually on the
monitor itself, and DVI cable just connects to the I2C bus?


Yes, in fact I didn't know what to put here, since I do not know what 
kind of eeprom the monitor will use.


And then I realized that the i2c driver is using the compatible name 
without the prefix, so any prefix can be used there...
OK, that's maybe not a very valid reason... but I did not find any 
better prefix at that time:-)



The reason I ask is that I'm trying to do the same thing for a PowerPC
board.  I need to defined an EDID I2C node.


Well, this seems to be generic i2c eeprom, so maybe a ddc, prefix or 
edid, will be a little bit better.


If later, we want to access that node from the display driver, we can 
just add a phandle to the node's label: edid-eeprom: eeprom@50:


Regards,
Benoit

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 09/10] arm/dts: omap3-beagle: Add twl4030 and i2c EEPROM

2012-01-09 Thread Tabi Timur-B04825
On Fri, Dec 9, 2011 at 8:02 AM, Benoit Cousson b-cous...@ti.com wrote:

 +       eeprom@50 {
 +               compatible = ti,eeprom;
 +               reg = 0x50;
 +       };

Why is this ti,?  For EDID, isn't the I2C device actually on the
monitor itself, and DVI cable just connects to the I2C bus?

The reason I ask is that I'm trying to do the same thing for a PowerPC
board.  I need to defined an EDID I2C node.

-- 
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 09/10] arm/dts: omap3-beagle: Add twl4030 and i2c EEPROM

2012-01-04 Thread Grant Likely
On Fri, Dec 09, 2011 at 03:02:40PM +0100, Benoit Cousson wrote:
 Add required clock frequencies for the i2c client devices existing
 on beagle board.
 
 Add the twl4030 basic description with only the twl_rtc module.
 
 Add the EEPROM node.
 
 Based on original patch from Manju:
 http://www.spinics.net/lists/linux-omap/msg55831.html
 
 Signed-off-by: Benoit Cousson b-cous...@ti.com
 Cc: Grant Likely grant.lik...@secretlab.ca
 Cc: Rob Herring rob.herr...@calxeda.com

Acked-by: Grant Likely grant.lik...@secretlab.ca

 ---
  arch/arm/boot/dts/omap3-beagle.dts |   38 
 
  1 files changed, 38 insertions(+), 0 deletions(-)
 
 diff --git a/arch/arm/boot/dts/omap3-beagle.dts 
 b/arch/arm/boot/dts/omap3-beagle.dts
 index 9f72cd4..b648279 100644
 --- a/arch/arm/boot/dts/omap3-beagle.dts
 +++ b/arch/arm/boot/dts/omap3-beagle.dts
 @@ -18,3 +18,41 @@
   reg = 0x8000 0x2000; /* 512 MB */
   };
  };
 +
 +i2c1 {
 + clock-frequency = 260;
 +
 + /*
 +  * Integrated Power Management Chip
 +  */
 + twl@48 {
 + compatible = ti,twl4030;
 + reg = 0x48;
 + interrupts = 7; /* SYS_NIRQ cascaded to intc */
 + interrupt-controller;
 + #interrupt-cells = 1;
 + interrupt-parent = intc;
 +
 + twl_rtc {
 + compatible = ti,twl4030-rtc;
 + interrupts = 11;
 + };
 + };
 +};
 +
 +i2c2 {
 + clock-frequency = 40;
 +};
 +
 +i2c3 {
 + clock-frequency = 10;
 +
 + /*
 +  * Display monitor features are burnt in the EEPROM
 +  * as EDID data.
 +  */
 + eeprom@50 {
 + compatible = ti,eeprom;
 + reg = 0x50;
 + };
 +};
 -- 
 1.7.0.4
 
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 09/10] arm/dts: omap3-beagle: Add twl4030 and i2c EEPROM

2011-12-09 Thread Benoit Cousson
Add required clock frequencies for the i2c client devices existing
on beagle board.

Add the twl4030 basic description with only the twl_rtc module.

Add the EEPROM node.

Based on original patch from Manju:
http://www.spinics.net/lists/linux-omap/msg55831.html

Signed-off-by: Benoit Cousson b-cous...@ti.com
Cc: Grant Likely grant.lik...@secretlab.ca
Cc: Rob Herring rob.herr...@calxeda.com
---
 arch/arm/boot/dts/omap3-beagle.dts |   38 
 1 files changed, 38 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-beagle.dts 
b/arch/arm/boot/dts/omap3-beagle.dts
index 9f72cd4..b648279 100644
--- a/arch/arm/boot/dts/omap3-beagle.dts
+++ b/arch/arm/boot/dts/omap3-beagle.dts
@@ -18,3 +18,41 @@
reg = 0x8000 0x2000; /* 512 MB */
};
 };
+
+i2c1 {
+   clock-frequency = 260;
+
+   /*
+* Integrated Power Management Chip
+*/
+   twl@48 {
+   compatible = ti,twl4030;
+   reg = 0x48;
+   interrupts = 7; /* SYS_NIRQ cascaded to intc */
+   interrupt-controller;
+   #interrupt-cells = 1;
+   interrupt-parent = intc;
+
+   twl_rtc {
+   compatible = ti,twl4030-rtc;
+   interrupts = 11;
+   };
+   };
+};
+
+i2c2 {
+   clock-frequency = 40;
+};
+
+i2c3 {
+   clock-frequency = 10;
+
+   /*
+* Display monitor features are burnt in the EEPROM
+* as EDID data.
+*/
+   eeprom@50 {
+   compatible = ti,eeprom;
+   reg = 0x50;
+   };
+};
-- 
1.7.0.4

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html