Re: [PATCH v2 1/2] ARM: dts: Add SHAM data and documentation for AM33XX

2013-08-22 Thread Mark Rutland
On Wed, Jul 17, 2013 at 05:23:41PM +0100, Mark A. Greer wrote:
 From: Mark A. Greer mgr...@animalcreek.com
 
 Add the generic AM33XX SHAM module's device tree data and
 enable it for the am335x-evm, am335x-evmsk, and am335x-bone
 platforms.  Also add Documentation file describing the data
 for the SHAM module.
 
 CC: Paul Walmsley p...@pwsan.com
 Signed-off-by: Mark A. Greer mgr...@animalcreek.com
 ---
  .../devicetree/bindings/crypto/omap-sham.txt   | 33 
 ++
  arch/arm/boot/dts/am335x-bone.dts  |  4 +++
  arch/arm/boot/dts/am335x-evm.dts   |  4 +++
  arch/arm/boot/dts/am335x-evmsk.dts |  4 +++
  arch/arm/boot/dts/am33xx.dtsi  | 10 +++
  5 files changed, 55 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt
 
 diff --git a/Documentation/devicetree/bindings/crypto/omap-sham.txt 
 b/Documentation/devicetree/bindings/crypto/omap-sham.txt
 new file mode 100644
 index 000..c6d1202
 --- /dev/null
 +++ b/Documentation/devicetree/bindings/crypto/omap-sham.txt
 @@ -0,0 +1,33 @@
 +OMAP SoC SHA crypto Module
 +
 +Required properties:
 +
 +- compatible : Should contain entries for this and backward compatible
 +  SHAM versions:
 +  - ti,omap2-sham for OMAP2  OMAP3.
 +  - ti,omap4-sham for OMAP4 and AM33XX.
 +  Note that these two versions are incompatible.
 +- ti,hwmods: Name of the hwmod associated with the SHAM module
 +- reg : Offset and length of the register set for the module
 +- interrupt-parent : the phandle for the interrupt controller that
 +  services interrupts for this module.
 +- interrupts : the interrupt number for the SHAM module.
 +
 +Optional properties:
 +- dmas: DMA controller phandle and DMA request ordered pair.
 + Only one rx pair is valid per SHAM module.

This may be a little late, but...

Nit: A dma specifier may have many cells, so calling it pair is not
necessarily correct:

dmas = dma0 432 7 5,
   dma1 3,
   dma0 212 1 13;

You could instead say:

- dmas: DMA specifier for the rx dma. See the DMA client binding,
Documentation/devicetree/bindings/dma/dma.txt

 +- dma-names: DMA request name. This string corresponds 1:1 with
 + the ordered pair in dmas. The string naming is to be
 + rx for RX request.

Similarly:

 - dma-names: DMA request name. Should be rx if a dma is present.

It would be nice to get the bindings using consistent terminology so we
don't confuse everyone further.

Thanks,
Mark.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 1/2] ARM: dts: Add SHAM data and documentation for AM33XX

2013-07-17 Thread Mark A. Greer
From: Mark A. Greer mgr...@animalcreek.com

Add the generic AM33XX SHAM module's device tree data and
enable it for the am335x-evm, am335x-evmsk, and am335x-bone
platforms.  Also add Documentation file describing the data
for the SHAM module.

CC: Paul Walmsley p...@pwsan.com
Signed-off-by: Mark A. Greer mgr...@animalcreek.com
---
 .../devicetree/bindings/crypto/omap-sham.txt   | 33 ++
 arch/arm/boot/dts/am335x-bone.dts  |  4 +++
 arch/arm/boot/dts/am335x-evm.dts   |  4 +++
 arch/arm/boot/dts/am335x-evmsk.dts |  4 +++
 arch/arm/boot/dts/am33xx.dtsi  | 10 +++
 5 files changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt

diff --git a/Documentation/devicetree/bindings/crypto/omap-sham.txt 
b/Documentation/devicetree/bindings/crypto/omap-sham.txt
new file mode 100644
index 000..c6d1202
--- /dev/null
+++ b/Documentation/devicetree/bindings/crypto/omap-sham.txt
@@ -0,0 +1,33 @@
+OMAP SoC SHA crypto Module
+
+Required properties:
+
+- compatible : Should contain entries for this and backward compatible
+  SHAM versions:
+  - ti,omap2-sham for OMAP2  OMAP3.
+  - ti,omap4-sham for OMAP4 and AM33XX.
+  Note that these two versions are incompatible.
+- ti,hwmods: Name of the hwmod associated with the SHAM module
+- reg : Offset and length of the register set for the module
+- interrupt-parent : the phandle for the interrupt controller that
+  services interrupts for this module.
+- interrupts : the interrupt number for the SHAM module.
+
+Optional properties:
+- dmas: DMA controller phandle and DMA request ordered pair.
+   Only one rx pair is valid per SHAM module.
+- dma-names: DMA request name. This string corresponds 1:1 with
+   the ordered pair in dmas. The string naming is to be
+   rx for RX request.
+
+Example:
+   /* AM335x */
+   sham: sham@5310 {
+   compatible = ti,omap4-sham;
+   ti,hwmods = sham;
+   reg = 0x5310 0x200;
+   interrupt-parent = intc;
+   interrupts = 109;
+   dmas = edma 36;
+   dma-names = rx;
+   };
diff --git a/arch/arm/boot/dts/am335x-bone.dts 
b/arch/arm/boot/dts/am335x-bone.dts
index 444b4ed..bc75b2c 100644
--- a/arch/arm/boot/dts/am335x-bone.dts
+++ b/arch/arm/boot/dts/am335x-bone.dts
@@ -234,3 +234,7 @@
pinctrl-0 = davinci_mdio_default;
pinctrl-1 = davinci_mdio_sleep;
 };
+
+sham {
+   status = okay;
+};
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 3aee1a4..9b8c56d 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -488,3 +488,7 @@
ti,adc-channels = 4 5 6 7;
};
 };
+
+sham {
+   status = okay;
+};
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts 
b/arch/arm/boot/dts/am335x-evmsk.dts
index 0c8ad17..61dc5d4 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -402,3 +402,7 @@
phy_id = davinci_mdio, 1;
phy-mode = rgmii-txid;
 };
+
+sham {
+   status = okay;
+};
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 38b446b..63a5e95 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -530,5 +530,15 @@
#size-cells = 1;
status = disabled;
};
+
+   sham: sham@5310 {
+   compatible = ti,omap4-sham;
+   ti,hwmods = sham;
+   reg = 0x5310 0x200;
+   interrupt-parent = intc;
+   interrupts = 109;
+   dmas = edma 36;
+   dma-names = rx;
+   };
};
 };
-- 
1.7.12

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html