Re: [PATCH v2 4/4] OMAP4: DSS2: clocks: Add ick as dummy clock

2011-01-27 Thread Kevin Hilman
Sumit Semwal sumit.sem...@ti.com writes:

 DSS code uses ick as one of the clocks in clk_get/clk_put. OMAP4 clock 
 database
 doesn't have ick for DSS, so adding ick as dummy clock.

 Once pm_runtime* APIs get introduced in DSS, this will be revisited.

 Signed-off-by: Sumit Semwal sumit.sem...@ti.com
 ---
  arch/arm/mach-omap2/clock44xx_data.c |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

 diff --git a/arch/arm/mach-omap2/clock44xx_data.c 
 b/arch/arm/mach-omap2/clock44xx_data.c
 index 74db324..8603b1f 100644
 --- a/arch/arm/mach-omap2/clock44xx_data.c
 +++ b/arch/arm/mach-omap2/clock44xx_data.c
 @@ -3109,6 +3109,8 @@ static struct omap_clk omap44xx_clks[] = {
   CLK(NULL,   dsp_fck,  dsp_fck,   
 CK_443X),
   /* dss clocks */
   CLK(NULL,   fck,  dss_fck,   
 CK_443X),
 + CLK(omap_dss, ick,  dummy_ck,  
 CK_443X),
 + /* on OMAP4, ick is a dummy clock */

minor nit: the comment should go above the code, and should also state
it's needed for OMAP2/3 compatibility.

Kevin

   /*
* clocks handled via hwmod opt_clk mechanism need dev=NULL,
* con=clock name as per actual clk structure, NOT role
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 4/4] OMAP4: DSS2: clocks: Add ick as dummy clock

2011-01-27 Thread Semwal, Sumit
On Thu, Jan 27, 2011 at 11:16 PM, Kevin Hilman khil...@ti.com wrote:
 Sumit Semwal sumit.sem...@ti.com writes:

 DSS code uses ick as one of the clocks in clk_get/clk_put. OMAP4 clock 
 database
 doesn't have ick for DSS, so adding ick as dummy clock.

 Once pm_runtime* APIs get introduced in DSS, this will be revisited.

 Signed-off-by: Sumit Semwal sumit.sem...@ti.com
 ---
  arch/arm/mach-omap2/clock44xx_data.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

 diff --git a/arch/arm/mach-omap2/clock44xx_data.c 
 b/arch/arm/mach-omap2/clock44xx_data.c
 index 74db324..8603b1f 100644
 --- a/arch/arm/mach-omap2/clock44xx_data.c
 +++ b/arch/arm/mach-omap2/clock44xx_data.c
 @@ -3109,6 +3109,8 @@ static struct omap_clk omap44xx_clks[] = {
       CLK(NULL,       dsp_fck,                      dsp_fck,       
 CK_443X),
       /* dss clocks */
       CLK(NULL,       fck,                          dss_fck,       
 CK_443X),
 +     CLK(omap_dss, ick,                          dummy_ck,      
 CK_443X),
 +     /* on OMAP4, ick is a dummy clock */

 minor nit: the comment should go above the code, and should also state
 it's needed for OMAP2/3 compatibility.
Sure, thanks! Will update in next version.
~Sumit.

 Kevin

       /*
        * clocks handled via hwmod opt_clk mechanism need dev=NULL,
        * con=clock name as per actual clk structure, NOT role

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 4/4] OMAP4: DSS2: clocks: Add ick as dummy clock

2011-01-25 Thread Sumit Semwal
DSS code uses ick as one of the clocks in clk_get/clk_put. OMAP4 clock database
doesn't have ick for DSS, so adding ick as dummy clock.

Once pm_runtime* APIs get introduced in DSS, this will be revisited.

Signed-off-by: Sumit Semwal sumit.sem...@ti.com
---
 arch/arm/mach-omap2/clock44xx_data.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/clock44xx_data.c 
b/arch/arm/mach-omap2/clock44xx_data.c
index 74db324..8603b1f 100644
--- a/arch/arm/mach-omap2/clock44xx_data.c
+++ b/arch/arm/mach-omap2/clock44xx_data.c
@@ -3109,6 +3109,8 @@ static struct omap_clk omap44xx_clks[] = {
CLK(NULL,   dsp_fck,  dsp_fck,   
CK_443X),
/* dss clocks */
CLK(NULL,   fck,  dss_fck,   
CK_443X),
+   CLK(omap_dss, ick,  dummy_ck,  
CK_443X),
+   /* on OMAP4, ick is a dummy clock */
/*
 * clocks handled via hwmod opt_clk mechanism need dev=NULL,
 * con=clock name as per actual clk structure, NOT role
-- 
1.7.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html