[PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes
The cleanup is mostly getting rid of redundant fields in struct gpio_bank{}
as we already have them as part of bank->context now. Also, remove un-used
variable from gpio_irq_handler.
The fixes include correction of _set_gpio_irqenable() implementation,
missing wakeup_en register update in set_gpio_wakeup(), type mismatch
of gpio trigger parameter in set_gpio_trigger(), incorrect dataout
register update in set_gpio_dataout_() and few corrections in context
save logic.
It is baselined on top of Kevin's following series:
gpio/omap: cleanup and runtime PM conversion for v3.4
git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
for_3.4/gpio/runtime-pm-cleanup
Series is available here for reference:
git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev
for_3.4/gpio_further_cleanup_fixes
Power Test: Off-mode and Retention on OMAP3430 (Suspend and Idle paths).
Functional Test: OMAP2430, OMAP3430SDP, ZOOM3, OMAP4430, OMAP4-BLAZE
v3:
- Added 4 more additional patches to the previous series
which are all bug fixes.
v2:
- Added a new patch to update wakeup_en register in _set_gpio_wakeup()
in addition to updating bank->context.wake_en.
- Added a new patch to remove redundant decoding of gpio offset in
gpio_get(), _get_gpio_datain() and _get_gpio_dataout().
- Added a new patch to remove suspend/resume callbacks because the
operations performed with the callbacks are redundant.
Tarun Kanti DebBarma (13):
gpio/omap: remove saved_fallingdetect, saved_risingdetect fields
gpio/omap: fix wakeup_en register update in _set_gpio_wakeup()
gpio/omap: remove suspend_wakeup field from struct gpio_bank
gpio/omap: remove saved_wakeup field from struct gpio_bank
gpio/omap: get rid of retrigger variable in gpio_irq_handler
gpio/omap: fix trigger type to unsigned
gpio/omap: fix _set_gpio_irqenable implementation
gpio/omap: remove redundant decoding of gpio offset
gpio/omap: remove suspend/resume callbacks
gpio/omap: fix missing dataout context save in _set_gpio_dataout_reg
gpio/omap: fix dataout register overwrite in _set_gpio_dataout_*
gpio/omap: fix incorrect context restore logic in omap_gpio_runtime_resume
gpio/omap: fix incorrect update to context.irqenable1
drivers/gpio/gpio-omap.c | 125 +
1 files changed, 36 insertions(+), 89 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes
Tarun Kanti DebBarma writes:
> The cleanup is mostly getting rid of redundant fields in struct gpio_bank{}
> as we already have them as part of bank->context now. Also, remove un-used
> variable from gpio_irq_handler.
>
> The fixes include correction of _set_gpio_irqenable() implementation,
> missing wakeup_en register update in set_gpio_wakeup(), type mismatch
> of gpio trigger parameter in set_gpio_trigger(), incorrect dataout
> register update in set_gpio_dataout_() and few corrections in context
> save logic.
>
> It is baselined on top of Kevin's following series:
> gpio/omap: cleanup and runtime PM conversion for v3.4
> git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
> for_3.4/gpio/runtime-pm-cleanup
>
> Series is available here for reference:
> git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev
> for_3.4/gpio_further_cleanup_fixes
This branch doesn't exist.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes
On Tue, Mar 13, 2012 at 12:24 AM, Kevin Hilman wrote:
> Tarun Kanti DebBarma writes:
>
>> The cleanup is mostly getting rid of redundant fields in struct gpio_bank{}
>> as we already have them as part of bank->context now. Also, remove un-used
>> variable from gpio_irq_handler.
>>
>> The fixes include correction of _set_gpio_irqenable() implementation,
>> missing wakeup_en register update in set_gpio_wakeup(), type mismatch
>> of gpio trigger parameter in set_gpio_trigger(), incorrect dataout
>> register update in set_gpio_dataout_() and few corrections in context
>> save logic.
>>
>> It is baselined on top of Kevin's following series:
>> gpio/omap: cleanup and runtime PM conversion for v3.4
>> git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
>> for_3.4/gpio/runtime-pm-cleanup
>>
>> Series is available here for reference:
>> git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev
>> for_3.4/gpio_further_cleanup_fixes
>
> This branch doesn't exist.
Oops... I am sorry.
I was in the process of updating the branch with latest comments after
base-lining on Grant's:
git://git.secretlab.ca/git/linux-2.6.git
Branch: gpio/next
Because this has all the gpio changes including Benoit's latest gpio
devicetree changes.
Should I go ahead?
--
Tarun
>
> Kevin
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes
On Tue, Mar 13, 2012 at 1:23 AM, DebBarma, Tarun Kanti
wrote:
> On Tue, Mar 13, 2012 at 12:24 AM, Kevin Hilman wrote:
>> Tarun Kanti DebBarma writes:
>>
>>> The cleanup is mostly getting rid of redundant fields in struct gpio_bank{}
>>> as we already have them as part of bank->context now. Also, remove un-used
>>> variable from gpio_irq_handler.
>>>
>>> The fixes include correction of _set_gpio_irqenable() implementation,
>>> missing wakeup_en register update in set_gpio_wakeup(), type mismatch
>>> of gpio trigger parameter in set_gpio_trigger(), incorrect dataout
>>> register update in set_gpio_dataout_() and few corrections in context
>>> save logic.
>>>
>>> It is baselined on top of Kevin's following series:
>>> gpio/omap: cleanup and runtime PM conversion for v3.4
>>> git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
>>> for_3.4/gpio/runtime-pm-cleanup
>>>
>>> Series is available here for reference:
>>> git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev
>>> for_3.4/gpio_further_cleanup_fixes
>>
>> This branch doesn't exist.
> Oops... I am sorry.
> I was in the process of updating the branch with latest comments after
> base-lining on Grant's:
> git://git.secretlab.ca/git/linux-2.6.git
> Branch: gpio/next
> Because this has all the gpio changes including Benoit's latest gpio
> devicetree changes.
> Should I go ahead?
Anyways, for the time being I am updating on top of your changes as before.
You should be able to see the branch shortly.
--
Tarun
>>
>> Kevin
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes
On Tue, Mar 13, 2012 at 1:38 AM, DebBarma, Tarun Kanti
wrote:
> On Tue, Mar 13, 2012 at 1:23 AM, DebBarma, Tarun Kanti
> wrote:
>> On Tue, Mar 13, 2012 at 12:24 AM, Kevin Hilman wrote:
>>> Tarun Kanti DebBarma writes:
>>>
The cleanup is mostly getting rid of redundant fields in struct gpio_bank{}
as we already have them as part of bank->context now. Also, remove un-used
variable from gpio_irq_handler.
The fixes include correction of _set_gpio_irqenable() implementation,
missing wakeup_en register update in set_gpio_wakeup(), type mismatch
of gpio trigger parameter in set_gpio_trigger(), incorrect dataout
register update in set_gpio_dataout_() and few corrections in context
save logic.
It is baselined on top of Kevin's following series:
gpio/omap: cleanup and runtime PM conversion for v3.4
git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
for_3.4/gpio/runtime-pm-cleanup
Series is available here for reference:
git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev
for_3.4/gpio_further_cleanup_fixes
>>>
>>> This branch doesn't exist.
>> Oops... I am sorry.
>> I was in the process of updating the branch with latest comments after
>> base-lining on Grant's:
>> git://git.secretlab.ca/git/linux-2.6.git
>> Branch: gpio/next
>> Because this has all the gpio changes including Benoit's latest gpio
>> devicetree changes.
>> Should I go ahead?
> Anyways, for the time being I am updating on top of your changes as before.
> You should be able to see the branch shortly.
Please note that the branch has your following patch:
gpio/omap: fix wakeups on level-triggered GPIOs
--
Tarun
>>> Kevin
>>>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes
"DebBarma, Tarun Kanti" writes: [...] >>> Oops... I am sorry. >>> I was in the process of updating the branch with latest comments after >>> base-lining on Grant's: >>> git://git.secretlab.ca/git/linux-2.6.git >>> Branch: gpio/next >>> Because this has all the gpio changes including Benoit's latest gpio >>> devicetree changes. >>> Should I go ahead? >> Anyways, for the time being I am updating on top of your changes as before. >> You should be able to see the branch shortly. > Please note that the branch has your following patch: > gpio/omap: fix wakeups on level-triggered GPIOs After addressing my comments on the series, please go ahead and rebase on Grant's gpio/next branch. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes
"DebBarma, Tarun Kanti" writes: [...] >>> Oops... I am sorry. >>> I was in the process of updating the branch with latest comments after >>> base-lining on Grant's: >>> git://git.secretlab.ca/git/linux-2.6.git >>> Branch: gpio/next >>> Because this has all the gpio changes including Benoit's latest gpio >>> devicetree changes. >>> Should I go ahead? >> Anyways, for the time being I am updating on top of your changes as before. >> You should be able to see the branch shortly. > Please note that the branch has your following patch: > gpio/omap: fix wakeups on level-triggered GPIOs Please be sure to Cc the GPIO maintainer (added now.) Grant can we consider your gpio/next a stable baseline for further GPIO fixes? If so, Tarun, please base your branch there. Otherwise, continue to use my for_3.4/gpio/runtime-pm-cleanup, but please test it by merging with the gpio/next branch. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes
On Mon, 12 Mar 2012 15:28:42 -0700, Kevin Hilman wrote: > "DebBarma, Tarun Kanti" writes: > > [...] > > >>> Oops... I am sorry. > >>> I was in the process of updating the branch with latest comments after > >>> base-lining on Grant's: > >>> git://git.secretlab.ca/git/linux-2.6.git > >>> Branch: gpio/next > >>> Because this has all the gpio changes including Benoit's latest gpio > >>> devicetree changes. > >>> Should I go ahead? > >> Anyways, for the time being I am updating on top of your changes as before. > >> You should be able to see the branch shortly. > > Please note that the branch has your following patch: > > gpio/omap: fix wakeups on level-triggered GPIOs > > Please be sure to Cc the GPIO maintainer (added now.) > > Grant can we consider your gpio/next a stable baseline for further > GPIO fixes? > > If so, Tarun, please base your branch there. Otherwise, continue to use > my for_3.4/gpio/runtime-pm-cleanup, but please test it by merging with > the gpio/next branch. I'm not going to rebase gpio/next before the merge window; you can base on it with confidence. g. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes
On Tue, Mar 13, 2012 at 9:27 AM, Grant Likely wrote: > On Mon, 12 Mar 2012 15:28:42 -0700, Kevin Hilman wrote: >> "DebBarma, Tarun Kanti" writes: >> >> [...] >> >> >>> Oops... I am sorry. >> >>> I was in the process of updating the branch with latest comments after >> >>> base-lining on Grant's: >> >>> git://git.secretlab.ca/git/linux-2.6.git >> >>> Branch: gpio/next >> >>> Because this has all the gpio changes including Benoit's latest gpio >> >>> devicetree changes. >> >>> Should I go ahead? >> >> Anyways, for the time being I am updating on top of your changes as >> >> before. >> >> You should be able to see the branch shortly. >> > Please note that the branch has your following patch: >> > gpio/omap: fix wakeups on level-triggered GPIOs >> >> Please be sure to Cc the GPIO maintainer (added now.) Sure. >> >> Grant can we consider your gpio/next a stable baseline for further >> GPIO fixes? >> >> If so, Tarun, please base your branch there. Otherwise, continue to use >> my for_3.4/gpio/runtime-pm-cleanup, but please test it by merging with >> the gpio/next branch. > > I'm not going to rebase gpio/next before the merge window; you can base on it > with > confidence. I will base and start doing the tests. In the mean time I will wait for Kevin's comments on the series. Thanks. -- Tarun > > g. > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
