RE: [PATCH v5 0/3] omap3 nand: cleanup exiting platform related code
Tony, Please let me know if any have input on following two series. http://www.mail-archive.com/linux-omap@vger.kernel.org/msg30305.html http://www.mail-archive.com/linux-omap@vger.kernel.org/msg30735.html Regards, Ghorai > -Original Message- > From: Ghorai, Sukumar > Sent: Tuesday, June 15, 2010 6:57 PM > To: 'Tony Lindgren' > Cc: linux-omap@vger.kernel.org; linux-...@lists.infradead.org; > t...@atomide.com; m...@compulab.co.il; 'Vimal Singh' > Subject: RE: [PATCH v5 0/3] omap3 nand: cleanup exiting platform related > code > > Tony, > > > -Original Message- > > From: Vimal Singh [mailto:vimal.neww...@gmail.com] > > Sent: Tuesday, June 08, 2010 10:43 PM > > To: Ghorai, Sukumar > > Cc: linux-omap@vger.kernel.org; linux-...@lists.infradead.org; > > t...@atomide.com; m...@compulab.co.il > > Subject: Re: [PATCH v5 0/3] omap3 nand: cleanup exiting platform related > > code > > > > Reviewed-by: Vimal Singh > > > > On Fri, Jun 4, 2010 at 1:10 PM, Sukumar Ghorai wrote: > > > The following set of patches applies on top of for-next branch. > > > http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap- > > 2.6.git > > > Patches verified on: omap3430-SDP, omap3630-sdp, zoom3 and beagle > > board > > > > > > And these are the patches required to address the following input - > > > 1. The NAND driver needs to stop tinkering with the GPMC registers > > > The omap General Purpose Memory Controller (GPMC) registers are > > omap > > > specific, and not driver specific. Tinkering with these > registers > > can > > > cause issues with the other devices on the GPMC. > > > > > > 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board > files > > > Passing hardcoded GPMC virtual addressess is sure way to mess > up > > things. > > > This should all become unnecessary once the NAND drivers stops > > messing > > > with the GPMC registers directly. > > > Discussion: http://www.mail-archive.com/linux- > > o...@vger.kernel.org/msg27630.html > > > > > > Changes in this series - > > > Unused function removed. > > > > > > Functions related to ecc and prefetch engine are optimized. > > > v4: http://www.mail-archive.com/linux- > > o...@vger.kernel.org/msg29458.html > > > > > > Few functionality was missing like - There should be some locking as > > only > > > one chipselect can use the ECC or prefetch engine at a time. If you > > have > > > NAND in two chipselects, bad things would happen. > > > v3: http://www.mail-archive.com/linux- > > o...@vger.kernel.org/msg28715.html > > > > > > Additionally, it was needed to implement more functions for the > > platform > > > init code to use. > > > v2: http://www.mail-archive.com/linux- > > o...@vger.kernel.org/msg28467.html > > > > > > v1: http://www.mail-archive.com/linux- > > o...@vger.kernel.org/msg28164.html > > > > > > > > > Sukumar Ghorai (3): > > > omap3 gpmc: functionality enhancement > > > omap3 nand: cleanup virtual address usages > > > omap3 nand: fix issue in board file to detect nand > > > arch/arm/mach-omap2/board-cm-t35.c | 20 +--- > > > arch/arm/mach-omap2/board-devkit8000.c | 25 +--- > > > arch/arm/mach-omap2/board-omap3beagle.c | 24 +--- > > > arch/arm/mach-omap2/board-omap3touchbook.c | 25 +--- > > > arch/arm/mach-omap2/board-overo.c | 24 +--- > > > arch/arm/mach-omap2/board-sdp-flash.c | 5 - > > > arch/arm/mach-omap2/gpmc-nand.c | 39 ++ > > > arch/arm/mach-omap2/gpmc.c | 228 > > +--- > > > arch/arm/plat-omap/include/plat/gpmc.h | 36 - > > > arch/arm/plat-omap/include/plat/nand.h | 6 +- > > > drivers/mtd/nand/omap2.c | 229 --- > -- > > --- > > > 11 files changed, 320 insertions(+), 341 deletions(-) > > [Ghorai] Any comments or input on these patch? > > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-omap" > in > > > the body of a message to majord...@vger.kernel.org > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > > > > > > > -- > > Regards, > > Vimal Singh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v5 0/3] omap3 nand: cleanup exiting platform related code
Tony, > -Original Message- > From: Vimal Singh [mailto:vimal.neww...@gmail.com] > Sent: Tuesday, June 08, 2010 10:43 PM > To: Ghorai, Sukumar > Cc: linux-omap@vger.kernel.org; linux-...@lists.infradead.org; > t...@atomide.com; m...@compulab.co.il > Subject: Re: [PATCH v5 0/3] omap3 nand: cleanup exiting platform related > code > > Reviewed-by: Vimal Singh > > On Fri, Jun 4, 2010 at 1:10 PM, Sukumar Ghorai wrote: > > The following set of patches applies on top of for-next branch. > > http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap- > 2.6.git > > Patches verified on: omap3430-SDP, omap3630-sdp, zoom3 and beagle > board > > > > And these are the patches required to address the following input - > > 1. The NAND driver needs to stop tinkering with the GPMC registers > > The omap General Purpose Memory Controller (GPMC) registers are > omap > > specific, and not driver specific. Tinkering with these registers > can > > cause issues with the other devices on the GPMC. > > > > 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files > > Passing hardcoded GPMC virtual addressess is sure way to mess up > things. > > This should all become unnecessary once the NAND drivers stops > messing > > with the GPMC registers directly. > > Discussion: http://www.mail-archive.com/linux- > o...@vger.kernel.org/msg27630.html > > > > Changes in this series - > > Unused function removed. > > > > Functions related to ecc and prefetch engine are optimized. > > v4: http://www.mail-archive.com/linux- > o...@vger.kernel.org/msg29458.html > > > > Few functionality was missing like - There should be some locking as > only > > one chipselect can use the ECC or prefetch engine at a time. If you > have > > NAND in two chipselects, bad things would happen. > > v3: http://www.mail-archive.com/linux- > o...@vger.kernel.org/msg28715.html > > > > Additionally, it was needed to implement more functions for the > platform > > init code to use. > > v2: http://www.mail-archive.com/linux- > o...@vger.kernel.org/msg28467.html > > > > v1: http://www.mail-archive.com/linux- > o...@vger.kernel.org/msg28164.html > > > > > > Sukumar Ghorai (3): > > omap3 gpmc: functionality enhancement > > omap3 nand: cleanup virtual address usages > > omap3 nand: fix issue in board file to detect nand > > arch/arm/mach-omap2/board-cm-t35.c | 20 +--- > > arch/arm/mach-omap2/board-devkit8000.c | 25 +--- > > arch/arm/mach-omap2/board-omap3beagle.c | 24 +--- > > arch/arm/mach-omap2/board-omap3touchbook.c | 25 +--- > > arch/arm/mach-omap2/board-overo.c | 24 +--- > > arch/arm/mach-omap2/board-sdp-flash.c | 5 - > > arch/arm/mach-omap2/gpmc-nand.c | 39 ++ > > arch/arm/mach-omap2/gpmc.c | 228 > +--- > > arch/arm/plat-omap/include/plat/gpmc.h | 36 - > > arch/arm/plat-omap/include/plat/nand.h | 6 +- > > drivers/mtd/nand/omap2.c | 229 - > --- > > 11 files changed, 320 insertions(+), 341 deletions(-) [Ghorai] Any comments or input on these patch? > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > > the body of a message to majord...@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > > -- > Regards, > Vimal Singh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 0/3] omap3 nand: cleanup exiting platform related code
Reviewed-by: Vimal Singh On Fri, Jun 4, 2010 at 1:10 PM, Sukumar Ghorai wrote: > The following set of patches applies on top of for-next branch. > http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git > Patches verified on: omap3430-SDP, omap3630-sdp, zoom3 and beagle board > > And these are the patches required to address the following input - > 1. The NAND driver needs to stop tinkering with the GPMC registers > The omap General Purpose Memory Controller (GPMC) registers are omap > specific, and not driver specific. Tinkering with these registers can > cause issues with the other devices on the GPMC. > > 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files > Passing hardcoded GPMC virtual addressess is sure way to mess up > things. > This should all become unnecessary once the NAND drivers stops messing > with the GPMC registers directly. > Discussion: > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg27630.html > > Changes in this series - > Unused function removed. > > Functions related to ecc and prefetch engine are optimized. > v4: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg29458.html > > Few functionality was missing like - There should be some locking as only > one chipselect can use the ECC or prefetch engine at a time. If you have > NAND in two chipselects, bad things would happen. > v3: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28715.html > > Additionally, it was needed to implement more functions for the platform > init code to use. > v2: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28467.html > > v1: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28164.html > > > Sukumar Ghorai (3): > omap3 gpmc: functionality enhancement > omap3 nand: cleanup virtual address usages > omap3 nand: fix issue in board file to detect nand > arch/arm/mach-omap2/board-cm-t35.c | 20 +--- > arch/arm/mach-omap2/board-devkit8000.c | 25 +--- > arch/arm/mach-omap2/board-omap3beagle.c | 24 +--- > arch/arm/mach-omap2/board-omap3touchbook.c | 25 +--- > arch/arm/mach-omap2/board-overo.c | 24 +--- > arch/arm/mach-omap2/board-sdp-flash.c | 5 - > arch/arm/mach-omap2/gpmc-nand.c | 39 ++ > arch/arm/mach-omap2/gpmc.c | 228 > +--- > arch/arm/plat-omap/include/plat/gpmc.h | 36 - > arch/arm/plat-omap/include/plat/nand.h | 6 +- > drivers/mtd/nand/omap2.c | 229 > > 11 files changed, 320 insertions(+), 341 deletions(-) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Regards, Vimal Singh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v5 0/3] omap3 nand: cleanup exiting platform related code
The following set of patches applies on top of for-next branch. http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git Patches verified on: omap3430-SDP, omap3630-sdp, zoom3 and beagle board And these are the patches required to address the following input - 1. The NAND driver needs to stop tinkering with the GPMC registers The omap General Purpose Memory Controller (GPMC) registers are omap specific, and not driver specific. Tinkering with these registers can cause issues with the other devices on the GPMC. 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files Passing hardcoded GPMC virtual addressess is sure way to mess up things. This should all become unnecessary once the NAND drivers stops messing with the GPMC registers directly. Discussion: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg27630.html Changes in this series - Unused function removed. Functions related to ecc and prefetch engine are optimized. v4: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg29458.html Few functionality was missing like - There should be some locking as only one chipselect can use the ECC or prefetch engine at a time. If you have NAND in two chipselects, bad things would happen. v3: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28715.html Additionally, it was needed to implement more functions for the platform init code to use. v2: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28467.html v1: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28164.html Sukumar Ghorai (3): omap3 gpmc: functionality enhancement omap3 nand: cleanup virtual address usages omap3 nand: fix issue in board file to detect nand arch/arm/mach-omap2/board-cm-t35.c | 20 +--- arch/arm/mach-omap2/board-devkit8000.c | 25 +--- arch/arm/mach-omap2/board-omap3beagle.c| 24 +--- arch/arm/mach-omap2/board-omap3touchbook.c | 25 +--- arch/arm/mach-omap2/board-overo.c | 24 +--- arch/arm/mach-omap2/board-sdp-flash.c |5 - arch/arm/mach-omap2/gpmc-nand.c| 39 ++ arch/arm/mach-omap2/gpmc.c | 228 +--- arch/arm/plat-omap/include/plat/gpmc.h | 36 - arch/arm/plat-omap/include/plat/nand.h |6 +- drivers/mtd/nand/omap2.c | 229 11 files changed, 320 insertions(+), 341 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
