Re: [PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature
On Thursday 18 February 2010 15:06:21 ext Jarkko Nikula wrote: > On Wed, 17 Feb 2010 16:45:58 +0200 > > Ilkka Koskinen wrote: > > The first patch implements McBSP sidetone feature on OMAP3 while the > > second one provides ALSA interface for using it. > > Do I have something wrong since I cannot adjust the controls? Both > "McBSP2 Sidetone Channel [0|1]" show 50%. Hmmm, at least there is no way to set the ch1 gain... I'll comment in the patch. > > I used line wrapped diff below. -- Péter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature
On Wed, 17 Feb 2010 16:45:58 +0200
Ilkka Koskinen wrote:
> The first patch implements McBSP sidetone feature on OMAP3 while the second
> one
> provides ALSA interface for using it.
>
Do I have something wrong since I cannot adjust the controls? Both
"McBSP2 Sidetone Channel [0|1]" show 50%.
I used line wrapped diff below.
--
Jarkko
diff --git a/sound/soc/omap/omap3beagle.c b/sound/soc/omap/omap3beagle.c
index d88ad5c..ac4f287 100644
--- a/sound/soc/omap/omap3beagle.c
+++ b/sound/soc/omap/omap3beagle.c
@@ -84,6 +84,11 @@ static int omap3beagle_hw_params(struct
snd_pcm_substream *substream, return 0;
}
+static int omap3beagle_init(struct snd_soc_codec *codec)
+{
+ return omap_mcbsp_st_add_controls(codec, 2);
+}
+
static struct snd_soc_ops omap3beagle_ops = {
.hw_params = omap3beagle_hw_params,
};
@@ -95,6 +100,7 @@ static struct snd_soc_dai_link omap3beagle_dai = {
.cpu_dai = &omap_mcbsp_dai[0],
.codec_dai = &twl4030_dai[TWL4030_DAI_HIFI],
.ops = &omap3beagle_ops,
+ .init = omap3beagle_init,
};
/* Audio machine driver */
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature
The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. The patch set is based on the patch Eduardo Valentin sent to alsa-devel mailing list in October 2009. Channel gain control and enabling the sidetone have been moved to ALSA interface as suggested in comments. These patches apply on top of Janusz Krzysztofik's McBSP register cache patches in linux-omap-2.6.git Since previous review round, I have combined McBSP port specific omap_mcbsp_st_set_mode() and omap_mcbsp_st_put_mode() functions to corresponding ones as suggested by Peter Ujfalusi. Eero Nurkkala (1): McBSP: OMAP3: Add sidetone feature Ilkka Koskinen (1): ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat-omap/include/plat/mcbsp.h | 63 + arch/arm/plat-omap/mcbsp.c | 394 ++- sound/soc/omap/omap-mcbsp.c | 176 ++ sound/soc/omap/omap-mcbsp.h |2 + 5 files changed, 636 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature
The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. The patch set is based on the patch Eduardo Valentin sent to alsa-devel mailing list in October 2009. Channel gain control and enabling the sidetone have been moved to ALSA interface as suggested in comments. Since previous review round, I have corrected both the pointed issues in ASoC patch. In addition, I rebased this patch on top of Janusz Krzysztofik's McBSP register cache patches in linux-omap-2.6.git Eero Nurkkala (1): McBSP: OMAP3: Add sidetone feature Ilkka Koskinen (1): ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat-omap/include/plat/mcbsp.h | 63 + arch/arm/plat-omap/mcbsp.c | 394 ++- sound/soc/omap/omap-mcbsp.c | 176 ++ sound/soc/omap/omap-mcbsp.h |2 + 5 files changed, 636 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
