Re: [PATCHv3 00/41] OMAPDSS: DT support v3
On 10/03/14 17:41, Tony Lindgren wrote: How about do a pull request for just the .dts changes against current omap-for-v3.15/dt branch ASAP for me so I can pull it in? That is assuming that just the .dts changes alone won't break anything. Unfortunately they do break. At least pinmuxing is moved from the global definitions to be handled by the respective display drivers, and there are some regulator_name hacks that the DT patches remove. OK. Will that cause regressions for omap3 as that's still also booting in legacy mode? No, I don't think so. The problems revolve around the pdata-quirks, with current DSS support when booting with DT. It's rather difficult to split the series so that it could be merged freely in multiple parts. If I split the series into three parts: 1) .dts changes 2) main DSS DT changes 3) removal of pdata-quirks etc, I run into problems. Both 1) and 2) work fine individually, but when both are merged, there are two competing systems, the proper DT stuff and the pdata-quirks stuff. And I haven't found out a simple way to manage that, as the whole display support is split into multiple independent devices. One option would be to combine 1) and 3), so that when they are merged, there would be proper DT data, and the pdata-quirks would be removed so that it wouldn't be messing everything up. But that would, of course, mean that after merging 1+3, the display wouldn't work on those boards that rely on pdata-quirks, until 2) is merged. I think those changes could be removed from my patches, and then added back later when everything else has been merged. Or you could have a second branch that also merges in omap-for-v3.15/dt branch that you can send later towards the merge window after the arm-soc changes have been merged. If you want to do that, then feel free to add my ack also for the .dts changes: Acked-by: Tony Lindgren t...@atomide.com If however those changes get postponed to v3.16, it's best that you'll redo the branch as I'm sure we'll have other merge issues for v3.16. Ok. At the moment I feel that the easiest option would be to keep the DSS DT series as it is, but merge omap-for-v3.15/dt to it and solve the conflicts. I'd keep that branch separate from the fbdev changes, so that I could send the DSS DT pull request later, when arm-soc has been pulled. The bigger issue is that suddenly there's lots of discussion about the display DT bindings. If those are not resolved very soon, I guess I have no choice but to again skip the merge window for the DSS DT changes. OK, some of these more bindings can take easily six months to reach some kind of resolution. You may be able to use TI specific unstable bindings meanwhile if that makese sense. Yep. I don't know... If the whole port/endpoint system that I currently use is changed totally, it might be painful to support both the TI specific bindings with the old format and the newer format. Tomi signature.asc Description: OpenPGP digital signature
Re: [PATCHv3 00/41] OMAPDSS: DT support v3
* Tomi Valkeinen tomi.valkei...@ti.com [140311 03:19]: On 10/03/14 17:41, Tony Lindgren wrote: How about do a pull request for just the .dts changes against current omap-for-v3.15/dt branch ASAP for me so I can pull it in? That is assuming that just the .dts changes alone won't break anything. Unfortunately they do break. At least pinmuxing is moved from the global definitions to be handled by the respective display drivers, and there are some regulator_name hacks that the DT patches remove. OK. Will that cause regressions for omap3 as that's still also booting in legacy mode? No, I don't think so. The problems revolve around the pdata-quirks, with current DSS support when booting with DT. It's rather difficult to split the series so that it could be merged freely in multiple parts. If I split the series into three parts: 1) .dts changes 2) main DSS DT changes 3) removal of pdata-quirks etc, I run into problems. Both 1) and 2) work fine individually, but when both are merged, there are two competing systems, the proper DT stuff and the pdata-quirks stuff. And I haven't found out a simple way to manage that, as the whole display support is split into multiple independent devices. One option would be to combine 1) and 3), so that when they are merged, there would be proper DT data, and the pdata-quirks would be removed so that it wouldn't be messing everything up. But that would, of course, mean that after merging 1+3, the display wouldn't work on those boards that rely on pdata-quirks, until 2) is merged. OK, best to keep the series together then. I think those changes could be removed from my patches, and then added back later when everything else has been merged. Or you could have a second branch that also merges in omap-for-v3.15/dt branch that you can send later towards the merge window after the arm-soc changes have been merged. If you want to do that, then feel free to add my ack also for the .dts changes: Acked-by: Tony Lindgren t...@atomide.com If however those changes get postponed to v3.16, it's best that you'll redo the branch as I'm sure we'll have other merge issues for v3.16. Ok. At the moment I feel that the easiest option would be to keep the DSS DT series as it is, but merge omap-for-v3.15/dt to it and solve the conflicts. I'd keep that branch separate from the fbdev changes, so that I could send the DSS DT pull request later, when arm-soc has been pulled. OK makes sense to me. The bigger issue is that suddenly there's lots of discussion about the display DT bindings. If those are not resolved very soon, I guess I have no choice but to again skip the merge window for the DSS DT changes. OK, some of these more bindings can take easily six months to reach some kind of resolution. You may be able to use TI specific unstable bindings meanwhile if that makese sense. Yep. I don't know... If the whole port/endpoint system that I currently use is changed totally, it might be painful to support both the TI specific bindings with the old format and the newer format. OK that's up you guys in the display land, I have not followed the latest bindings discussion. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv3 00/41] OMAPDSS: DT support v3
On 07/03/14 18:49, Tony Lindgren wrote: * Tomi Valkeinen tomi.valkei...@ti.com [140305 23:32]: Hi Tony, On 21/01/14 12:56, Tomi Valkeinen wrote: Hi, Here's version 3 of the DSS DT series. Can you have a look at the arch/arm/ parts in the series and ack if they're ok, i.e, patches 1, 2, 32. Patches 1, 2 32 look OK to me, so for those please feel free to add: Acked-by: Tony Lindgren t...@atomide.com Thanks. How about do a pull request for just the .dts changes against current omap-for-v3.15/dt branch ASAP for me so I can pull it in? That is assuming that just the .dts changes alone won't break anything. Unfortunately they do break. At least pinmuxing is moved from the global definitions to be handled by the respective display drivers, and there are some regulator_name hacks that the DT patches remove. I think those changes could be removed from my patches, and then added back later when everything else has been merged. The bigger issue is that suddenly there's lots of discussion about the display DT bindings. If those are not resolved very soon, I guess I have no choice but to again skip the merge window for the DSS DT changes. Tomi signature.asc Description: OpenPGP digital signature
Re: [PATCHv3 00/41] OMAPDSS: DT support v3
* Tomi Valkeinen tomi.valkei...@ti.com [140310 06:26]: On 07/03/14 18:49, Tony Lindgren wrote: * Tomi Valkeinen tomi.valkei...@ti.com [140305 23:32]: Hi Tony, On 21/01/14 12:56, Tomi Valkeinen wrote: Hi, Here's version 3 of the DSS DT series. Can you have a look at the arch/arm/ parts in the series and ack if they're ok, i.e, patches 1, 2, 32. Patches 1, 2 32 look OK to me, so for those please feel free to add: Acked-by: Tony Lindgren t...@atomide.com Thanks. How about do a pull request for just the .dts changes against current omap-for-v3.15/dt branch ASAP for me so I can pull it in? That is assuming that just the .dts changes alone won't break anything. Unfortunately they do break. At least pinmuxing is moved from the global definitions to be handled by the respective display drivers, and there are some regulator_name hacks that the DT patches remove. OK. Will that cause regressions for omap3 as that's still also booting in legacy mode? I think those changes could be removed from my patches, and then added back later when everything else has been merged. Or you could have a second branch that also merges in omap-for-v3.15/dt branch that you can send later towards the merge window after the arm-soc changes have been merged. If you want to do that, then feel free to add my ack also for the .dts changes: Acked-by: Tony Lindgren t...@atomide.com If however those changes get postponed to v3.16, it's best that you'll redo the branch as I'm sure we'll have other merge issues for v3.16. The bigger issue is that suddenly there's lots of discussion about the display DT bindings. If those are not resolved very soon, I guess I have no choice but to again skip the merge window for the DSS DT changes. OK, some of these more bindings can take easily six months to reach some kind of resolution. You may be able to use TI specific unstable bindings meanwhile if that makese sense. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv3 00/41] OMAPDSS: DT support v3
* Tomi Valkeinen tomi.valkei...@ti.com [140305 23:32]: Hi Tony, On 21/01/14 12:56, Tomi Valkeinen wrote: Hi, Here's version 3 of the DSS DT series. Can you have a look at the arch/arm/ parts in the series and ack if they're ok, i.e, patches 1, 2, 32. Patches 1, 2 32 look OK to me, so for those please feel free to add: Acked-by: Tony Lindgren t...@atomide.com There's a minor merge conflict in pdata-quirks.c, but that's trivial so it should be OK for you to queue those along with the DSS patches. Then there are the .dts patches, 22-30, for which I haven't been able to get any acks. I'm not sure who I should get acks from for those, but I don't mind adding yours if you want to give it. The .dts patches have had minor changes compared to the ones posted here, according to the DT bindings review comments, but nothing much has changed. These will cause unnecessary merge conflicts all over the place: Auto-merging arch/arm/boot/dts/omap4.dtsi CONFLICT (content): Merge conflict in arch/arm/boot/dts/omap4.dtsi Auto-merging arch/arm/boot/dts/omap4-sdp.dts CONFLICT (content): Merge conflict in arch/arm/boot/dts/omap4-sdp.dts Auto-merging arch/arm/boot/dts/omap4-panda-common.dtsi CONFLICT (content): Merge conflict in arch/arm/boot/dts/omap4-panda-common.dtsi Auto-merging arch/arm/boot/dts/omap3.dtsi Auto-merging arch/arm/boot/dts/omap3-n900.dts CONFLICT (content): Merge conflict in arch/arm/boot/dts/omap3-n900.dts Auto-merging arch/arm/boot/dts/omap3-igep0020.dts CONFLICT (content): Merge conflict in arch/arm/boot/dts/omap3-igep0020.dts Auto-merging arch/arm/boot/dts/omap3-beagle.dts CONFLICT (content): Merge conflict in arch/arm/boot/dts/omap3-beagle.dts Auto-merging arch/arm/boot/dts/omap3-beagle-xm.dts CONFLICT (content): Merge conflict in arch/arm/boot/dts/omap3-beagle-xm.dts How about do a pull request for just the .dts changes against current omap-for-v3.15/dt branch ASAP for me so I can pull it in? That is assuming that just the .dts changes alone won't break anything. Then make sure your series works both ways and maybe do a follow up patch that flips things over after the dependencies are merged. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv3 00/41] OMAPDSS: DT support v3
Hi Tony, On 21/01/14 12:56, Tomi Valkeinen wrote: Hi, Here's version 3 of the DSS DT series. Can you have a look at the arch/arm/ parts in the series and ack if they're ok, i.e, patches 1, 2, 32. Then there are the .dts patches, 22-30, for which I haven't been able to get any acks. I'm not sure who I should get acks from for those, but I don't mind adding yours if you want to give it. The .dts patches have had minor changes compared to the ones posted here, according to the DT bindings review comments, but nothing much has changed. Tomi signature.asc Description: OpenPGP digital signature
Re: [PATCHv3 00/41] OMAPDSS: DT support v3
Hi Tomi, On Tue, Jan 21, 2014 at 7:56 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, Here's version 3 of the DSS DT series. The previous version can be found from: v1: http://permalink.gmane.org/gmane.linux.ports.arm.omap/108249 v2: http://permalink.gmane.org/gmane.linux.ports.arm.omap/108866 The main changes to v2 are: - DT Binding documentation - OMAP2 DSS support - Split DSI register space - DSS nodes disabled by default - Hack to have generic DT bindings but OMAP specific drivers (for now) This series can also be found from: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git work/dss-dt-review-3 I tested this branch on my DM3730 IGEPv2 and output display is working correctly. Tested-by: Javier Martinez Canillas jav...@dowhile0.org Tomi Javier Martinez Canillas (1): ARM: omap3-igep0020.dts: add display information Sebastian Reichel (1): OMAPDSS: acx565akm: Add DT support Tomi Valkeinen (39): ARM: OMAP2+: add omapdss_init_of() ARM: OMAP2+: DT 'compatible' tweak for displays OMAPDSS: add 'label' support for DT OMAPDSS: get dssdev-alias from DT alias OMAPFB: clean up default display search OMAPFB: search for default display with DT alias OMAPDSS: add of helpers OMAPDSS: Improve regulator names for DT OMAPDSS: Add DT support to DSS OMAPDSS: Add DT support to DISPC OMAPDSS: Add DT support to HDMI OMAPDSS: Add DT support to VENC OMAPDSS: Add DT support to DSI OMAPDSS: panel-dsi-cm: Add DT support OMAPDSS: encoder-tfp410: Add DT support OMAPDSS: connector-dvi: Add DT support OMAPDSS: encoder-tpd12s015: Add DT support OMAPDSS: hdmi-connector: Add DT support OMAPDSS: panel-dpi: Add DT support OMAPDSS: connector-analog-tv: Add DT support ARM: omap2.dtsi: add omapdss information ARM: omap3.dtsi: add omapdss information ARM: omap4.dtsi: add omapdss information ARM: omap4-panda.dts: add display information ARM: omap4-sdp.dts: add display information ARM: omap3-beagle.dts: add display information ARM: omap3-beagle-xm.dts: add display information ARM: omap3-n900.dts: add display information OMAPDSS: remove DT hacks for regulators ARM: OMAP2+: remove pdata quirks for displays Doc/DT: Add OMAP DSS DT Bindings Doc/DT: Add DT binding documentation for Analog TV Connector Doc/DT: Add DT binding documentation for DVI Connector Doc/DT: Add DT binding documentation for HDMI Connector Doc/DT: Add DT binding documentation for MIPI DPI Panel Doc/DT: Add DT binding documentation for MIPI DSI CM Panel Doc/DT: Add DT binding documentation for Sony acx565akm panel Doc/DT: Add DT binding documentation for TFP410 encoder Doc/DT: Add DT binding documentation for tpd12s015 encoder .../bindings/video/analog-tv-connector.txt | 23 +++ .../devicetree/bindings/video/dvi-connector.txt| 26 +++ .../devicetree/bindings/video/hdmi-connector.txt | 23 +++ .../devicetree/bindings/video/panel-dpi.txt| 43 .../devicetree/bindings/video/panel-dsi-cm.txt | 26 +++ .../devicetree/bindings/video/sony,acx565akm.txt | 28 +++ .../devicetree/bindings/video/ti,omap-dss.txt | 197 ++ .../devicetree/bindings/video/ti,omap2-dss.txt | 54 + .../devicetree/bindings/video/ti,omap3-dss.txt | 73 +++ .../devicetree/bindings/video/ti,omap4-dss.txt | 99 + .../devicetree/bindings/video/ti,tfp410.txt| 41 .../devicetree/bindings/video/ti,tpd12s015.txt | 44 .../devicetree/bindings/video/video-ports.txt | 22 ++ arch/arm/boot/dts/omap2.dtsi | 31 +++ arch/arm/boot/dts/omap3-beagle-xm.dts | 119 +++ arch/arm/boot/dts/omap3-beagle.dts | 116 +++ arch/arm/boot/dts/omap3-igep0020.dts | 59 +- arch/arm/boot/dts/omap3-n900.dts | 70 ++- arch/arm/boot/dts/omap3.dtsi | 42 arch/arm/boot/dts/omap4-panda-common.dtsi | 119 ++- arch/arm/boot/dts/omap4-sdp.dts| 107 +- arch/arm/boot/dts/omap4.dtsi | 65 ++ arch/arm/mach-omap2/board-generic.c| 4 + arch/arm/mach-omap2/common.h | 3 + arch/arm/mach-omap2/display.c | 132 arch/arm/mach-omap2/dss-common.c | 224 - arch/arm/mach-omap2/pdata-quirks.c | 3 - .../video/omap2/displays-new/connector-analog-tv.c | 43 +++- drivers/video/omap2/displays-new/connector-dvi.c | 43 drivers/video/omap2/displays-new/connector-hdmi.c | 30 +++ drivers/video/omap2/displays-new/encoder-tfp410.c | 43 +++- .../video/omap2/displays-new/encoder-tpd12s015.c | 56 ++ drivers/video/omap2/displays-new/panel-dpi.c | 64 +-
Re: [PATCHv3 00/41] OMAPDSS: DT support v3
On 2014-01-21 23:29, Nishanth Menon wrote: Tomi, On 01/21/2014 04:56 AM, Tomi Valkeinen wrote: Hi, Here's version 3 of the DSS DT series. The previous version can be found from: v1: http://permalink.gmane.org/gmane.linux.ports.arm.omap/108249 v2: http://permalink.gmane.org/gmane.linux.ports.arm.omap/108866 The main changes to v2 are: - DT Binding documentation - OMAP2 DSS support - Split DSI register space - DSS nodes disabled by default - Hack to have generic DT bindings but OMAP specific drivers (for now) This series can also be found from: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git work/dss-dt-review-3 http://slexy.org/view/s20JhteOFR is my quick build test report - few checkpatch and build bisect issues would probably need fixing. Thanks. Shouldn't make trivial changes, and then not run a full commit-by-commit compile test... I fixed the issues and pushed the branch again to work/dss-dt-review-3. The fixes are minor, so the already posted series can be reviewed. Tomi signature.asc Description: OpenPGP digital signature
[PATCHv3 00/41] OMAPDSS: DT support v3
Hi, Here's version 3 of the DSS DT series. The previous version can be found from: v1: http://permalink.gmane.org/gmane.linux.ports.arm.omap/108249 v2: http://permalink.gmane.org/gmane.linux.ports.arm.omap/108866 The main changes to v2 are: - DT Binding documentation - OMAP2 DSS support - Split DSI register space - DSS nodes disabled by default - Hack to have generic DT bindings but OMAP specific drivers (for now) This series can also be found from: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git work/dss-dt-review-3 Tomi Javier Martinez Canillas (1): ARM: omap3-igep0020.dts: add display information Sebastian Reichel (1): OMAPDSS: acx565akm: Add DT support Tomi Valkeinen (39): ARM: OMAP2+: add omapdss_init_of() ARM: OMAP2+: DT 'compatible' tweak for displays OMAPDSS: add 'label' support for DT OMAPDSS: get dssdev-alias from DT alias OMAPFB: clean up default display search OMAPFB: search for default display with DT alias OMAPDSS: add of helpers OMAPDSS: Improve regulator names for DT OMAPDSS: Add DT support to DSS OMAPDSS: Add DT support to DISPC OMAPDSS: Add DT support to HDMI OMAPDSS: Add DT support to VENC OMAPDSS: Add DT support to DSI OMAPDSS: panel-dsi-cm: Add DT support OMAPDSS: encoder-tfp410: Add DT support OMAPDSS: connector-dvi: Add DT support OMAPDSS: encoder-tpd12s015: Add DT support OMAPDSS: hdmi-connector: Add DT support OMAPDSS: panel-dpi: Add DT support OMAPDSS: connector-analog-tv: Add DT support ARM: omap2.dtsi: add omapdss information ARM: omap3.dtsi: add omapdss information ARM: omap4.dtsi: add omapdss information ARM: omap4-panda.dts: add display information ARM: omap4-sdp.dts: add display information ARM: omap3-beagle.dts: add display information ARM: omap3-beagle-xm.dts: add display information ARM: omap3-n900.dts: add display information OMAPDSS: remove DT hacks for regulators ARM: OMAP2+: remove pdata quirks for displays Doc/DT: Add OMAP DSS DT Bindings Doc/DT: Add DT binding documentation for Analog TV Connector Doc/DT: Add DT binding documentation for DVI Connector Doc/DT: Add DT binding documentation for HDMI Connector Doc/DT: Add DT binding documentation for MIPI DPI Panel Doc/DT: Add DT binding documentation for MIPI DSI CM Panel Doc/DT: Add DT binding documentation for Sony acx565akm panel Doc/DT: Add DT binding documentation for TFP410 encoder Doc/DT: Add DT binding documentation for tpd12s015 encoder .../bindings/video/analog-tv-connector.txt | 23 +++ .../devicetree/bindings/video/dvi-connector.txt| 26 +++ .../devicetree/bindings/video/hdmi-connector.txt | 23 +++ .../devicetree/bindings/video/panel-dpi.txt| 43 .../devicetree/bindings/video/panel-dsi-cm.txt | 26 +++ .../devicetree/bindings/video/sony,acx565akm.txt | 28 +++ .../devicetree/bindings/video/ti,omap-dss.txt | 197 ++ .../devicetree/bindings/video/ti,omap2-dss.txt | 54 + .../devicetree/bindings/video/ti,omap3-dss.txt | 73 +++ .../devicetree/bindings/video/ti,omap4-dss.txt | 99 + .../devicetree/bindings/video/ti,tfp410.txt| 41 .../devicetree/bindings/video/ti,tpd12s015.txt | 44 .../devicetree/bindings/video/video-ports.txt | 22 ++ arch/arm/boot/dts/omap2.dtsi | 31 +++ arch/arm/boot/dts/omap3-beagle-xm.dts | 119 +++ arch/arm/boot/dts/omap3-beagle.dts | 116 +++ arch/arm/boot/dts/omap3-igep0020.dts | 59 +- arch/arm/boot/dts/omap3-n900.dts | 70 ++- arch/arm/boot/dts/omap3.dtsi | 42 arch/arm/boot/dts/omap4-panda-common.dtsi | 119 ++- arch/arm/boot/dts/omap4-sdp.dts| 107 +- arch/arm/boot/dts/omap4.dtsi | 65 ++ arch/arm/mach-omap2/board-generic.c| 4 + arch/arm/mach-omap2/common.h | 3 + arch/arm/mach-omap2/display.c | 132 arch/arm/mach-omap2/dss-common.c | 224 - arch/arm/mach-omap2/pdata-quirks.c | 3 - .../video/omap2/displays-new/connector-analog-tv.c | 43 +++- drivers/video/omap2/displays-new/connector-dvi.c | 43 drivers/video/omap2/displays-new/connector-hdmi.c | 30 +++ drivers/video/omap2/displays-new/encoder-tfp410.c | 43 +++- .../video/omap2/displays-new/encoder-tpd12s015.c | 56 ++ drivers/video/omap2/displays-new/panel-dpi.c | 64 +- drivers/video/omap2/displays-new/panel-dsi-cm.c| 65 +- .../omap2/displays-new/panel-sony-acx565akm.c | 33 ++- drivers/video/omap2/dss/Makefile | 2 +- drivers/video/omap2/dss/dispc.c| 8 + drivers/video/omap2/dss/display.c | 28 ++- drivers/video/omap2/dss/dpi.c |
Re: [PATCHv3 00/41] OMAPDSS: DT support v3
Tomi, On 01/21/2014 04:56 AM, Tomi Valkeinen wrote: Hi, Here's version 3 of the DSS DT series. The previous version can be found from: v1: http://permalink.gmane.org/gmane.linux.ports.arm.omap/108249 v2: http://permalink.gmane.org/gmane.linux.ports.arm.omap/108866 The main changes to v2 are: - DT Binding documentation - OMAP2 DSS support - Split DSI register space - DSS nodes disabled by default - Hack to have generic DT bindings but OMAP specific drivers (for now) This series can also be found from: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git work/dss-dt-review-3 http://slexy.org/view/s20JhteOFR is my quick build test report - few checkpatch and build bisect issues would probably need fixing. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
