Re: [PATCHv4 8/8] ARM: OMAP4: PM: Added option for enabling OSWR
Hi Tero, On Fri, Apr 20, 2012 at 11:19 AM, Tero Kristo t-kri...@ti.com wrote: PM debug now contains a file that can be used to control OSWR support enable / disable on OMAP4. Also removed the off_mode_enable file for the same platform as it is unsupported. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/pm-debug.c | 20 arch/arm/mach-omap2/pm.h | 1 + arch/arm/mach-omap2/pm44xx.c | 16 3 files changed, 33 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c index 814bcd9..d9a8e42 100644 --- a/arch/arm/mach-omap2/pm-debug.c +++ b/arch/arm/mach-omap2/pm-debug.c @@ -39,6 +39,7 @@ #include pm.h u32 enable_off_mode; +static u32 enable_oswr_mode; #ifdef CONFIG_DEBUG_FS #include linux/debugfs.h @@ -247,10 +248,13 @@ static int option_set(void *data, u64 val) omap_pm_enable_off_mode(); else omap_pm_disable_off_mode(); - if (cpu_is_omap34xx()) - omap3_pm_off_mode_enable(val); + + omap3_pm_off_mode_enable(val); Great since this change removes a non-init cpu_is_xxx check. } + if (option == enable_oswr_mode) + omap4_pm_oswr_mode_enable(val); + return 0; } @@ -274,8 +278,16 @@ static int __init pm_dbg_init(void) pwrdm_for_each(pwrdms_setup, (void *)d); - (void) debugfs_create_file(enable_off_mode, S_IRUGO | S_IWUSR, d, - enable_off_mode, pm_dbg_option_fops); + if (cpu_is_omap34xx()) + (void) debugfs_create_file(enable_off_mode, + S_IRUGO | S_IWUSR, d, enable_off_mode, + pm_dbg_option_fops); Is the enable_off_mode entry needed on other OMAP platorms (OMAP3)? + + if (cpu_is_omap44xx()) + (void) debugfs_create_file(enable_oswr_mode, + S_IRUGO | S_IWUSR, d, enable_oswr_mode, + pm_dbg_option_fops); + pm_dbg_init_done = 1; Regards, Jean -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv4 8/8] ARM: OMAP4: PM: Added option for enabling OSWR
clip @@ -274,8 +278,16 @@ static int __init pm_dbg_init(void) pwrdm_for_each(pwrdms_setup, (void *)d); - (void) debugfs_create_file(enable_off_mode, S_IRUGO | S_IWUSR, d, - enable_off_mode, pm_dbg_option_fops); + if (cpu_is_omap34xx()) + (void) debugfs_create_file(enable_off_mode, + S_IRUGO | S_IWUSR, d, enable_off_mode, + pm_dbg_option_fops); Is the enable_off_mode entry needed on other OMAP platorms (OMAP3)? Actually I am not sure, I've never used OMAP2. It looks like at least the kernel does not support off-mode for OMAP2, but according to TRM it might be possible to support it on HW. -Tero -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCHv4 8/8] ARM: OMAP4: PM: Added option for enabling OSWR
PM debug now contains a file that can be used to control OSWR support
enable / disable on OMAP4. Also removed the off_mode_enable file for
the same platform as it is unsupported.
Signed-off-by: Tero Kristo t-kri...@ti.com
---
arch/arm/mach-omap2/pm-debug.c | 20
arch/arm/mach-omap2/pm.h |1 +
arch/arm/mach-omap2/pm44xx.c | 16
3 files changed, 33 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
index 814bcd9..d9a8e42 100644
--- a/arch/arm/mach-omap2/pm-debug.c
+++ b/arch/arm/mach-omap2/pm-debug.c
@@ -39,6 +39,7 @@
#include pm.h
u32 enable_off_mode;
+static u32 enable_oswr_mode;
#ifdef CONFIG_DEBUG_FS
#include linux/debugfs.h
@@ -247,10 +248,13 @@ static int option_set(void *data, u64 val)
omap_pm_enable_off_mode();
else
omap_pm_disable_off_mode();
- if (cpu_is_omap34xx())
- omap3_pm_off_mode_enable(val);
+
+ omap3_pm_off_mode_enable(val);
}
+ if (option == enable_oswr_mode)
+ omap4_pm_oswr_mode_enable(val);
+
return 0;
}
@@ -274,8 +278,16 @@ static int __init pm_dbg_init(void)
pwrdm_for_each(pwrdms_setup, (void *)d);
- (void) debugfs_create_file(enable_off_mode, S_IRUGO | S_IWUSR, d,
- enable_off_mode, pm_dbg_option_fops);
+ if (cpu_is_omap34xx())
+ (void) debugfs_create_file(enable_off_mode,
+ S_IRUGO | S_IWUSR, d, enable_off_mode,
+ pm_dbg_option_fops);
+
+ if (cpu_is_omap44xx())
+ (void) debugfs_create_file(enable_oswr_mode,
+ S_IRUGO | S_IWUSR, d, enable_oswr_mode,
+ pm_dbg_option_fops);
+
pm_dbg_init_done = 1;
return 0;
diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
index 256e63c..07ad800 100644
--- a/arch/arm/mach-omap2/pm.h
+++ b/arch/arm/mach-omap2/pm.h
@@ -17,6 +17,7 @@
extern void *omap3_secure_ram_storage;
extern void omap3_pm_off_mode_enable(int);
+extern void omap4_pm_oswr_mode_enable(int);
extern void omap_sram_idle(void);
extern int omap_set_pwrdm_state(struct powerdomain *pwrdm, u32 state);
extern int omap3_idle_init(void);
diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c
index cc85576..07ac0d3 100644
--- a/arch/arm/mach-omap2/pm44xx.c
+++ b/arch/arm/mach-omap2/pm44xx.c
@@ -115,6 +115,22 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm,
void *unused)
return omap_set_pwrdm_state(pwrst-pwrdm, pwrst-next_state);
}
+void omap4_pm_oswr_mode_enable(int enable)
+{
+ u32 next_logic_state;
+ struct power_state *pwrst;
+
+ if (enable)
+ next_logic_state = PWRDM_POWER_OFF;
+ else
+ next_logic_state = PWRDM_POWER_RET;
+
+ list_for_each_entry(pwrst, pwrst_list, node) {
+ pwrst-next_logic_state = next_logic_state;
+ pwrdm_set_logic_retst(pwrst-pwrdm, pwrst-next_logic_state);
+ }
+}
+
/**
* omap_default_idle - OMAP4 default ilde routine.'
*
--
1.7.4.1
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
