Re: [RFC/PATCH 1/3] omap3-iommu: reorganize

2009-05-18 Thread Russell King - ARM Linux 
On Sat, May 16, 2009 at 01:05:48PM +0300, Felipe Contreras wrote:
 +struct iommu_device {
 + resource_size_t base;
 + resource_size_t irq;
 + struct iommu_platform_data pdata;
 + struct resource res[2];
  };

The data which is needed per device is:

- base address
- IRQ (no need for this to be resource_size_t - int will do)
- platform data

There's no need for that res[2] being there.

 @@ -63,23 +51,35 @@ static int __init omap3_iommu_init(void)
  
   for (i = 0; i  NR_IOMMU_DEVICES; i++) {
   struct platform_device *pdev;
 + const struct iommu_device *d = devices[i];
 + struct resource res[] = {
 + { .flags = IORESOURCE_MEM },
 + { .flags = IORESOURCE_IRQ },
 + };

This initialization doesn't buy you anything, in fact quite the opposite.
The compiler actually interprets this as:

static struct resource __initial_res[] = {
{ .flags = IORESOURCE_MEM },
{ .flags = IORESOURCE_IRQ },
};
...
for () {
struct resource res[...];
memcpy(res, __initial_res, sizeof(__initial_res));

 +
 + res[0].start = d-base;
 + res[0].end = d-base + MMU_REG_SIZE - 1;
 +
 + res[1].start = d-irq;

It would be far better to initialize the flags element here for both.
And please also set res[1].end as I did in my patch.

 +
 + err = platform_device_add_resources(pdev, res, ARRAY_SIZE(res));
   if (err)
   goto err_out;
 - err = platform_device_add_data(pdev, omap3_iommu_pdata[i],
 -sizeof(omap3_iommu_pdata[0]));
 +
 + err = platform_device_add_data(pdev, d-pdata, 
 sizeof(d-pdata));

This will fail checkpatch.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH 1/3] omap3-iommu: reorganize

2009-05-18 Thread Felipe Contreras 
On Mon, May 18, 2009 at 3:07 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
 On Sat, May 16, 2009 at 01:05:48PM +0300, Felipe Contreras wrote:
 +struct iommu_device {
 +     resource_size_t base;
 +     resource_size_t irq;
 +     struct iommu_platform_data pdata;
 +     struct resource res[2];
  };

 The data which is needed per device is:

 - base address
 - IRQ (no need for this to be resource_size_t - int will do)
 - platform data

 There's no need for that res[2] being there.

Right, I was using 'res' but not any more; I forgot to remove it.

So resource_size_t is ok for 'base'?

 @@ -63,23 +51,35 @@ static int __init omap3_iommu_init(void)

       for (i = 0; i  NR_IOMMU_DEVICES; i++) {
               struct platform_device *pdev;
 +             const struct iommu_device *d = devices[i];
 +             struct resource res[] = {
 +                     { .flags = IORESOURCE_MEM },
 +                     { .flags = IORESOURCE_IRQ },
 +             };

 This initialization doesn't buy you anything, in fact quite the opposite.
 The compiler actually interprets this as:

 static struct resource __initial_res[] = {
        { .flags = IORESOURCE_MEM },
        { .flags = IORESOURCE_IRQ },
 };
 ...
        for () {
                struct resource res[...];
                memcpy(res, __initial_res, sizeof(__initial_res));

 +
 +             res[0].start = d-base;
 +             res[0].end = d-base + MMU_REG_SIZE - 1;
 +
 +             res[1].start = d-irq;

 It would be far better to initialize the flags element here for both.
 And please also set res[1].end as I did in my patch.

I think I saw that res initialization somewhere and I found it much
easier to read.

Ok. Will do.

 +
 +             err = platform_device_add_resources(pdev, res, 
 ARRAY_SIZE(res));
               if (err)
                       goto err_out;
 -             err = platform_device_add_data(pdev, omap3_iommu_pdata[i],
 -                                            sizeof(omap3_iommu_pdata[0]));
 +
 +             err = platform_device_add_data(pdev, d-pdata, 
 sizeof(d-pdata));

 This will fail checkpatch.

I'll make sure it passes.

Cheers.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RFC/PATCH 1/3] omap3-iommu: reorganize

2009-05-16 Thread Felipe Contreras 
From: Felipe Contreras felipe.contre...@nokia.com

No functional changes.

Signed-off-by: Felipe Contreras felipe.contre...@nokia.com
---
 arch/arm/mach-omap2/omap3-iommu.c |   72 ++--
 1 files changed, 36 insertions(+), 36 deletions(-)

diff --git a/arch/arm/mach-omap2/omap3-iommu.c 
b/arch/arm/mach-omap2/omap3-iommu.c
index 367f36a..f4232ec 100644
--- a/arch/arm/mach-omap2/omap3-iommu.c
+++ b/arch/arm/mach-omap2/omap3-iommu.c
@@ -14,43 +14,31 @@
 
 #include mach/iommu.h
 
-#define OMAP3_MMU1_BASE0x480bd400
-#define OMAP3_MMU2_BASE0x5d00
-#define OMAP3_MMU1_IRQ 24
-#define OMAP3_MMU2_IRQ 28
-
-static struct resource omap3_iommu_res[] = {
-   { /* Camera ISP MMU */
-   .start  = OMAP3_MMU1_BASE,
-   .end= OMAP3_MMU1_BASE + MMU_REG_SIZE - 1,
-   .flags  = IORESOURCE_MEM,
-   },
-   {
-   .start  = OMAP3_MMU1_IRQ,
-   .flags  = IORESOURCE_IRQ,
-   },
-   { /* IVA2.2 MMU */
-   .start  = OMAP3_MMU2_BASE,
-   .end= OMAP3_MMU2_BASE + MMU_REG_SIZE - 1,
-   .flags  = IORESOURCE_MEM,
-   },
-   {
-   .start  = OMAP3_MMU2_IRQ,
-   .flags  = IORESOURCE_IRQ,
-   },
+struct iommu_device {
+   resource_size_t base;
+   resource_size_t irq;
+   struct iommu_platform_data pdata;
+   struct resource res[2];
 };
-#define NR_IOMMU_RES (ARRAY_SIZE(omap3_iommu_res) / 2)
 
-static const struct iommu_platform_data omap3_iommu_pdata[] __initconst = {
+static struct iommu_device devices[] = {
{
-   .name = isp,
-   .nr_tlb_entries = 8,
-   .clk_name = cam_ick,
+   .base = 0x480bd400,
+   .irq = 24,
+   .pdata = {
+   .name = isp,
+   .nr_tlb_entries = 8,
+   .clk_name = cam_ick,
+   },
},
{
-   .name = iva2,
-   .nr_tlb_entries = 32,
-   .clk_name = iva2_ck,
+   .base = 0x5d00,
+   .irq = 28,
+   .pdata = {
+   .name = iva2,
+   .nr_tlb_entries = 32,
+   .clk_name = iva2_ck,
+   },
},
 };
 #define NR_IOMMU_DEVICES ARRAY_SIZE(omap3_iommu_pdata)
@@ -63,23 +51,35 @@ static int __init omap3_iommu_init(void)
 
for (i = 0; i  NR_IOMMU_DEVICES; i++) {
struct platform_device *pdev;
+   const struct iommu_device *d = devices[i];
+   struct resource res[] = {
+   { .flags = IORESOURCE_MEM },
+   { .flags = IORESOURCE_IRQ },
+   };
 
pdev = platform_device_alloc(omap-iommu, i + 1);
if (!pdev) {
err = -ENOMEM;
goto err_out;
}
-   err = platform_device_add_resources(pdev,
-   omap3_iommu_res[2 * i], NR_IOMMU_RES);
+
+   res[0].start = d-base;
+   res[0].end = d-base + MMU_REG_SIZE - 1;
+
+   res[1].start = d-irq;
+
+   err = platform_device_add_resources(pdev, res, ARRAY_SIZE(res));
if (err)
goto err_out;
-   err = platform_device_add_data(pdev, omap3_iommu_pdata[i],
-  sizeof(omap3_iommu_pdata[0]));
+
+   err = platform_device_add_data(pdev, d-pdata, 
sizeof(d-pdata));
if (err)
goto err_out;
+
err = platform_device_add(pdev);
if (err)
goto err_out;
+
omap3_iommu_pdev[i] = pdev;
}
return 0;
-- 
1.6.3.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RFC/PATCH 1/3] omap3-iommu: reorganize

2009-05-16 Thread Felipe Contreras 
No functional changes.

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
 arch/arm/mach-omap2/omap3-iommu.c |   72 ++--
 1 files changed, 36 insertions(+), 36 deletions(-)

diff --git a/arch/arm/mach-omap2/omap3-iommu.c 
b/arch/arm/mach-omap2/omap3-iommu.c
index 367f36a..f4232ec 100644
--- a/arch/arm/mach-omap2/omap3-iommu.c
+++ b/arch/arm/mach-omap2/omap3-iommu.c
@@ -14,43 +14,31 @@
 
 #include mach/iommu.h
 
-#define OMAP3_MMU1_BASE0x480bd400
-#define OMAP3_MMU2_BASE0x5d00
-#define OMAP3_MMU1_IRQ 24
-#define OMAP3_MMU2_IRQ 28
-
-static struct resource omap3_iommu_res[] = {
-   { /* Camera ISP MMU */
-   .start  = OMAP3_MMU1_BASE,
-   .end= OMAP3_MMU1_BASE + MMU_REG_SIZE - 1,
-   .flags  = IORESOURCE_MEM,
-   },
-   {
-   .start  = OMAP3_MMU1_IRQ,
-   .flags  = IORESOURCE_IRQ,
-   },
-   { /* IVA2.2 MMU */
-   .start  = OMAP3_MMU2_BASE,
-   .end= OMAP3_MMU2_BASE + MMU_REG_SIZE - 1,
-   .flags  = IORESOURCE_MEM,
-   },
-   {
-   .start  = OMAP3_MMU2_IRQ,
-   .flags  = IORESOURCE_IRQ,
-   },
+struct iommu_device {
+   resource_size_t base;
+   resource_size_t irq;
+   struct iommu_platform_data pdata;
+   struct resource res[2];
 };
-#define NR_IOMMU_RES (ARRAY_SIZE(omap3_iommu_res) / 2)
 
-static const struct iommu_platform_data omap3_iommu_pdata[] __initconst = {
+static struct iommu_device devices[] = {
{
-   .name = isp,
-   .nr_tlb_entries = 8,
-   .clk_name = cam_ick,
+   .base = 0x480bd400,
+   .irq = 24,
+   .pdata = {
+   .name = isp,
+   .nr_tlb_entries = 8,
+   .clk_name = cam_ick,
+   },
},
{
-   .name = iva2,
-   .nr_tlb_entries = 32,
-   .clk_name = iva2_ck,
+   .base = 0x5d00,
+   .irq = 28,
+   .pdata = {
+   .name = iva2,
+   .nr_tlb_entries = 32,
+   .clk_name = iva2_ck,
+   },
},
 };
 #define NR_IOMMU_DEVICES ARRAY_SIZE(omap3_iommu_pdata)
@@ -63,23 +51,35 @@ static int __init omap3_iommu_init(void)
 
for (i = 0; i  NR_IOMMU_DEVICES; i++) {
struct platform_device *pdev;
+   const struct iommu_device *d = devices[i];
+   struct resource res[] = {
+   { .flags = IORESOURCE_MEM },
+   { .flags = IORESOURCE_IRQ },
+   };
 
pdev = platform_device_alloc(omap-iommu, i + 1);
if (!pdev) {
err = -ENOMEM;
goto err_out;
}
-   err = platform_device_add_resources(pdev,
-   omap3_iommu_res[2 * i], NR_IOMMU_RES);
+
+   res[0].start = d-base;
+   res[0].end = d-base + MMU_REG_SIZE - 1;
+
+   res[1].start = d-irq;
+
+   err = platform_device_add_resources(pdev, res, ARRAY_SIZE(res));
if (err)
goto err_out;
-   err = platform_device_add_data(pdev, omap3_iommu_pdata[i],
-  sizeof(omap3_iommu_pdata[0]));
+
+   err = platform_device_add_data(pdev, d-pdata, 
sizeof(d-pdata));
if (err)
goto err_out;
+
err = platform_device_add(pdev);
if (err)
goto err_out;
+
omap3_iommu_pdev[i] = pdev;
}
return 0;
-- 
1.6.3.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RFC/PATCH 1/3] omap3-iommu: reorganize

2009-05-07 Thread Felipe Contreras 
No functional changes.

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
 arch/arm/mach-omap2/omap3-iommu.c |   72 ++--
 1 files changed, 36 insertions(+), 36 deletions(-)

diff --git a/arch/arm/mach-omap2/omap3-iommu.c 
b/arch/arm/mach-omap2/omap3-iommu.c
index 367f36a..f4232ec 100644
--- a/arch/arm/mach-omap2/omap3-iommu.c
+++ b/arch/arm/mach-omap2/omap3-iommu.c
@@ -14,43 +14,31 @@
 
 #include mach/iommu.h
 
-#define OMAP3_MMU1_BASE0x480bd400
-#define OMAP3_MMU2_BASE0x5d00
-#define OMAP3_MMU1_IRQ 24
-#define OMAP3_MMU2_IRQ 28
-
-static struct resource omap3_iommu_res[] = {
-   { /* Camera ISP MMU */
-   .start  = OMAP3_MMU1_BASE,
-   .end= OMAP3_MMU1_BASE + MMU_REG_SIZE - 1,
-   .flags  = IORESOURCE_MEM,
-   },
-   {
-   .start  = OMAP3_MMU1_IRQ,
-   .flags  = IORESOURCE_IRQ,
-   },
-   { /* IVA2.2 MMU */
-   .start  = OMAP3_MMU2_BASE,
-   .end= OMAP3_MMU2_BASE + MMU_REG_SIZE - 1,
-   .flags  = IORESOURCE_MEM,
-   },
-   {
-   .start  = OMAP3_MMU2_IRQ,
-   .flags  = IORESOURCE_IRQ,
-   },
+struct iommu_device {
+   resource_size_t base;
+   resource_size_t irq;
+   struct iommu_platform_data pdata;
+   struct resource res[2];
 };
-#define NR_IOMMU_RES (ARRAY_SIZE(omap3_iommu_res) / 2)
 
-static const struct iommu_platform_data omap3_iommu_pdata[] __initconst = {
+static struct iommu_device devices[] = {
{
-   .name = isp,
-   .nr_tlb_entries = 8,
-   .clk_name = cam_ick,
+   .base = 0x480bd400,
+   .irq = 24,
+   .pdata = {
+   .name = isp,
+   .nr_tlb_entries = 8,
+   .clk_name = cam_ick,
+   },
},
{
-   .name = iva2,
-   .nr_tlb_entries = 32,
-   .clk_name = iva2_ck,
+   .base = 0x5d00,
+   .irq = 28,
+   .pdata = {
+   .name = iva2,
+   .nr_tlb_entries = 32,
+   .clk_name = iva2_ck,
+   },
},
 };
 #define NR_IOMMU_DEVICES ARRAY_SIZE(omap3_iommu_pdata)
@@ -63,23 +51,35 @@ static int __init omap3_iommu_init(void)
 
for (i = 0; i  NR_IOMMU_DEVICES; i++) {
struct platform_device *pdev;
+   const struct iommu_device *d = devices[i];
+   struct resource res[] = {
+   { .flags = IORESOURCE_MEM },
+   { .flags = IORESOURCE_IRQ },
+   };
 
pdev = platform_device_alloc(omap-iommu, i + 1);
if (!pdev) {
err = -ENOMEM;
goto err_out;
}
-   err = platform_device_add_resources(pdev,
-   omap3_iommu_res[2 * i], NR_IOMMU_RES);
+
+   res[0].start = d-base;
+   res[0].end = d-base + MMU_REG_SIZE - 1;
+
+   res[1].start = d-irq;
+
+   err = platform_device_add_resources(pdev, res, ARRAY_SIZE(res));
if (err)
goto err_out;
-   err = platform_device_add_data(pdev, omap3_iommu_pdata[i],
-  sizeof(omap3_iommu_pdata[0]));
+
+   err = platform_device_add_data(pdev, d-pdata, 
sizeof(d-pdata));
if (err)
goto err_out;
+
err = platform_device_add(pdev);
if (err)
goto err_out;
+
omap3_iommu_pdev[i] = pdev;
}
return 0;
-- 
1.6.3.GIT

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH 1/3] omap3-iommu: reorganize

2009-05-07 Thread Felipe Balbi 
On Thu, May 07, 2009 at 10:11:07PM +0200, ext Felipe Contreras wrote:
 -static struct resource omap3_iommu_res[] = {
 - { /* Camera ISP MMU */
 - .start  = OMAP3_MMU1_BASE,
 - .end= OMAP3_MMU1_BASE + MMU_REG_SIZE - 1,
 - .flags  = IORESOURCE_MEM,
 - },
 - {
 - .start  = OMAP3_MMU1_IRQ,
 - .flags  = IORESOURCE_IRQ,
 - },
 - { /* IVA2.2 MMU */
 - .start  = OMAP3_MMU2_BASE,
 - .end= OMAP3_MMU2_BASE + MMU_REG_SIZE - 1,
 - .flags  = IORESOURCE_MEM,
 - },
 - {
 - .start  = OMAP3_MMU2_IRQ,
 - .flags  = IORESOURCE_IRQ,
 - },

i find this one much more readable :-s

 +struct iommu_device {
 + resource_size_t base;
 + resource_size_t irq;
 + struct iommu_platform_data pdata;

generally, platform_data is a void *. Don't know if it matters here.

 + struct resource res[2];
  };
 -#define NR_IOMMU_RES (ARRAY_SIZE(omap3_iommu_res) / 2)
  
 -static const struct iommu_platform_data omap3_iommu_pdata[] __initconst = {
 +static struct iommu_device devices[] = {
   {
 - .name = isp,
 - .nr_tlb_entries = 8,
 - .clk_name = cam_ick,
 + .base = 0x480bd400,
 + .irq = 24,
 + .pdata = {
 + .name = isp,
 + .nr_tlb_entries = 8,
 + .clk_name = cam_ick,

still passing clk names ? what about clkdev ?

-- 
balbi
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH 1/3] omap3-iommu: reorganize

2009-05-07 Thread Felipe Contreras 
On Fri, May 8, 2009 at 12:14 AM, Felipe Balbi felipe.ba...@nokia.com wrote:
 On Thu, May 07, 2009 at 10:11:07PM +0200, ext Felipe Contreras wrote:
 -static struct resource omap3_iommu_res[] = {
 -     { /* Camera ISP MMU */
 -             .start          = OMAP3_MMU1_BASE,
 -             .end            = OMAP3_MMU1_BASE + MMU_REG_SIZE - 1,
 -             .flags          = IORESOURCE_MEM,
 -     },
 -     {
 -             .start          = OMAP3_MMU1_IRQ,
 -             .flags          = IORESOURCE_IRQ,
 -     },
 -     { /* IVA2.2 MMU */
 -             .start          = OMAP3_MMU2_BASE,
 -             .end            = OMAP3_MMU2_BASE + MMU_REG_SIZE - 1,
 -             .flags          = IORESOURCE_MEM,
 -     },
 -     {
 -             .start          = OMAP3_MMU2_IRQ,
 -             .flags          = IORESOURCE_IRQ,
 -     },

 i find this one much more readable :-s

You find an array of 'struct resource' more readable than this?

+   .base = 0x480bd400,
+   .irq = 24,

+   .base = 0x5d00,
+   .irq = 28,

+   res[0].start = d-base;
+   res[0].end = d-base + MMU_REG_SIZE - 1;
+
+   res[1].start = d-irq;

How would you calculate the number of resources per iommu device?

How about these?

-   err = platform_device_add_resources(pdev,
-   omap3_iommu_res[2 * i], NR_IOMMU_RES);
+   err = platform_device_add_resources(pdev, res, ARRAY_SIZE(res));
   if (err)
   goto err_out;
-   err = platform_device_add_data(pdev, omap3_iommu_pdata[i],
-  sizeof(omap3_iommu_pdata[0]));
+   err = platform_device_add_data(pdev, d-pdata,
sizeof(d-pdata));
   if (err)
   goto err_out;

Do you find the original version easier to read?

 +struct iommu_device {
 +     resource_size_t base;
 +     resource_size_t irq;
 +     struct iommu_platform_data pdata;

 generally, platform_data is a void *. Don't know if it matters here.

Yes but we need to set the actual contents for platform_device_add_data.

 +     struct resource res[2];
  };
 -#define NR_IOMMU_RES (ARRAY_SIZE(omap3_iommu_res) / 2)

 -static const struct iommu_platform_data omap3_iommu_pdata[] __initconst = {
 +static struct iommu_device devices[] = {
       {
 -             .name = isp,
 -             .nr_tlb_entries = 8,
 -             .clk_name = cam_ick,
 +             .base = 0x480bd400,
 +             .irq = 24,
 +             .pdata = {
 +                     .name = isp,
 +                     .nr_tlb_entries = 8,
 +                     .clk_name = cam_ick,

 still passing clk names ? what about clkdev ?

That's for iommu to fix. I'm simply interested on decoupling iommu and
a hypothetical tidspbridge that doesn't exists yet.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH 1/3] omap3-iommu: reorganize

2009-05-07 Thread Hiroshi DOYU 
From: Balbi Felipe (Nokia-D/Helsinki) felipe.ba...@nokia.com
Subject: Re: [RFC/PATCH 1/3] omap3-iommu: reorganize
Date: Thu, 7 May 2009 23:14:47 +0200

 On Thu, May 07, 2009 at 10:11:07PM +0200, ext Felipe Contreras wrote:
  -static struct resource omap3_iommu_res[] = {
  -   { /* Camera ISP MMU */
  -   .start  = OMAP3_MMU1_BASE,
  -   .end= OMAP3_MMU1_BASE + MMU_REG_SIZE - 1,
  -   .flags  = IORESOURCE_MEM,
  -   },
  -   {
  -   .start  = OMAP3_MMU1_IRQ,
  -   .flags  = IORESOURCE_IRQ,
  -   },
  -   { /* IVA2.2 MMU */
  -   .start  = OMAP3_MMU2_BASE,
  -   .end= OMAP3_MMU2_BASE + MMU_REG_SIZE - 1,
  -   .flags  = IORESOURCE_MEM,
  -   },
  -   {
  -   .start  = OMAP3_MMU2_IRQ,
  -   .flags  = IORESOURCE_IRQ,
  -   },
 
 i find this one much more readable :-s
 
  +struct iommu_device {
  +   resource_size_t base;
  +   resource_size_t irq;
  +   struct iommu_platform_data pdata;
 
 generally, platform_data is a void *. Don't know if it matters here.
 
  +   struct resource res[2];
   };
  -#define NR_IOMMU_RES (ARRAY_SIZE(omap3_iommu_res) / 2)
   
  -static const struct iommu_platform_data omap3_iommu_pdata[] __initconst = {
  +static struct iommu_device devices[] = {
  {
  -   .name = isp,
  -   .nr_tlb_entries = 8,
  -   .clk_name = cam_ick,
  +   .base = 0x480bd400,
  +   .irq = 24,
  +   .pdata = {
  +   .name = isp,
  +   .nr_tlb_entries = 8,
  +   .clk_name = cam_ick,
 
 still passing clk names ? what about clkdev ?

Useful comment, I'll update mine;) thanks
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html