[RFC PATCHv4 0/7] HSI framework and drivers

2010-12-14 Thread Carlos Chinea
Hi !

Here you have the fourth round of the HSI framework patches.

The patch series introduces the HSI framework, an SSI driver
for OMAP and a generic character device for HSI/SSI devices.

SSI, which is a legacy version of HSI, is used to connect the application
engine with the cellular modem on the Nokia N900.

In this round we have added/fixed:

- Address some comments from Tony Lindgren and Peter Henn.
- Add module support to the HSI framework.
- Fix sparse warnings in OMAP SSI driver.
- Fix module license.
- Remove spurious udev events generated by the HSI framework.
- Avoid removal of a controller claimed by a client.
- Fix hsi_char client device removal.

TODO:

- Move OMAP SSI to use omap hwmod

I would very glad to continue getting feedback about this proposal.

This patch series is based on 2.6.37-rc1.

Version 3 of the patch set: https://lkml.org/lkml/2010/10/11/60

Note: checkpatch reports a false positive on patch 1/7.

Andras Domokos (3):
  HSI: hsi_char: Add HSI char device driver
  HSI: hsi_char: Add HSI char device kernel configuration
  HSI: hsi_char: Update ioctl-number.txt

Carlos Chinea (4):
  HSI: hsi: Introducing HSI framework
  HSI: omap_ssi: Introducing OMAP SSI driver
  HSI: omap_ssi: Add OMAP SSI to the kernel configuration
  HSI: Add HSI API documentation

 Documentation/DocBook/device-drivers.tmpl |   17 +
 Documentation/ioctl/ioctl-number.txt  |1 +
 arch/arm/mach-omap2/Makefile  |2 +
 arch/arm/mach-omap2/ssi.c |  134 +++
 arch/arm/plat-omap/include/plat/ssi.h |  204 
 drivers/Kconfig   |2 +
 drivers/Makefile  |1 +
 drivers/hsi/Kconfig   |   20 +
 drivers/hsi/Makefile  |6 +
 drivers/hsi/clients/Kconfig   |   13 +
 drivers/hsi/clients/Makefile  |5 +
 drivers/hsi/clients/hsi_char.c| 1094 +
 drivers/hsi/controllers/Kconfig   |   23 +
 drivers/hsi/controllers/Makefile  |5 +
 drivers/hsi/controllers/omap_ssi.c| 1853 +
 drivers/hsi/hsi.c |  496 
 drivers/hsi/hsi_boardinfo.c   |   64 +
 drivers/hsi/hsi_core.h|   37 +
 include/linux/Kbuild  |1 +
 include/linux/hsi/Kbuild  |1 +
 include/linux/hsi/hsi.h   |  389 ++
 include/linux/hsi/hsi_char.h  |   65 +
 22 files changed, 4433 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-omap2/ssi.c
 create mode 100644 arch/arm/plat-omap/include/plat/ssi.h
 create mode 100644 drivers/hsi/Kconfig
 create mode 100644 drivers/hsi/Makefile
 create mode 100644 drivers/hsi/clients/Kconfig
 create mode 100644 drivers/hsi/clients/Makefile
 create mode 100644 drivers/hsi/clients/hsi_char.c
 create mode 100644 drivers/hsi/controllers/Kconfig
 create mode 100644 drivers/hsi/controllers/Makefile
 create mode 100644 drivers/hsi/controllers/omap_ssi.c
 create mode 100644 drivers/hsi/hsi.c
 create mode 100644 drivers/hsi/hsi_boardinfo.c
 create mode 100644 drivers/hsi/hsi_core.h
 create mode 100644 include/linux/hsi/Kbuild
 create mode 100644 include/linux/hsi/hsi.h
 create mode 100644 include/linux/hsi/hsi_char.h

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC PATCHv4 0/7] HSI framework and drivers

2011-03-21 Thread Linus Walleij
2010/12/14 Carlos Chinea :

> Here you have the fourth round of the HSI framework patches.

I'd like to notify that this out-of-tree framework is also in use for
the ST-Ericsson
Ux500s, and we've had great success with it. You can add my:

Acked-by: Linus Walleij 

Possibly some ST-Ericsson people can add Tested-by tags as well.

We will integrate Ux500 support whenever it's suitable, either after the merge
or as add-on patches for Carlos patch series. (If Carlos would like to keep
them in his series.)

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC PATCHv4 0/7] HSI framework and drivers

2011-03-22 Thread Carlos Chinea
Hi,

On Mon, 2011-03-21 at 09:16 +0100, ext Linus Walleij wrote:
> 2010/12/14 Carlos Chinea :
> 
> > Here you have the fourth round of the HSI framework patches.
> 
> I'd like to notify that this out-of-tree framework is also in use for
> the ST-Ericsson
> Ux500s, and we've had great success with it. You can add my:
> 
> Acked-by: Linus Walleij 
> 

Thanks I will add the Ack to the next round of patches.

We are currently working on the hsi_char module. Apart from addressing
the comments from Alan,  we are planning to drop also the non-blocking
support from it. The current version is not fully honoring the
non-blocking behavior.

> Possibly some ST-Ericsson people can add Tested-by tags as well.
> 
> We will integrate Ux500 support whenever it's suitable, either after the merge
> or as add-on patches for Carlos patch series. (If Carlos would like to keep
> them in his series.)
> 

Either way is fine, for me. Could you send the patches for review ?

Br,
Carlos
-- 
Carlos Chinea 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC PATCHv4 0/7] HSI framework and drivers

2011-05-12 Thread Govindraj
On Tue, Mar 22, 2011 at 3:20 PM, Carlos Chinea  wrote:
> Hi,
>
> On Mon, 2011-03-21 at 09:16 +0100, ext Linus Walleij wrote:
>> 2010/12/14 Carlos Chinea :
>>
>> > Here you have the fourth round of the HSI framework patches.
>>
>> I'd like to notify that this out-of-tree framework is also in use for
>> the ST-Ericsson
>> Ux500s, and we've had great success with it. You can add my:
>>
>> Acked-by: Linus Walleij 
>>
>

Hi Carlos,

Will you posting a next version of HSI framework.

I am planning to adapt omap-hsi driver to this framework.

--
Thanks,
Govindraj.R


> Thanks I will add the Ack to the next round of patches.
>
> We are currently working on the hsi_char module. Apart from addressing
> the comments from Alan,  we are planning to drop also the non-blocking
> support from it. The current version is not fully honoring the
> non-blocking behavior.
>
>> Possibly some ST-Ericsson people can add Tested-by tags as well.
>>
>> We will integrate Ux500 support whenever it's suitable, either after the 
>> merge
>> or as add-on patches for Carlos patch series. (If Carlos would like to keep
>> them in his series.)
>>
>
> Either way is fine, for me. Could you send the patches for review ?
>
> Br,
> Carlos
> --
> Carlos Chinea 
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC PATCHv4 0/7] HSI framework and drivers

2011-05-16 Thread Linus Walleij
On Thu, May 12, 2011 at 2:17 PM, Govindraj  wrote:
> On Tue, Mar 22, 2011 at 3:20 PM, Carlos Chinea  
> wrote:
>> Hi,
>>
>> On Mon, 2011-03-21 at 09:16 +0100, ext Linus Walleij wrote:
>>> 2010/12/14 Carlos Chinea :
>>>
>>> > Here you have the fourth round of the HSI framework patches.
>>>
>>> I'd like to notify that this out-of-tree framework is also in use for
>>> the ST-Ericsson
>>> Ux500s, and we've had great success with it. You can add my:
>>>
>>> Acked-by: Linus Walleij 
>>>
>>
>
> Hi Carlos,
>
> Will you posting a next version of HSI framework.
>
> I am planning to adapt omap-hsi driver to this framework.

I was sort of asking the same thing.

I expected this to be queued up for 2.6.40 so we don't proliferate
out-of-tree drivers :-(

If Nokia will not pursue this patch set then tell me and Govindraj
and we can surely take it over.

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC PATCHv4 0/7] HSI framework and drivers

2011-05-17 Thread Carlos Chinea
On Mon, 2011-05-16 at 14:04 +0200, ext Linus Walleij wrote:
> On Thu, May 12, 2011 at 2:17 PM, Govindraj  wrote:
> > On Tue, Mar 22, 2011 at 3:20 PM, Carlos Chinea  
> > wrote:
> >> Hi,
> >>
> >> On Mon, 2011-03-21 at 09:16 +0100, ext Linus Walleij wrote:
> >>> 2010/12/14 Carlos Chinea :
> >>>
> >>> > Here you have the fourth round of the HSI framework patches.
> >>>
> >>> I'd like to notify that this out-of-tree framework is also in use for
> >>> the ST-Ericsson
> >>> Ux500s, and we've had great success with it. You can add my:
> >>>
> >>> Acked-by: Linus Walleij 
> >>>
> >>
> >
> > Hi Carlos,
> >
> > Will you posting a next version of HSI framework.
> >
> > I am planning to adapt omap-hsi driver to this framework.
> 
> I was sort of asking the same thing.

> I expected this to be queued up for 2.6.40 so we don't proliferate
> out-of-tree drivers :-(
> 
> If Nokia will not pursue this patch set then tell me and Govindraj
> and we can surely take it over.
> 

We are still committed to these patches. We are aiming to release a new
version in 3 weeks max, sooner if we can.

I am very sorry for the delay and I agree that starting to have several
out-of-tree drivers is not acceptable. I'll try my best to fix this
asap.

Br,
-- 
Carlos Chinea 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC PATCHv4 0/7] HSI framework and drivers

2011-06-07 Thread Sebastian Reichel
On Tue, May 17, 2011 at 11:39:13AM +0300, Carlos Chinea wrote:
> We are still committed to these patches. We are aiming to release a new
> version in 3 weeks max, sooner if we can.
> 
> I am very sorry for the delay and I agree that starting to have several
> out-of-tree drivers is not acceptable. I'll try my best to fix this
> asap.

Do you also plan to add the platform code for rx51 to the mainline
kernel?

P.S.: 3 weeks are over today :)

-- Sebastian


signature.asc
Description: Digital signature


Re: [RFC PATCHv4 0/7] HSI framework and drivers

2011-06-08 Thread Carlos Chinea
Hi,

On Tue, 2011-06-07 at 17:09 +0200, ext Sebastian Reichel wrote:
> On Tue, May 17, 2011 at 11:39:13AM +0300, Carlos Chinea wrote:
> > We are still committed to these patches. We are aiming to release a new
> > version in 3 weeks max, sooner if we can.
> > 
> > I am very sorry for the delay and I agree that starting to have several
> > out-of-tree drivers is not acceptable. I'll try my best to fix this
> > asap.
> 
> Do you also plan to add the platform code for rx51 to the mainline
> kernel?

Not yet in this patch set. If the HSI framework makes it into the
kernel, then I will try to push a couple of new HSI clients needed for
rx51 and the platform related code.

> 
> P.S.: 3 weeks are over today :)
> 

Yep, we are almost there with the patches :P A small problem in a last
minute test is keeping us from releasing the patches already.

Br,
-- 
Carlos Chinea 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html