Re: [alsa-devel] [PATCH 1/5 v2] ASoC Add TLV320AIC23 codec driver

2008-10-03 Thread Liam Girdwood 
On Fri, 2008-10-03 at 11:18 +0300, Tony Lindgren wrote:
 Hi,
 
 * Arun KS [EMAIL PROTECTED] [081002 12:18]:
  ASoC codec driver for TLV320AIC23 device
 
 One comment below based on a quick browse.
 
 snip
 
  +static void tlv320aic23_shutdown(struct snd_pcm_substream *substream)
  +{
  +   struct snd_soc_pcm_runtime *rtd = substream-private_data;
  +   struct snd_soc_device *socdev = rtd-socdev;
  +   struct snd_soc_codec *codec = socdev-codec;
  +
  +   /* deactivate */
  +   if (!codec-active) {
  +   udelay(50);
  +   tlv320aic23_write(codec, TLV320AIC23_ACTIVE, 0x0);
  +   }
  +}
  +
 
 What's the purpose of the udelay() here? Looks like if needed it should
 be after the twl32aic23_write().. Otherwise the problem is probably
 somewhere else.
 

Iirc this was found to reduce pops and clicks on shutdown on another
very similar codec in this family.

Liam

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [alsa-devel] [PATCH 1/5 v2] ASoC Add TLV320AIC23 codec driver

2008-10-02 Thread Mark Brown 
On Thu, Oct 02, 2008 at 02:55:27PM +0530, Arun KS wrote:
 ASoC codec driver for TLV320AIC23 device

 Signed-off-by: Arun KS [EMAIL PROTECTED]

This looks good and it's probably as well to merge it now since the one
issue below is mostly cosmetic so if nothing else it'll be easier to
review incrementally so:

Acked-by: Mark Brown [EMAIL PROTECTED]

 +static const char *deemph_text[] = {None, 32Khz, 44.1Khz, 48Khz};
 +static const char *sidetone_text[] = {-6db, -9db, -12db, -18db, 
 0db};

...

 +static const struct soc_enum tlv320aic23_sidetone =
 + SOC_ENUM_SINGLE(TLV320AIC23_ANLG, 6, 5, sidetone_text);

...

 + SOC_ENUM(Sidetone Gain, tlv320aic23_sidetone),

As I said on the last submission this should really be a SOC_SINGLE_TLV
called Sidetone Volume rather than an enumeration - it's a dB scale
controlling gain rather than an enumeration.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html