Re: [alsa-devel] [PATCH 2/4 v2] OMAP: Configure audio_mclk for twl4030-codec MFD

2009-11-09 Thread Tony Lindgren
Hi,

* Peter Ujfalusi  [091108 23:46]:
> Hello Tony,
> 
> On Wednesday 04 November 2009 09:58:18 Ujfalusi Peter (Nokia-D/Tampere) wrote:
> > audio_mclk value is going to be handled by the
> > twl4030-codec MFD driver, configure the correct
> > value for boards, which is using the twl4030 audio.
> > 
> > Signed-off-by: Peter Ujfalusi 
> > ---
> >  arch/arm/mach-omap2/board-3430sdp.c  |1 +
> >  arch/arm/mach-omap2/board-omap3beagle.c  |1 +
> >  arch/arm/mach-omap2/board-omap3evm.c |1 +
> >  arch/arm/mach-omap2/board-omap3pandora.c |1 +
> >  arch/arm/mach-omap2/board-overo.c|1 +
> >  arch/arm/mach-omap2/board-zoom2.c|1 +
> >  6 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/board-3430sdp.c
> >  b/arch/arm/mach-omap2/board-3430sdp.c index 4f91f7a..9afd957 100644
> > --- a/arch/arm/mach-omap2/board-3430sdp.c
> > +++ b/arch/arm/mach-omap2/board-3430sdp.c
> > @@ -415,6 +415,7 @@ static struct twl4030_codec_audio_data sdp3430_audio =
> >  { };
> > 
> >  static struct twl4030_codec_data sdp3430_codec = {
> > +   .audio_mclk = 2600,
> > .audio = &sdp3430_audio,
> >  };
> > 


 
> Can you take a look at this patch?
> The rest of the series has already got Ack from Samuel and Mark, and only 
> your 
> verdict for the OMAP part is missing.

Looks good to me. It seems like it's best to queue this along
with the related ASoC patches.

Acked-by: Tony Lindgren 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [alsa-devel] [PATCH 2/4 v2] OMAP: Configure audio_mclk for twl4030-codec MFD

2009-11-08 Thread Peter Ujfalusi
Hello Tony,

On Wednesday 04 November 2009 09:58:18 Ujfalusi Peter (Nokia-D/Tampere) wrote:
> audio_mclk value is going to be handled by the
> twl4030-codec MFD driver, configure the correct
> value for boards, which is using the twl4030 audio.
> 
> Signed-off-by: Peter Ujfalusi 
> ---
>  arch/arm/mach-omap2/board-3430sdp.c  |1 +
>  arch/arm/mach-omap2/board-omap3beagle.c  |1 +
>  arch/arm/mach-omap2/board-omap3evm.c |1 +
>  arch/arm/mach-omap2/board-omap3pandora.c |1 +
>  arch/arm/mach-omap2/board-overo.c|1 +
>  arch/arm/mach-omap2/board-zoom2.c|1 +
>  6 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-3430sdp.c
>  b/arch/arm/mach-omap2/board-3430sdp.c index 4f91f7a..9afd957 100644
> --- a/arch/arm/mach-omap2/board-3430sdp.c
> +++ b/arch/arm/mach-omap2/board-3430sdp.c
> @@ -415,6 +415,7 @@ static struct twl4030_codec_audio_data sdp3430_audio =
>  { };
> 
>  static struct twl4030_codec_data sdp3430_codec = {
> + .audio_mclk = 2600,
>   .audio = &sdp3430_audio,
>  };
> 
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c
>  b/arch/arm/mach-omap2/board-omap3beagle.c index 2161d85..8f0c106 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -259,6 +259,7 @@ static struct twl4030_codec_audio_data
>  beagle_audio_data = { };
> 
>  static struct twl4030_codec_data beagle_codec_data = {
> + .audio_mclk = 2600,
>   .audio = &beagle_audio_data,
>  };
> 
> diff --git a/arch/arm/mach-omap2/board-omap3evm.c
>  b/arch/arm/mach-omap2/board-omap3evm.c index d9a6103..5bb30cb 100644
> --- a/arch/arm/mach-omap2/board-omap3evm.c
> +++ b/arch/arm/mach-omap2/board-omap3evm.c
> @@ -199,6 +199,7 @@ static struct twl4030_codec_audio_data
>  omap3evm_audio_data = { };
> 
>  static struct twl4030_codec_data omap3evm_codec_data = {
> + .audio_mclk = 2600,
>   .audio = &omap3evm_audio_data,
>  };
> 
> diff --git a/arch/arm/mach-omap2/board-omap3pandora.c
>  b/arch/arm/mach-omap2/board-omap3pandora.c index 5036b56..77790ee 100644
> --- a/arch/arm/mach-omap2/board-omap3pandora.c
> +++ b/arch/arm/mach-omap2/board-omap3pandora.c
> @@ -286,6 +286,7 @@ static struct twl4030_codec_audio_data
>  omap3pandora_audio_data = { };
> 
>  static struct twl4030_codec_data omap3pandora_codec_data = {
> + .audio_mclk = 2600,
>   .audio = &omap3pandora_audio_data,
>  };
> 
> diff --git a/arch/arm/mach-omap2/board-overo.c
>  b/arch/arm/mach-omap2/board-overo.c index dc55008..e1fb504 100644
> --- a/arch/arm/mach-omap2/board-overo.c
> +++ b/arch/arm/mach-omap2/board-overo.c
> @@ -334,6 +334,7 @@ static struct twl4030_codec_audio_data overo_audio_data
>  = { };
> 
>  static struct twl4030_codec_data overo_codec_data = {
> + .audio_mclk = 2600,
>   .audio = &overo_audio_data,
>  };
> 
> diff --git a/arch/arm/mach-omap2/board-zoom2.c
>  b/arch/arm/mach-omap2/board-zoom2.c index f1b4e7c..de3a38d 100644
> --- a/arch/arm/mach-omap2/board-zoom2.c
> +++ b/arch/arm/mach-omap2/board-zoom2.c
> @@ -234,6 +234,7 @@ static struct twl4030_codec_audio_data zoom2_audio_data
>  = { };
> 
>  static struct twl4030_codec_data zoom2_codec_data = {
> + .audio_mclk = 2600,
>   .audio = &zoom2_audio_data,
>  };
> 
> --
> 1.6.5.2

Can you take a look at this patch?
The rest of the series has already got Ack from Samuel and Mark, and only your 
verdict for the OMAP part is missing.

Thank you, 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html