Re: [rtc-linux] [PATCH] RTC: twl6030: correct usage of static register while reading time

2012-04-07 Thread Menon, Nishanth
On Fri, Apr 6, 2012 at 14:19, Andrew Morton a...@linux-foundation.org wrote:

 I rewrote your acked-by to Signed-off-by, because you were on the
 delivery path of the patch. Documentation/SubmittingPatches has details.

 Is this OK?
sure, thanks.

Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [rtc-linux] [PATCH] RTC: twl6030: correct usage of static register while reading time

2012-04-06 Thread Andrew Morton
On Wed, 28 Mar 2012 16:34:01 -0500
Nishanth Menon n...@ti.com wrote:

 From: Konstantin Shlyakhovoy x0155...@ti.com
 
 RTC stores time and date in several registers. Due to the fact that
 these registers can't be read instantaneously, there is a chance
 that reading from counting registers gives an error of one minute,
 one hour, one day, etc.
 
 To address this issue, the RTC has hardware support to copy the
 RTC counting registers to static shadowed registers.
 The current implementation does not use this feature, and in a
 stress test,  we can reproduce this error at a rate of around
 two times per 30 readings.
 
 Fix the implementation to ensure that the right snapshot of time
 is captured.

hey, nice changelog!

Please cc me on rtc patches - I tend to be a bit slow reading the
rtc-linux list.

 Cc: Alessandro Zummo a.zu...@towertech.it
 Cc: Benoit Cousson b-cous...@ti.com
 Cc: linux-omap linux-omap@vger.kernel.org
 Acked-by: Mykola Oleksiienko x0174...@ti.com
 Acked-by: Oleksandr Dmytryshyn oleksandr.dmytrys...@ti.com
 Acked-by: Graeme Gregory g...@slimlogic.co.uk
 Acked-by: Nishanth Menon n...@ti.com
 Signed-off-by: Konstantin Shlyakhovoy x0155...@ti.com

I rewrote your acked-by to Signed-off-by, because you were on the
delivery path of the patch. Documentation/SubmittingPatches has details.

Is this OK?

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html