Re: MUSB regression in 2.6.31-rc6
On Mon, 17 Aug 2009 17:27:09 -0400 (GMT-04:00) ewitcher wrote: > Hello, > > The below referenced patch was helpful to me in resolving the > > <3>twl4030_usb twl4030_usb: ldo init failed > > error. > > Examining the minicom.cap attachment, I can see that twl4030_usb is > initialized before regulator. If you move the twl4030_usb initialization to > after regulator, you should be ok. > > [PATCH] USB:otg:twl4030-usb.c: mark .init as subsys_initcall_sync > http://marc.info/?l=linux-usb&m=124913041802639&w=2 > Thanks! That patch and Felipe's patch to board-omap3beagle.c made it booting. http://marc.info/?l=linux-arm-kernel&m=125007992121335&w=2 However, I'm not able to get a bit going but at least now one is able to debug it. There is only this "unexpected notification 03!" seen on pc side when the cable is plugged in. Beagle: g_ether gadget: high speed config #1: CDC Ethernet (ECM) PC: usb0: register 'cdc_ether' at usb-:00:1d.7-1, CDC Ethernet Device, a6:9c:9f:d0:8a:65 usb0: CDC: unexpected notification 03! -- Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: MUSB regression in 2.6.31-rc6
Hello, The below referenced patch was helpful to me in resolving the <3>twl4030_usb twl4030_usb: ldo init failed error. Examining the minicom.cap attachment, I can see that twl4030_usb is initialized before regulator. If you move the twl4030_usb initialization to after regulator, you should be ok. [PATCH] USB:otg:twl4030-usb.c: mark .init as subsys_initcall_sync http://marc.info/?l=linux-usb&m=124913041802639&w=2 I also included the aforementioned patch at the end of Re: [PATCH 10/10] OMAP3: update OMAP3 Beagle defconfig, v2 http://marc.info/?l=linux-omap&m=125038741913297&w=2 Regards, Eric -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: MUSB regression in 2.6.31-rc6
Jarkko Nikula writes: > By some reason CONFIG_OMAP_LL_DEBUG_UART3=y and CONFIG_DEBUG_LL=y > don't work in mainline so hard to trace what is make an oops. You need to apply this patch manually: http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commitdiff;h=73e5b252eb179f601f2da2538ac3b70c21b2c6c2 -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: MUSB regression in 2.6.31-rc6
On Sun, Aug 16, 2009 at 08:43:45PM +0300, Jarkko Nikula wrote: > On Sun, 16 Aug 2009 20:10:18 +0300 > Felipe Balbi wrote: > > > how about checking whether twl4030_usb is probing fine ? > > > Oh yes, looks like not. I didn't notice this before and didn't post the > full log. Bad me, now included. See > > <3>twl4030_usb twl4030_usb: ldo init failed It looks like we're also missing ldo initialization on current linux-omap. I'll cook a patch tomorrow for that, if you could help me with testing, then I could send the full version to Greg for integration. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: MUSB regression in 2.6.31-rc6
On Sun, 16 Aug 2009 20:10:18 +0300 Felipe Balbi wrote: > how about checking whether twl4030_usb is probing fine ? > Oh yes, looks like not. I didn't notice this before and didn't post the full log. Bad me, now included. See <3>twl4030_usb twl4030_usb: ldo init failed -- Jarkko minicom.cap Description: application/cap
Re: MUSB regression in 2.6.31-rc6
hi, On Sun, Aug 16, 2009 at 07:49:53PM +0300, Jarkko Nikula wrote: > On Sun, 16 Aug 2009 16:13:38 +0300 > Felipe Balbi wrote: > > > > > It didn't help. Only way to get the mainline kernel booting is to revert > > > > e8e2ff462dd92693f29eb848f42d3eb720390d59 and activate both > > > > CONFIG_TWL4030_USB and CONFIG_NOP_USB_XCEIV. > > > > > > > By some reason CONFIG_OMAP_LL_DEBUG_UART3=y and CONFIG_DEBUG_LL=y > > > > don't work in mainline so hard to trace what is make an oops. > > > > > > > I attached my config if you want look at it. > > > > > > You config has both CONFIG_TWL4030_USB and CONFIG_NOP_USB_XCEIV enabled. > > > Can you try Felipe's patch but enable only CONFIG_TWL4030_USB. > > > > > > http://marc.info/?l=linux-arm-kernel&m=125007992121335&w=2 > > > > Oh yeah, good point. > > > As I told before (lines 4-6 in this mail), Felipe's patch to the > board-omap3beagle.c didn't help. Only way to make 2.6.31-rc6 booting > was to enable both of those config options + revert. > > > @Jarkko With the patch I sent you on top of mainline, did you make > > omap3_beagle_defconfig again ? > > > Yep. Actually I re-tested it now with make distclean first. Meaning > patch from this mail: > > http://marc.info/?l=linux-usb&m=125041334606967&w=2 > > No sign of life. > > Now reverting the e8e2ff462dd92693f29eb848f42d3eb720390d59 > > No sign of life. > > Adding CONFIG_NOP_USB_XCEIV=y > > Bingo! > > Getting e8e2ff462dd92693f29eb848f42d3eb720390d59 back > > Again, no sign of life. how about checking whether twl4030_usb is probing fine ? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: MUSB regression in 2.6.31-rc6
On Sun, 16 Aug 2009 16:13:38 +0300 Felipe Balbi wrote: > > > It didn't help. Only way to get the mainline kernel booting is to revert > > > e8e2ff462dd92693f29eb848f42d3eb720390d59 and activate both > > > CONFIG_TWL4030_USB and CONFIG_NOP_USB_XCEIV. > > > > > By some reason CONFIG_OMAP_LL_DEBUG_UART3=y and CONFIG_DEBUG_LL=y > > > don't work in mainline so hard to trace what is make an oops. > > > > > I attached my config if you want look at it. > > > > You config has both CONFIG_TWL4030_USB and CONFIG_NOP_USB_XCEIV enabled. > > Can you try Felipe's patch but enable only CONFIG_TWL4030_USB. > > > > http://marc.info/?l=linux-arm-kernel&m=125007992121335&w=2 > > Oh yeah, good point. > As I told before (lines 4-6 in this mail), Felipe's patch to the board-omap3beagle.c didn't help. Only way to make 2.6.31-rc6 booting was to enable both of those config options + revert. > @Jarkko With the patch I sent you on top of mainline, did you make > omap3_beagle_defconfig again ? > Yep. Actually I re-tested it now with make distclean first. Meaning patch from this mail: http://marc.info/?l=linux-usb&m=125041334606967&w=2 No sign of life. Now reverting the e8e2ff462dd92693f29eb848f42d3eb720390d59 No sign of life. Adding CONFIG_NOP_USB_XCEIV=y Bingo! Getting e8e2ff462dd92693f29eb848f42d3eb720390d59 back Again, no sign of life. -- Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: MUSB regression in 2.6.31-rc6
Hi, On Sun, Aug 16, 2009 at 06:37:40PM +0530, Gupta, Ajay Kumar wrote: > > > > CONFIG_TWL4030_USB=y > > > CONFIG_NOP_USB_XCEIV=y > > > > > > But anyway, I don't get Beagle booting with 2.6.31-rc6 if I disable any > > > of them and IRCC another oops will follow if both are disabled. > > > > There's a patch from me adding back the twl4030_usb pdata to beagle > > board-file and another one from Paul which changed the defconfig. > > > > You mean this one? > > > http://marc.info/?l=linux-arm-kernel&m=125007992121335&w=2 > > > It didn't help. Only way to get the mainline kernel booting is to revert > > e8e2ff462dd92693f29eb848f42d3eb720390d59 and activate both > > CONFIG_TWL4030_USB and CONFIG_NOP_USB_XCEIV. > > > By some reason CONFIG_OMAP_LL_DEBUG_UART3=y and CONFIG_DEBUG_LL=y > > don't work in mainline so hard to trace what is make an oops. > > > I attached my config if you want look at it. > > You config has both CONFIG_TWL4030_USB and CONFIG_NOP_USB_XCEIV enabled. > Can you try Felipe's patch but enable only CONFIG_TWL4030_USB. > > http://marc.info/?l=linux-arm-kernel&m=125007992121335&w=2 Oh yeah, good point. @Jarkko With the patch I sent you on top of mainline, did you make omap3_beagle_defconfig again ? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: MUSB regression in 2.6.31-rc6
> > CONFIG_TWL4030_USB=y > > CONFIG_NOP_USB_XCEIV=y > > > > But anyway, I don't get Beagle booting with 2.6.31-rc6 if I disable any > > of them and IRCC another oops will follow if both are disabled. > > There's a patch from me adding back the twl4030_usb pdata to beagle > board-file and another one from Paul which changed the defconfig. > > You mean this one? > http://marc.info/?l=linux-arm-kernel&m=125007992121335&w=2 > It didn't help. Only way to get the mainline kernel booting is to revert > e8e2ff462dd92693f29eb848f42d3eb720390d59 and activate both > CONFIG_TWL4030_USB and CONFIG_NOP_USB_XCEIV. > By some reason CONFIG_OMAP_LL_DEBUG_UART3=y and CONFIG_DEBUG_LL=y > don't work in mainline so hard to trace what is make an oops. > I attached my config if you want look at it. You config has both CONFIG_TWL4030_USB and CONFIG_NOP_USB_XCEIV enabled. Can you try Felipe's patch but enable only CONFIG_TWL4030_USB. http://marc.info/?l=linux-arm-kernel&m=125007992121335&w=2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: MUSB regression in 2.6.31-rc6
Hi,
On Sun, Aug 16, 2009 at 11:47:31AM +0300, Jarkko Nikula wrote:
> On Sun, 16 Aug 2009 11:25:14 +0300
> Felipe Balbi wrote:
>
> > NOP should not be necessary, beagle uses twl4030-usb as its transceiver,
> > unlike evm, which uses isp1504, if I'm not wrong.
> >
> > Could you try the following patch ?
> >
> No help but thanks to Koen's hint, I was able to capture the oops. I
> compiled the kernel using your defconfig change and set the DEBUG_LL.
if you:
$ arm-linux-gdb vmlinux
(gdb) l *(musb_platform_suspend + 0x34)
you'll see that ends up in otg_set_suspend()
basically when it checks:
if (otg->set_suspend)
so the problem is still related to the missing otg transceiver
could you printk twl4030_usb_probe() to see what's going on ?
check whether otg_set_transceiver() is being successfully called. The
following will give some hint (maybe)
= cut here ==
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 3487520..6733da9 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -213,6 +213,7 @@ int __init musb_platform_init(struct musb *musb)
* which needs a driver, drivers aren't always needed.
*/
musb->xceiv = otg_get_transceiver();
+ printk(KERN_INFO "%s: xceiv %p\n", __func__, musb->xceiv);
if (!musb->xceiv) {
pr_err("HS USB OTG: no transceiver configured\n");
return -ENODEV;
diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg/twl4030-usb.c
index 9e3e7a5..6d994cf 100644
--- a/drivers/usb/otg/twl4030-usb.c
+++ b/drivers/usb/otg/twl4030-usb.c
@@ -687,6 +687,7 @@ static int __devinit twl4030_usb_probe(struct
platform_device *pdev)
kfree(twl);
return err;
}
+ print(KERN_INFO "%s: xceiv %p\n", __func__, &twl->otg);
otg_set_transceiver(&twl->otg);
platform_set_drvdata(pdev, twl);
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: MUSB regression in 2.6.31-rc6
On Sun, Aug 16, 2009 at 10:44:15AM +0300, Jarkko Nikula wrote: > On Sat, 15 Aug 2009 20:40:00 +0300 > Felipe Balbi wrote: > > > > CONFIG_TWL4030_USB=y > > > CONFIG_NOP_USB_XCEIV=y > > > > > > But anyway, I don't get Beagle booting with 2.6.31-rc6 if I disable any > > > of them and IRCC another oops will follow if both are disabled. > > > > There's a patch from me adding back the twl4030_usb pdata to beagle > > board-file and another one from Paul which changed the defconfig. > > > You mean this one? > > http://marc.info/?l=linux-arm-kernel&m=125007992121335&w=2 > > It didn't help. Only way to get the mainline kernel booting is to revert > e8e2ff462dd92693f29eb848f42d3eb720390d59 and activate both > CONFIG_TWL4030_USB and CONFIG_NOP_USB_XCEIV. NOP should not be necessary, beagle uses twl4030-usb as its transceiver, unlike evm, which uses isp1504, if I'm not wrong. Could you try the following patch ? === cut here == diff --git a/arch/arm/configs/omap3_beagle_defconfig b/arch/arm/configs/omap3_beagle_defconfig index 4c6fb7e..cec0df8 100644 --- a/arch/arm/configs/omap3_beagle_defconfig +++ b/arch/arm/configs/omap3_beagle_defconfig @@ -1,7 +1,7 @@ # # Automatically generated make config: don't edit -# Linux kernel version: 2.6.27-rc8 -# Wed Oct 1 17:14:22 2008 +# Linux kernel version: 2.6.31-rc6 +# Sun Aug 16 11:18:27 2009 # CONFIG_ARM=y CONFIG_SYS_SUPPORTS_APM_EMULATION=y @@ -9,7 +9,6 @@ CONFIG_GENERIC_GPIO=y CONFIG_GENERIC_TIME=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_MMU=y -# CONFIG_NO_IOPORT is not set CONFIG_GENERIC_HARDIRQS=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_HAVE_LATENCYTOP_SUPPORT=y @@ -18,15 +17,12 @@ CONFIG_TRACE_IRQFLAGS_SUPPORT=y CONFIG_HARDIRQS_SW_RESEND=y CONFIG_GENERIC_IRQ_PROBE=y CONFIG_RWSEM_GENERIC_SPINLOCK=y -# CONFIG_ARCH_HAS_ILOG2_U32 is not set -# CONFIG_ARCH_HAS_ILOG2_U64 is not set CONFIG_GENERIC_HWEIGHT=y CONFIG_GENERIC_CALIBRATE_DELAY=y -CONFIG_ARCH_SUPPORTS_AOUT=y -CONFIG_ZONE_DMA=y CONFIG_GENERIC_HARDIRQS_NO__DO_IRQ=y CONFIG_VECTORS_BASE=0x CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config" +CONFIG_CONSTRUCTORS=y # # General setup @@ -44,22 +40,35 @@ CONFIG_BSD_PROCESS_ACCT=y # CONFIG_BSD_PROCESS_ACCT_V3 is not set # CONFIG_TASKSTATS is not set # CONFIG_AUDIT is not set + +# +# RCU Subsystem +# +CONFIG_CLASSIC_RCU=y +# CONFIG_TREE_RCU is not set +# CONFIG_PREEMPT_RCU is not set +# CONFIG_TREE_RCU_TRACE is not set +# CONFIG_PREEMPT_RCU_TRACE is not set # CONFIG_IKCONFIG is not set CONFIG_LOG_BUF_SHIFT=14 -# CONFIG_CGROUPS is not set CONFIG_GROUP_SCHED=y CONFIG_FAIR_GROUP_SCHED=y # CONFIG_RT_GROUP_SCHED is not set CONFIG_USER_SCHED=y # CONFIG_CGROUP_SCHED is not set +# CONFIG_CGROUPS is not set CONFIG_SYSFS_DEPRECATED=y CONFIG_SYSFS_DEPRECATED_V2=y # CONFIG_RELAY is not set # CONFIG_NAMESPACES is not set CONFIG_BLK_DEV_INITRD=y CONFIG_INITRAMFS_SOURCE="" +CONFIG_RD_GZIP=y +# CONFIG_RD_BZIP2 is not set +# CONFIG_RD_LZMA is not set CONFIG_CC_OPTIMIZE_FOR_SIZE=y CONFIG_SYSCTL=y +CONFIG_ANON_INODES=y CONFIG_EMBEDDED=y CONFIG_UID16=y # CONFIG_SYSCTL_SYSCALL is not set @@ -70,16 +79,21 @@ CONFIG_HOTPLUG=y CONFIG_PRINTK=y CONFIG_BUG=y CONFIG_ELF_CORE=y -CONFIG_COMPAT_BRK=y CONFIG_BASE_FULL=y CONFIG_FUTEX=y -CONFIG_ANON_INODES=y CONFIG_EPOLL=y CONFIG_SIGNALFD=y CONFIG_TIMERFD=y CONFIG_EVENTFD=y CONFIG_SHMEM=y +CONFIG_AIO=y + +# +# Performance Counters +# CONFIG_VM_EVENT_COUNTERS=y +# CONFIG_STRIP_ASM_SYMS is not set +CONFIG_COMPAT_BRK=y CONFIG_SLAB=y # CONFIG_SLUB is not set # CONFIG_SLOB is not set @@ -87,19 +101,17 @@ CONFIG_SLAB=y # CONFIG_MARKERS is not set CONFIG_HAVE_OPROFILE=y # CONFIG_KPROBES is not set -# CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS is not set -# CONFIG_HAVE_IOREMAP_PROT is not set CONFIG_HAVE_KPROBES=y CONFIG_HAVE_KRETPROBES=y -# CONFIG_HAVE_ARCH_TRACEHOOK is not set -# CONFIG_HAVE_DMA_ATTRS is not set -# CONFIG_USE_GENERIC_SMP_HELPERS is not set CONFIG_HAVE_CLK=y -CONFIG_PROC_PAGE_MONITOR=y + +# +# GCOV-based kernel profiling +# +# CONFIG_SLOW_WORK is not set CONFIG_HAVE_GENERIC_DMA_COHERENT=y CONFIG_SLABINFO=y CONFIG_RT_MUTEXES=y -# CONFIG_TINY_SHMEM is not set CONFIG_BASE_SMALL=0 CONFIG_MODULES=y # CONFIG_MODULE_FORCE_LOAD is not set @@ -107,11 +119,8 @@ CONFIG_MODULE_UNLOAD=y # CONFIG_MODULE_FORCE_UNLOAD is not set CONFIG_MODVERSIONS=y CONFIG_MODULE_SRCVERSION_ALL=y -CONFIG_KMOD=y CONFIG_BLOCK=y -# CONFIG_LBD is not set -# CONFIG_BLK_DEV_IO_TRACE is not set -# CONFIG_LSF is not set +CONFIG_LBDAF=y # CONFIG_BLK_DEV_BSG is not set # CONFIG_BLK_DEV_INTEGRITY is not set @@ -127,7 +136,7 @@ CONFIG_DEFAULT_AS=y # CONFIG_DEFAULT_CFQ is not set # CONFIG_DEFAULT_NOOP is not set CONFIG_DEFAULT_IOSCHED="anticipatory" -CONFIG_CLASSIC_RCU=y +CONFIG_FREEZER=y # # System Type @@ -137,14 +146,15 @@ CONFIG_CLASSIC_RCU=y # CONFIG_ARCH_REALVIEW is not set # CONFIG_ARCH_VERSATILE is not set # CONFIG_ARCH_AT91 is not
Re: MUSB regression in 2.6.31-rc6
On Sun, 16 Aug 2009 11:25:14 +0300 Felipe Balbi wrote: > NOP should not be necessary, beagle uses twl4030-usb as its transceiver, > unlike evm, which uses isp1504, if I'm not wrong. > > Could you try the following patch ? > No help but thanks to Koen's hint, I was able to capture the oops. I compiled the kernel using your defconfig change and set the DEBUG_LL. -- Jarkko minicom.cap Description: application/cap
Re: MUSB regression in 2.6.31-rc6
Op 16 aug 2009, om 09:44 heeft Jarkko Nikula het volgende geschreven: By some reason CONFIG_OMAP_LL_DEBUG_UART3=y and CONFIG_DEBUG_LL=y don't work in mainline so hard to trace what is make an oops. Try updating this patch to current mainline: --- a/kernel/printk.c +++ b/kernel/printk.c @@ -16,6 +16,8 @@ * 01Mar01 Andrew Morton */ +extern void printascii(const char *); + #include #include #include @@ -653,6 +655,8 @@ asmlinkage int vprintk(const char *fmt, va_list args) /* Emit the output into the temporary buffer */ printed_len = vscnprintf(printk_buf, sizeof(printk_buf), fmt, args); + printascii(printk_buf); + /* * Copy the output into log_buf. If the caller didn't provide * appropriate log level tags, we insert them here regards, Koen PGP.sig Description: Dit deel van het bericht is digitaal ondertekend
Re: MUSB regression in 2.6.31-rc6
On Sat, 15 Aug 2009 20:40:00 +0300 Felipe Balbi wrote: > > CONFIG_TWL4030_USB=y > > CONFIG_NOP_USB_XCEIV=y > > > > But anyway, I don't get Beagle booting with 2.6.31-rc6 if I disable any > > of them and IRCC another oops will follow if both are disabled. > > There's a patch from me adding back the twl4030_usb pdata to beagle > board-file and another one from Paul which changed the defconfig. > You mean this one? http://marc.info/?l=linux-arm-kernel&m=125007992121335&w=2 It didn't help. Only way to get the mainline kernel booting is to revert e8e2ff462dd92693f29eb848f42d3eb720390d59 and activate both CONFIG_TWL4030_USB and CONFIG_NOP_USB_XCEIV. By some reason CONFIG_OMAP_LL_DEBUG_UART3=y and CONFIG_DEBUG_LL=y don't work in mainline so hard to trace what is make an oops. I attached my config if you want look at it. -- Jarkko beagle_ml.config Description: Binary data
RE: MUSB regression in 2.6.31-rc6
> > > @@ -13,6 +13,7 @@ config USB_MUSB_HDRC > > > select NOP_USB_XCEIV if ARCH_DAVINCI > > > select TWL4030_USB if MACH_OMAP_3430SDP > > > select NOP_USB_XCEIV if MACH_OMAP3EVM > > > + select NOP_USB_XCEIV if MACH_OMAP3_BEAGLE > > > > Shouldn't we be selecting TWL4030_USB if MACH_OMAP3_BEAGLE. > > The beagleboard does use the PHY in the TWL4030, and not > > a transparent PHY. > > > Could be. I have no very much idea of these :-) Beagle has to use TWL4030_USB only and not NOP_USB_XCEIV. The NOP registration was removed from common file usb-musb.c to board specific file because different board uses different transceiver. > > I happened to have both of these below enabled and 2.6.31-rc5 was still > booting. > > CONFIG_TWL4030_USB=y > CONFIG_NOP_USB_XCEIV=y > > But anyway, I don't get Beagle booting with 2.6.31-rc6 if I disable any > of them and IRCC another oops will follow if both are disabled. For Beagle; only CONFIG_TWL4030_USB=y is required and should work with that alone. > There's a patch from me adding back the twl4030_usb pdata to beagle > board-file and another one from Paul which changed the defconfig. It seems this dependency might be the cause why CONFIG_TWL4030_USB=y alone didn't work as reported by Nikula. > It should be easy to find on the archives. Eduardo Valentin reported > that to me so I was asking him to test the stuff for me. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: MUSB regression in 2.6.31-rc6
On Sat, Aug 15, 2009 at 05:07:01PM +0200, ext Jarkko Nikula wrote: > On Sat, 15 Aug 2009 20:19:17 +0530 > "Gadiyar, Anand" wrote: > > > > diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig > > > index 803adcb..e27ed96 100644 > > > --- a/drivers/usb/musb/Kconfig > > > +++ b/drivers/usb/musb/Kconfig > > > @@ -13,6 +13,7 @@ config USB_MUSB_HDRC > > > select NOP_USB_XCEIV if ARCH_DAVINCI > > > select TWL4030_USB if MACH_OMAP_3430SDP > > > select NOP_USB_XCEIV if MACH_OMAP3EVM > > > + select NOP_USB_XCEIV if MACH_OMAP3_BEAGLE > > > > Shouldn't we be selecting TWL4030_USB if MACH_OMAP3_BEAGLE. > > The beagleboard does use the PHY in the TWL4030, and not > > a transparent PHY. > > > Could be. I have no very much idea of these :-) > > I happened to have both of these below enabled and 2.6.31-rc5 was still > booting. > > CONFIG_TWL4030_USB=y > CONFIG_NOP_USB_XCEIV=y > > But anyway, I don't get Beagle booting with 2.6.31-rc6 if I disable any > of them and IRCC another oops will follow if both are disabled. There's a patch from me adding back the twl4030_usb pdata to beagle board-file and another one from Paul which changed the defconfig. It should be easy to find on the archives. Eduardo Valentin reported that to me so I was asking him to test the stuff for me. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: MUSB regression in 2.6.31-rc6
On Sat, 15 Aug 2009 20:19:17 +0530 "Gadiyar, Anand" wrote: > > diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig > > index 803adcb..e27ed96 100644 > > --- a/drivers/usb/musb/Kconfig > > +++ b/drivers/usb/musb/Kconfig > > @@ -13,6 +13,7 @@ config USB_MUSB_HDRC > > select NOP_USB_XCEIV if ARCH_DAVINCI > > select TWL4030_USB if MACH_OMAP_3430SDP > > select NOP_USB_XCEIV if MACH_OMAP3EVM > > + select NOP_USB_XCEIV if MACH_OMAP3_BEAGLE > > Shouldn't we be selecting TWL4030_USB if MACH_OMAP3_BEAGLE. > The beagleboard does use the PHY in the TWL4030, and not > a transparent PHY. > Could be. I have no very much idea of these :-) I happened to have both of these below enabled and 2.6.31-rc5 was still booting. CONFIG_TWL4030_USB=y CONFIG_NOP_USB_XCEIV=y But anyway, I don't get Beagle booting with 2.6.31-rc6 if I disable any of them and IRCC another oops will follow if both are disabled. -- Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: MUSB regression in 2.6.31-rc6
> Hi > > BeagleBoard stopped booting at 2.6.31-rc6 and it turned out that this > commit broke it: > > commit e8e2ff462dd92693f29eb848f42d3eb720390d59 > Author: Gupta, Ajay Kumar > Date: Wed Jul 29 11:58:57 2009 +0530 > > USB: musb: fix the nop registration for OMAP3EVM > > While this is easy to fix for the Beagle with a patch below, I don't know > how many other OMAP boards there are which should be fixed as well. > Or would it be better to revert the patch itself for 2.6.31? > > > -- > Jarkko > > --- > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c > b/arch/arm/mach-omap2/board-omap3beagle.c > index 991ac9c..2ca0d44 100644 > --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > @@ -30,6 +30,7 @@ > > #include > #include > +#include > > #include > #include > @@ -406,6 +407,10 @@ static void __init omap3_beagle_init(void) > /* REVISIT leave DVI powered down until it's needed ... */ > gpio_direction_output(170, true); > > +#ifdef CONFIG_NOP_USB_XCEIV > + /* OMAP3EVM uses ISP1504 phy and so register nop transceiver */ > + usb_nop_xceiv_register(); > +#endif > usb_musb_init(); > omap3beagle_flash_init(); > } > diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig > index 803adcb..e27ed96 100644 > --- a/drivers/usb/musb/Kconfig > +++ b/drivers/usb/musb/Kconfig > @@ -13,6 +13,7 @@ config USB_MUSB_HDRC > select NOP_USB_XCEIV if ARCH_DAVINCI > select TWL4030_USB if MACH_OMAP_3430SDP > select NOP_USB_XCEIV if MACH_OMAP3EVM > + select NOP_USB_XCEIV if MACH_OMAP3_BEAGLE Shouldn't we be selecting TWL4030_USB if MACH_OMAP3_BEAGLE. The beagleboard does use the PHY in the TWL4030, and not a transparent PHY. - Anand -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
MUSB regression in 2.6.31-rc6
Hi BeagleBoard stopped booting at 2.6.31-rc6 and it turned out that this commit broke it: commit e8e2ff462dd92693f29eb848f42d3eb720390d59 Author: Gupta, Ajay Kumar Date: Wed Jul 29 11:58:57 2009 +0530 USB: musb: fix the nop registration for OMAP3EVM While this is easy to fix for the Beagle with a patch below, I don't know how many other OMAP boards there are which should be fixed as well. Or would it be better to revert the patch itself for 2.6.31? -- Jarkko --- diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c index 991ac9c..2ca0d44 100644 --- a/arch/arm/mach-omap2/board-omap3beagle.c +++ b/arch/arm/mach-omap2/board-omap3beagle.c @@ -30,6 +30,7 @@ #include #include +#include #include #include @@ -406,6 +407,10 @@ static void __init omap3_beagle_init(void) /* REVISIT leave DVI powered down until it's needed ... */ gpio_direction_output(170, true); +#ifdef CONFIG_NOP_USB_XCEIV + /* OMAP3EVM uses ISP1504 phy and so register nop transceiver */ + usb_nop_xceiv_register(); +#endif usb_musb_init(); omap3beagle_flash_init(); } diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index 803adcb..e27ed96 100644 --- a/drivers/usb/musb/Kconfig +++ b/drivers/usb/musb/Kconfig @@ -13,6 +13,7 @@ config USB_MUSB_HDRC select NOP_USB_XCEIV if ARCH_DAVINCI select TWL4030_USB if MACH_OMAP_3430SDP select NOP_USB_XCEIV if MACH_OMAP3EVM + select NOP_USB_XCEIV if MACH_OMAP3_BEAGLE select USB_OTG_UTILS tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)' help -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
