Re: [PATCH] OMAP3: Lock DPLL5 at boot
* Gadiyar, Anand [090930 09:59]: > > > > > > >Thanks for the changes, I will queue this in a for-next branch for > > > > > > >.33. > > > > > > > > > > > > Is this for .33 or .32? > > > > > > > > > > I think it might be a little late for .32. If there is some crash or > > > > > instability that this fixes, we could queue it up for .32-fixes ? > > > > > > > > Well, without this, there's no way the child clocks can be enabled > > > > correctly. > > > > > > OK. So is it the case that USBHOST/USBTLL/USIM won't work without this > > > fix? > > > > Yup. Not sure about USIM - will check. > > > > > > > > If so then we'll queue it for .32-fixes. Since .32 is already at -rc9, I > > > think it is too late for .32. > > > > > > > Would be nice. Thanks! > > > Paul, > > Is this patch already queued up somewhere, or are you waiting for a > clarification > from me on the USIM? > > (I haven't had a chance to look yet, since this is not in the regular TRM) I'll add this to omap-fixes-testing while we're waiting to put his fixes queue together. This way we can get rid of the remaining nasty stuff in the ehci branch. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP3: Lock DPLL5 at boot
> > > > > >Thanks for the changes, I will queue this in a for-next branch for > > > > > >.33. > > > > > > > > > > Is this for .33 or .32? > > > > > > > > I think it might be a little late for .32. If there is some crash or > > > > instability that this fixes, we could queue it up for .32-fixes ? > > > > > > Well, without this, there's no way the child clocks can be enabled > > > correctly. > > > > OK. So is it the case that USBHOST/USBTLL/USIM won't work without this > > fix? > > Yup. Not sure about USIM - will check. > > > > > If so then we'll queue it for .32-fixes. Since .32 is already at -rc9, I > > think it is too late for .32. > > > > Would be nice. Thanks! Paul, Is this patch already queued up somewhere, or are you waiting for a clarification from me on the USIM? (I haven't had a chance to look yet, since this is not in the regular TRM) - Anand-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP3: Lock DPLL5 at boot
> > > > >Thanks for the changes, I will queue this in a for-next branch for .33. > > > > > > > > Is this for .33 or .32? > > > > > > I think it might be a little late for .32. If there is some crash or > > > instability that this fixes, we could queue it up for .32-fixes ? > > > > Well, without this, there's no way the child clocks can be enabled > > correctly. > > OK. So is it the case that USBHOST/USBTLL/USIM won't work without this > fix? Yup. Not sure about USIM - will check. > > If so then we'll queue it for .32-fixes. Since .32 is already at -rc9, I > think it is too late for .32. > Would be nice. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP3: Lock DPLL5 at boot
On Wed, 9 Sep 2009, Gadiyar, Anand wrote: > On Wed, 9 Sep 2009, Paul Walmsley wrote: > > On Wed, 9 Sep 2009, Pandita, Vikram wrote: > > > > > >From: linux-omap-ow...@vger.kernel.org > > > >[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Paul > > > >Walmsley > > > >> $SUBJECT to reflect the change. > > > > > > > >Thanks for the changes, I will queue this in a for-next branch for .33. > > > > > > Is this for .33 or .32? > > > > I think it might be a little late for .32. If there is some crash or > > instability that this fixes, we could queue it up for .32-fixes ? > > Well, without this, there's no way the child clocks can be enabled correctly. OK. So is it the case that USBHOST/USBTLL/USIM won't work without this fix? If so then we'll queue it for .32-fixes. Since .32 is already at -rc9, I think it is too late for .32. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP3: Lock DPLL5 at boot
On Wed, 9 Sep 2009, Paul Walmsley wrote: > On Wed, 9 Sep 2009, Pandita, Vikram wrote: > > > >From: linux-omap-ow...@vger.kernel.org > > >[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Paul > > >Walmsley > > >> $SUBJECT to reflect the change. > > > > > >Thanks for the changes, I will queue this in a for-next branch for .33. > > > > Is this for .33 or .32? > > I think it might be a little late for .32. If there is some crash or > instability that this fixes, we could queue it up for .32-fixes ? > Well, without this, there's no way the child clocks can be enabled correctly. Possibly it qualifies as a bug-fix in clock framework? Rajendra had created this patch quite a while ago and it has received sufficient testing on various codebases - I guess we just missed sending it out to l-o early enough. - Anand -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP3: Lock DPLL5 at boot
On Wed, 9 Sep 2009, Pandita, Vikram wrote: > >From: linux-omap-ow...@vger.kernel.org > >[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Paul > >Walmsley > >> $SUBJECT to reflect the change. > > > >Thanks for the changes, I will queue this in a for-next branch for .33. > > Is this for .33 or .32? I think it might be a little late for .32. If there is some crash or instability that this fixes, we could queue it up for .32-fixes ? - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP3: Lock DPLL5 at boot
Paul >-Original Message- >From: linux-omap-ow...@vger.kernel.org >[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Paul >Walmsley >Sent: Wednesday, September 09, 2009 10:43 AM >To: Gadiyar, Anand >Cc: linux-omap@vger.kernel.org; Nayak, Rajendra; Cousson, Benoit >Subject: Re: [PATCH] OMAP3: Lock DPLL5 at boot > >On Tue, 8 Sep 2009, Anand Gadiyar wrote: > >> From: Rajendra Nayak >> >> OMAP3: Lock DPLL5 at boot >> >> Lock DPLL5 at 120MHz at boot. The USBHOST 120MHz f-clock and >> USBTLL f-clock are the only users of this DPLL, and 120MHz is >> is the only recommended rate for these clocks. >> >> With this patch, the 60 MHz ULPI clock is generated correctly. >> >> Tested on an OMAP3430 SDP. >> >> Signed-off-by: Rajendra Nayak >> Signed-off-by: Anand Gadiyar >> --- >> Incorporated all 3 comments by Paul and Benoit. Updated >> $SUBJECT to reflect the change. > >Thanks for the changes, I will queue this in a for-next branch for .33. Is this for .33 or .32? > > >- Paul >-- >To unsubscribe from this list: send the line "unsubscribe linux-omap" in >the body of a message to majord...@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] OMAP3: Lock DPLL5 at boot
On Tue, 8 Sep 2009, Anand Gadiyar wrote: > From: Rajendra Nayak > > OMAP3: Lock DPLL5 at boot > > Lock DPLL5 at 120MHz at boot. The USBHOST 120MHz f-clock and > USBTLL f-clock are the only users of this DPLL, and 120MHz is > is the only recommended rate for these clocks. > > With this patch, the 60 MHz ULPI clock is generated correctly. > > Tested on an OMAP3430 SDP. > > Signed-off-by: Rajendra Nayak > Signed-off-by: Anand Gadiyar > --- > Incorporated all 3 comments by Paul and Benoit. Updated > $SUBJECT to reflect the change. Thanks for the changes, I will queue this in a for-next branch for .33. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
