RE: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency related update.
Hello Paul, -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Wednesday, January 06, 2010 4:40 AM To: Pagare, Abhijit Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org Subject: RE: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency related update. On Wed, 30 Dec 2009, Pagare, Abhijit wrote: -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Wednesday, December 30, 2009 2:02 PM But really, I'd rather not apply this patch. The best way forward is to apply a patch that adds the OMAP4 wakeup and sleep dependencies themselves. Have you had a chance to look at the series that I sent you a few weeks ago off-list that reorganizes the wakeup and sleep dependencies to determine if it is adequate for you to add the OMAP4 wakeup/sleep dependencies afterwards? I had a look at the dependency patches that you had sent to me earlier and it seems feasible to add the OMAP4 related dependency data on top of those patches. A small change exists but can be taken care of. Great, I've just cleaned those up, rebased them, and posted them to the list. If you prefer, you can also get from the 'move_wkdeps_sleepdeps_to_clkdm' branch at git://git.pwsan.com/linux-2.6 I checked the dependency patch-set. The complete stuff looks really neat. Applying OMAP4 on top of this would be feasible. The only thing is that till the point the OMAP4 dependency patches go in the autodeps variable in arch/arm/clockdomain.c would not be initialized which will cause a kernel boot-crash for the functions _clkdm_add_autodeps(clkdm) and _clkdm_del_autodeps(clkdm). Hence the hack patch referred to in the subject above is essential. Should I re-post it with the missing FIXME indication that you had recommended? Thanks Regards, Abhijit - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency related update.
Hello Abhijit, On Wed, 6 Jan 2010, Pagare, Abhijit wrote: I checked the dependency patch-set. The complete stuff looks really neat. Applying OMAP4 on top of this would be feasible. The only thing is that till the point the OMAP4 dependency patches go in the autodeps variable in arch/arm/clockdomain.c would not be initialized which will cause a kernel boot-crash for the functions _clkdm_add_autodeps(clkdm) and _clkdm_del_autodeps(clkdm). Hence the hack patch referred to in the subject above is essential. Should I re-post it with the missing FIXME indication that you had recommended? My concern is that we don't want to forget about the OMAP4 sleep and wakeup dependencies. How long do you think it will take to add them? - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency related update.
Hello Paul, -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Thursday, January 07, 2010 2:40 AM To: Pagare, Abhijit Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org Subject: RE: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency related update. Hello Abhijit, On Wed, 6 Jan 2010, Pagare, Abhijit wrote: I checked the dependency patch-set. The complete stuff looks really neat. Applying OMAP4 on top of this would be feasible. The only thing is that till the point the OMAP4 dependency patches go in the autodeps variable in arch/arm/clockdomain.c would not be initialized which will cause a kernel boot-crash for the functions _clkdm_add_autodeps(clkdm) and _clkdm_del_autodeps(clkdm). Hence the hack patch referred to in the subject above is essential. Should I re-post it with the missing FIXME indication that you had recommended? My concern is that we don't want to forget about the OMAP4 sleep and wakeup dependencies. How long do you think it will take to add them? It shouldn't take all that long. I will internally send you the auto-generated file having the dependency details soon. Do let me know if you want any modification in it. If all that's done in a couple of days then the patch above can be skipped. Regards, Abhijit - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency related update.
On Thu, 7 Jan 2010, Pagare, Abhijit wrote: It shouldn't take all that long. I will internally send you the auto-generated file having the dependency details soon. Do let me know if you want any modification in it. If all that's done in a couple of days then the patch above can be skipped. That sounds great. As far as I know, the only public branch that contains your OMAP4 patches so far is the for_2.6.34 branch on my git server. It's not in mainline yet. So let's see if we can get that fixed up with the sleep and wakeup dependencies. If people are actually using code from the for_2.6.34 branch to boot their OMAP4 SDPs, I'd be happy to post a derivative branch with your temporary fixup patch added for them to use instead. Would that be useful? - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency related update.
On Wed, 30 Dec 2009, Pagare, Abhijit wrote: -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Wednesday, December 30, 2009 2:02 PM But really, I'd rather not apply this patch. The best way forward is to apply a patch that adds the OMAP4 wakeup and sleep dependencies themselves. Have you had a chance to look at the series that I sent you a few weeks ago off-list that reorganizes the wakeup and sleep dependencies to determine if it is adequate for you to add the OMAP4 wakeup/sleep dependencies afterwards? I had a look at the dependency patches that you had sent to me earlier and it seems feasible to add the OMAP4 related dependency data on top of those patches. A small change exists but can be taken care of. Great, I've just cleaned those up, rebased them, and posted them to the list. If you prefer, you can also get from the 'move_wkdeps_sleepdeps_to_clkdm' branch at git://git.pwsan.com/linux-2.6 - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency related update.
Hello Abhijit, On Wed, 23 Dec 2009, Abhijit Pagare wrote: A check is added for avoiding the sleep/wakeup dependency updates for OMAP4 as the structures for the dependencies are currently absent. As a threshold matter, code and data added in temporary hack patches like this need to be marked with XXX or FIXME or something similar to indicate that these are not intended features, but rather, temporary lines that need to be removed in the near term. But really, I'd rather not apply this patch. The best way forward is to apply a patch that adds the OMAP4 wakeup and sleep dependencies themselves. Have you had a chance to look at the series that I sent you a few weeks ago off-list that reorganizes the wakeup and sleep dependencies to determine if it is adequate for you to add the OMAP4 wakeup/sleep dependencies afterwards? - Paul Signed-off-by: Abhijit Pagare abhijitpag...@ti.com Cc: Paul Walmsley p...@pwsan.com --- Compiled and Boot Tested on OMAP4430 simulator, ES1 Chip OMAP3430 SDP. And also Compiled for OMAP2430 and OMAP2420 This patch has a dependency on the earlier set of OMAP4 clock-domain patches. arch/arm/mach-omap2/clockdomain.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/clockdomain.c b/arch/arm/mach-omap2/clockdomain.c index 8c9e78c..6ec25ee 100644 --- a/arch/arm/mach-omap2/clockdomain.c +++ b/arch/arm/mach-omap2/clockdomain.c @@ -507,8 +507,9 @@ void omap2_clkdm_allow_idle(struct clockdomain *clkdm) pr_debug(clockdomain: enabling automatic idle transitions for %s\n, clkdm-name); - if (atomic_read(clkdm-usecount) 0) - _clkdm_add_autodeps(clkdm); + if (!cpu_is_omap44xx()) + if (atomic_read(clkdm-usecount) 0) + _clkdm_add_autodeps(clkdm); _omap2_clkdm_set_hwsup(clkdm, 1); @@ -540,8 +541,9 @@ void omap2_clkdm_deny_idle(struct clockdomain *clkdm) _omap2_clkdm_set_hwsup(clkdm, 0); - if (atomic_read(clkdm-usecount) 0) - _clkdm_del_autodeps(clkdm); + if (!cpu_is_omap44xx()) + if (atomic_read(clkdm-usecount) 0) + _clkdm_del_autodeps(clkdm); } -- 1.5.4.7 - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency related update.
Hi Paul, -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Wednesday, December 30, 2009 2:02 PM To: Pagare, Abhijit Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org Subject: Re: [PATCH 1/1] ARM: OMAP4: PM: Add check for avoiding dependency related update. Hello Abhijit, On Wed, 23 Dec 2009, Abhijit Pagare wrote: A check is added for avoiding the sleep/wakeup dependency updates for OMAP4 as the structures for the dependencies are currently absent. As a threshold matter, code and data added in temporary hack patches like this need to be marked with XXX or FIXME or something similar to indicate that these are not intended features, but rather, temporary lines that need to be removed in the near term. I think I missed that. I will add the FIXME indication to the check below. I think that this check is essential for OMAP4 kernel boot-up as long as the dependency patches are not pushed in. But really, I'd rather not apply this patch. The best way forward is to apply a patch that adds the OMAP4 wakeup and sleep dependencies themselves. Have you had a chance to look at the series that I sent you a few weeks ago off-list that reorganizes the wakeup and sleep dependencies to determine if it is adequate for you to add the OMAP4 wakeup/sleep dependencies afterwards? I had a look at the dependency patches that you had sent to me earlier and it seems feasible to add the OMAP4 related dependency data on top of those patches. A small change exists but can be taken care of. Regards, Abhijit - Paul Signed-off-by: Abhijit Pagare abhijitpag...@ti.com Cc: Paul Walmsley p...@pwsan.com --- Compiled and Boot Tested on OMAP4430 simulator, ES1 Chip OMAP3430 SDP. And also Compiled for OMAP2430 and OMAP2420 This patch has a dependency on the earlier set of OMAP4 clock-domain patches. arch/arm/mach-omap2/clockdomain.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/clockdomain.c b/arch/arm/mach- omap2/clockdomain.c index 8c9e78c..6ec25ee 100644 --- a/arch/arm/mach-omap2/clockdomain.c +++ b/arch/arm/mach-omap2/clockdomain.c @@ -507,8 +507,9 @@ void omap2_clkdm_allow_idle(struct clockdomain *clkdm) pr_debug(clockdomain: enabling automatic idle transitions for %s\n, clkdm-name); - if (atomic_read(clkdm-usecount) 0) - _clkdm_add_autodeps(clkdm); + if (!cpu_is_omap44xx()) + if (atomic_read(clkdm-usecount) 0) + _clkdm_add_autodeps(clkdm); _omap2_clkdm_set_hwsup(clkdm, 1); @@ -540,8 +541,9 @@ void omap2_clkdm_deny_idle(struct clockdomain *clkdm) _omap2_clkdm_set_hwsup(clkdm, 0); - if (atomic_read(clkdm-usecount) 0) - _clkdm_del_autodeps(clkdm); + if (!cpu_is_omap44xx()) + if (atomic_read(clkdm-usecount) 0) + _clkdm_del_autodeps(clkdm); } -- 1.5.4.7 - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
