RE: [PATCH 1/2] ARM: l2x0: Errata fix for flush by Way operationcan cause data corruption

2011-02-28 Thread Santosh Shilimkar 
 -Original Message-
 From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk]
 Sent: Monday, February 28, 2011 3:44 PM
 To: Santosh Shilimkar
 Cc: t...@atomide.com; catalin.mari...@arm.com; linux-
 o...@vger.kernel.org; linux-arm-ker...@lists.infradead.org
 Subject: Re: [PATCH 1/2] ARM: l2x0: Errata fix for flush by Way
 operationcan cause data corruption

 On Sun, Feb 27, 2011 at 12:00:21PM +, Russell King - ARM Linux
 wrote:
   +#else
   +/* Optimised out for non-errata case */
   +static inline void debug_writel(unsigned long val)
   +{
}
 
  #define l2x0_set_debug  NULL
 
   +#endif

 I notice you got rid of the inline function.  Have you tried
 building this without the errata enabled?

I accidently dropped the inline function while
incorporating the comment from you. :(

Fixed it. Updated version # 6770/1

Regards,
Santosh
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/2] ARM: l2x0: Errata fix for flush by Way operationcan cause data corruption

2011-02-27 Thread Santosh Shilimkar 
 -Original Message-
 From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk]
 Sent: Sunday, February 27, 2011 5:30 PM
 To: Santosh Shilimkar
 Cc: linux-arm-ker...@lists.infradead.org; t...@atomide.com;
 catalin.mari...@arm.com; linux-omap@vger.kernel.org
 Subject: Re: [PATCH 1/2] ARM: l2x0: Errata fix for flush by Way
 operationcan cause data corruption

 On Fri, Feb 18, 2011 at 06:05:24PM +0530, Santosh Shilimkar wrote:

[...]


  @@ -329,6 +330,7 @@ void __init l2x0_init(void __iomem *base,
 __u32 aux_val, __u32 aux_mask)
  outer_cache.flush_all = l2x0_flush_all;
  outer_cache.inv_all = l2x0_inv_all;
  outer_cache.disable = l2x0_disable;
  +   outer_cache.set_debug = NULL;

   outer_cache.set_debug = l2x0_set_debug;

 may result in more efficient code as we're avoiding having to test
 the value of outer_cache.set_debug each time we want to call it and
 branch appropriately.

Ok. Will do the necessary change and submit it to patch System

Regards,
Santosh
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html