Re: [PATCH 1/4] musb: get rid of unneeded musb->config->dyn_fifo
Hi, On Thu, Dec 17, 2009 at 02:12:58PM +0100, ext Gupta, Ajay Kumar wrote: Ok fine, then please drop that specific patch from series and pick the Others. will do :-) -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/4] musb: get rid of unneeded musb->config->dyn_fifo
> -Original Message- > From: Felipe Balbi [mailto:felipe.ba...@nokia.com] > Sent: Thursday, December 17, 2009 6:40 PM > To: Gupta, Ajay Kumar > Cc: Balbi Felipe (Nokia-D/Helsinki); linux-...@vger.kernel.org; linux- > o...@vger.kernel.org > Subject: Re: [PATCH 1/4] musb: get rid of unneeded musb->config->dyn_fifo > > Hi, > > On Thu, Dec 17, 2009 at 02:01:27PM +0100, ext Gupta, Ajay Kumar wrote: > >Any update on this ? Shall I send the series again with __deprecated ? or > >If you can just add it on your own? > > I guess we have to do that and start sending patches to arch maintainers > removing the dyn_fifo stuff from board-files. > > we should have all fixed by the end of .33-final, then we send a patch > finally removing dyn_fifo from musb's platform_data. Ok fine, then please drop that specific patch from series and pick the Others. -Ajay > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] musb: get rid of unneeded musb->config->dyn_fifo
Hi, On Thu, Dec 17, 2009 at 02:01:27PM +0100, ext Gupta, Ajay Kumar wrote: Any update on this ? Shall I send the series again with __deprecated ? or If you can just add it on your own? I guess we have to do that and start sending patches to arch maintainers removing the dyn_fifo stuff from board-files. we should have all fixed by the end of .33-final, then we send a patch finally removing dyn_fifo from musb's platform_data. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/4] musb: get rid of unneeded musb->config->dyn_fifo
> -Original Message-
> From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
> ow...@vger.kernel.org] On Behalf Of Gupta, Ajay Kumar
> Sent: Tuesday, December 15, 2009 8:45 PM
> To: felipe.ba...@nokia.com
> Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org
> Subject: RE: [PATCH 1/4] musb: get rid of unneeded musb->config->dyn_fifo
>
>
> >Hi,
> >
> >On Tue, Dec 15, 2009 at 02:31:46PM +0100, ext Ajay Kumar Gupta wrote:
> >>diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
> >>index d437556..c5f006e 100644
> >>--- a/include/linux/usb/musb.h
> >>+++ b/include/linux/usb/musb.h
> >>@@ -30,7 +30,6 @@ struct musb_hdrc_eps_bits {
> >> struct musb_hdrc_config {
> >> /* MUSB configuration-specific details */
> >> unsignedmultipoint:1; /* multipoint device */
> >>- unsigneddyn_fifo:1; /* supports dynamic fifo sizing */
> >> unsignedsoft_con:1; /* soft connect required */
> >> unsignedutm_16:1; /* utm data witdh is 16 bits */
> >> unsignedbig_endian:1; /* true if CPU uses big-endian */
> >
> >same problem as the other patch I sent:
> >
> >$ git grep -w dyn_fifo arch/
> >arch/arm/mach-davinci/usb.c:.dyn_fifo = true,
> >arch/arm/mach-omap2/usb-musb.c: .dyn_fifo = 1,
> >arch/blackfin/mach-bf527/boards/cm_bf527.c: .dyn_fifo = 0,
> >arch/blackfin/mach-bf527/boards/ezbrd.c:.dyn_fifo = 0,
> >arch/blackfin/mach-bf527/boards/ezkit.c:.dyn_fifo = 0,
> >arch/blackfin/mach-bf548/boards/cm_bf548.c: .dyn_fifo = 0,
> >arch/blackfin/mach-bf548/boards/ezkit.c:.dyn_fifo = 0,
> >
> >we have to agree who will carry the arch changes.
>
> >what we can do is mark that field as deprecated and give one major
> >release for people to remove that from their boards, then we send a
> >patch finally removing it.
>
> Even with one major release window someone has to submit patch removing
> them
> from arch/ files. So I think it's better to remove them now itself. we can
> seperately
> submit patches to respective maintainers. Or best is if Greg can accept
> those changes
> which are mostly trivial.
Felipe,
Any update on this ? Shall I send the series again with __deprecated ? or
If you can just add it on your own?
Thanks,
Ajay
>
> -Ajay--
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/4] musb: get rid of unneeded musb->config->dyn_fifo
> -Original Message-
> From: Tony Lindgren [mailto:t...@atomide.com]
> Sent: Tuesday, December 15, 2009 11:10 PM
> To: Gupta, Ajay Kumar
> Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org;
> felipe.ba...@nokia.com
> Subject: Re: [PATCH 1/4] musb: get rid of unneeded musb->config->dyn_fifo
>
> * Ajay Kumar Gupta [091215 05:31]:
> > We can get dynamic FIFO information from CONFIGDATA register and
> > thus there is no need for any user defiend dyn_fifo.
>
> Have you tested this?
>
> $ grep dyn_fifo arch/arm/mach-omap2/*.c
> arch/arm/mach-omap2/usb-musb.c: .dyn_fifo = 1,
I did test but with this arch specific compilation fixes.
We are still waiting a response from Greg if he will accept these arch specific
changes with USB patch set.
-Ajay
>
> Tony
>
> > Signed-off-by: Ajay Kumar Gupta
> > ---
> > drivers/usb/musb/musb_core.c | 19 ---
> > include/linux/usb/musb.h |1 -
> > 2 files changed, 4 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> > index 49f2346..2858940 100644
> > --- a/drivers/usb/musb/musb_core.c
> > +++ b/drivers/usb/musb/musb_core.c
> > @@ -1404,21 +1404,10 @@ static int __init musb_core_init(u16 musb_type,
> struct musb *musb)
> > musb->nr_endpoints = 1;
> > musb->epmask = 1;
> >
> > - if (reg & MUSB_CONFIGDATA_DYNFIFO) {
> > - if (musb->config->dyn_fifo)
> > - status = ep_config_from_table(musb);
> > - else {
> > - ERR("reconfigure software for Dynamic FIFOs\n");
> > - status = -ENODEV;
> > - }
> > - } else {
> > - if (!musb->config->dyn_fifo)
> > - status = ep_config_from_hw(musb);
> > - else {
> > - ERR("reconfigure software for static FIFOs\n");
> > - return -ENODEV;
> > - }
> > - }
> > + if (reg & MUSB_CONFIGDATA_DYNFIFO)
> > + status = ep_config_from_table(musb);
> > + else
> > + status = ep_config_from_hw(musb);
> >
> > if (status < 0)
> > return status;
> > diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
> > index d437556..c5f006e 100644
> > --- a/include/linux/usb/musb.h
> > +++ b/include/linux/usb/musb.h
> > @@ -30,7 +30,6 @@ struct musb_hdrc_eps_bits {
> > struct musb_hdrc_config {
> > /* MUSB configuration-specific details */
> > unsignedmultipoint:1; /* multipoint device */
> > - unsigneddyn_fifo:1; /* supports dynamic fifo sizing */
> > unsignedsoft_con:1; /* soft connect required */
> > unsignedutm_16:1; /* utm data witdh is 16 bits */
> > unsignedbig_endian:1; /* true if CPU uses big-endian */
> > --
> > 1.6.2.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majord...@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] musb: get rid of unneeded musb->config->dyn_fifo
* Ajay Kumar Gupta [091215 05:31]:
> We can get dynamic FIFO information from CONFIGDATA register and
> thus there is no need for any user defiend dyn_fifo.
Have you tested this?
$ grep dyn_fifo arch/arm/mach-omap2/*.c
arch/arm/mach-omap2/usb-musb.c: .dyn_fifo = 1,
Tony
> Signed-off-by: Ajay Kumar Gupta
> ---
> drivers/usb/musb/musb_core.c | 19 ---
> include/linux/usb/musb.h |1 -
> 2 files changed, 4 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 49f2346..2858940 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1404,21 +1404,10 @@ static int __init musb_core_init(u16 musb_type,
> struct musb *musb)
> musb->nr_endpoints = 1;
> musb->epmask = 1;
>
> - if (reg & MUSB_CONFIGDATA_DYNFIFO) {
> - if (musb->config->dyn_fifo)
> - status = ep_config_from_table(musb);
> - else {
> - ERR("reconfigure software for Dynamic FIFOs\n");
> - status = -ENODEV;
> - }
> - } else {
> - if (!musb->config->dyn_fifo)
> - status = ep_config_from_hw(musb);
> - else {
> - ERR("reconfigure software for static FIFOs\n");
> - return -ENODEV;
> - }
> - }
> + if (reg & MUSB_CONFIGDATA_DYNFIFO)
> + status = ep_config_from_table(musb);
> + else
> + status = ep_config_from_hw(musb);
>
> if (status < 0)
> return status;
> diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
> index d437556..c5f006e 100644
> --- a/include/linux/usb/musb.h
> +++ b/include/linux/usb/musb.h
> @@ -30,7 +30,6 @@ struct musb_hdrc_eps_bits {
> struct musb_hdrc_config {
> /* MUSB configuration-specific details */
> unsignedmultipoint:1; /* multipoint device */
> - unsigneddyn_fifo:1; /* supports dynamic fifo sizing */
> unsignedsoft_con:1; /* soft connect required */
> unsignedutm_16:1; /* utm data witdh is 16 bits */
> unsignedbig_endian:1; /* true if CPU uses big-endian */
> --
> 1.6.2.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/4] musb: get rid of unneeded musb->config->dyn_fifo
>Hi,
>
>On Tue, Dec 15, 2009 at 02:31:46PM +0100, ext Ajay Kumar Gupta wrote:
>>diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
>>index d437556..c5f006e 100644
>>--- a/include/linux/usb/musb.h
>>+++ b/include/linux/usb/musb.h
>>@@ -30,7 +30,6 @@ struct musb_hdrc_eps_bits {
>> struct musb_hdrc_config {
>> /* MUSB configuration-specific details */
>> unsignedmultipoint:1; /* multipoint device */
>>- unsigneddyn_fifo:1; /* supports dynamic fifo sizing */
>> unsignedsoft_con:1; /* soft connect required */
>> unsignedutm_16:1; /* utm data witdh is 16 bits */
>> unsignedbig_endian:1; /* true if CPU uses big-endian */
>
>same problem as the other patch I sent:
>
>$ git grep -w dyn_fifo arch/
>arch/arm/mach-davinci/usb.c:.dyn_fifo = true,
>arch/arm/mach-omap2/usb-musb.c: .dyn_fifo = 1,
>arch/blackfin/mach-bf527/boards/cm_bf527.c: .dyn_fifo = 0,
>arch/blackfin/mach-bf527/boards/ezbrd.c:.dyn_fifo = 0,
>arch/blackfin/mach-bf527/boards/ezkit.c:.dyn_fifo = 0,
>arch/blackfin/mach-bf548/boards/cm_bf548.c: .dyn_fifo = 0,
>arch/blackfin/mach-bf548/boards/ezkit.c:.dyn_fifo = 0,
>
>we have to agree who will carry the arch changes.
>what we can do is mark that field as deprecated and give one major
>release for people to remove that from their boards, then we send a
>patch finally removing it.
Even with one major release window someone has to submit patch removing them
from arch/ files. So I think it's better to remove them now itself. we can
seperately
submit patches to respective maintainers. Or best is if Greg can accept those
changes
which are mostly trivial.
-Ajay--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] musb: get rid of unneeded musb->config->dyn_fifo
On Tue, Dec 15, 2009 at 02:34:32PM +0100, Balbi Felipe (Nokia-D/Helsinki) wrote:
Hi,
On Tue, Dec 15, 2009 at 02:31:46PM +0100, ext Ajay Kumar Gupta wrote:
diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
index d437556..c5f006e 100644
--- a/include/linux/usb/musb.h
+++ b/include/linux/usb/musb.h
@@ -30,7 +30,6 @@ struct musb_hdrc_eps_bits {
struct musb_hdrc_config {
/* MUSB configuration-specific details */
unsignedmultipoint:1; /* multipoint device */
- unsigneddyn_fifo:1; /* supports dynamic fifo sizing */
unsignedsoft_con:1; /* soft connect required */
unsignedutm_16:1; /* utm data witdh is 16 bits */
unsignedbig_endian:1; /* true if CPU uses big-endian */
same problem as the other patch I sent:
$ git grep -w dyn_fifo arch/
arch/arm/mach-davinci/usb.c:.dyn_fifo = true,
arch/arm/mach-omap2/usb-musb.c: .dyn_fifo = 1,
arch/blackfin/mach-bf527/boards/cm_bf527.c: .dyn_fifo = 0,
arch/blackfin/mach-bf527/boards/ezbrd.c:.dyn_fifo = 0,
arch/blackfin/mach-bf527/boards/ezkit.c:.dyn_fifo = 0,
arch/blackfin/mach-bf548/boards/cm_bf548.c: .dyn_fifo = 0,
arch/blackfin/mach-bf548/boards/ezkit.c:.dyn_fifo = 0,
we have to agree who will carry the arch changes.
what we can do is mark that field as deprecated and give one major
release for people to remove that from their boards, then we send a
patch finally removing it.
I'm talking about:
diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
index d437556..c3ca147 100644
--- a/include/linux/usb/musb.h
+++ b/include/linux/usb/musb.h
@@ -30,7 +30,7 @@ struct musb_hdrc_eps_bits {
struct musb_hdrc_config {
/* MUSB configuration-specific details */
unsignedmultipoint:1; /* multipoint device */
- unsigneddyn_fifo:1; /* supports dynamic fifo sizing */
+ unsigneddyn_fifo:1 __deprecated;/* supports dynamic
fifo sizing */
unsignedsoft_con:1; /* soft connect required */
unsignedutm_16:1; /* utm data witdh is 16 bits */
unsignedbig_endian:1; /* true if CPU uses big-endian */
how do you feel about that ?
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] musb: get rid of unneeded musb->config->dyn_fifo
Hi,
On Tue, Dec 15, 2009 at 02:31:46PM +0100, ext Ajay Kumar Gupta wrote:
diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
index d437556..c5f006e 100644
--- a/include/linux/usb/musb.h
+++ b/include/linux/usb/musb.h
@@ -30,7 +30,6 @@ struct musb_hdrc_eps_bits {
struct musb_hdrc_config {
/* MUSB configuration-specific details */
unsignedmultipoint:1; /* multipoint device */
- unsigneddyn_fifo:1; /* supports dynamic fifo sizing */
unsignedsoft_con:1; /* soft connect required */
unsignedutm_16:1; /* utm data witdh is 16 bits */
unsignedbig_endian:1; /* true if CPU uses big-endian */
same problem as the other patch I sent:
$ git grep -w dyn_fifo arch/
arch/arm/mach-davinci/usb.c:.dyn_fifo = true,
arch/arm/mach-omap2/usb-musb.c: .dyn_fifo = 1,
arch/blackfin/mach-bf527/boards/cm_bf527.c: .dyn_fifo = 0,
arch/blackfin/mach-bf527/boards/ezbrd.c:.dyn_fifo = 0,
arch/blackfin/mach-bf527/boards/ezkit.c:.dyn_fifo = 0,
arch/blackfin/mach-bf548/boards/cm_bf548.c: .dyn_fifo = 0,
arch/blackfin/mach-bf548/boards/ezkit.c:.dyn_fifo = 0,
we have to agree who will carry the arch changes.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
