RE: [PATCH 12/19] omap: Fix gpio_resume_after_retention

2010-03-12 Thread Aguirre, Sergio 


From: Felipe Balbi [mailto:felipe.ba...@nokia.com]
Sent: Friday, March 12, 2010 7:19 AM
> On Fri, Mar 12, 2010 at 11:37:50AM +0100, ext Gadiyar, Anand wrote:
> >I send patches with an explicit "From: Anand Gadiyar "
> >line in the content. This seems to work okay.
> >
> >Can you check if this works for you?
> 
> $ git config --global sendemail.from "Sergio Aguirre "
> $ git send-email --to linux-omap@vger.kernel.org --from saagui...@ti.com
> 0001-mypatch.patch
> 
> This will forge git to add the From: Sergio Aguirre 
> when sending the patches

Great!

Thanks, Anand and Felipe. I'll definitely experiment with those 2.

Regards,
Sergio

> 
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/19] omap: Fix gpio_resume_after_retention

2010-03-12 Thread Felipe Balbi 

On Fri, Mar 12, 2010 at 11:37:50AM +0100, ext Gadiyar, Anand wrote:

I send patches with an explicit "From: Anand Gadiyar "
line in the content. This seems to work okay.

Can you check if this works for you?


$ git config --global sendemail.from "Sergio Aguirre "
$ git send-email --to linux-omap@vger.kernel.org --from saagui...@ti.com 
0001-mypatch.patch

This will forge git to add the From: Sergio Aguirre  
when sending the patches


--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 12/19] omap: Fix gpio_resume_after_retention

2010-03-12 Thread Gadiyar, Anand 
> I normally send my patches with this alias:
> 
> alias gsend='git send-email --smtp-server /usr/bin/msmtp 
> --from "Sergio Aguirre " 
> --envelope-sender="Sergio Aguirre "'
> 
> and then just do:
> 
> gsend --to='linux-omap@vger.kernel.org' 
> patches/forLO_20100311/0001-mypatch.patch
> 
> But somehow the patch ends up (I'm guessing through TI LDAP 
> server) changing that to "Aguirre, Sergio"...
> 
> and also Patchworks seems to continue display my old 
> fullname: "Aguirre Rodriguez, Sergio Alberto"... I guess it's 
> in a static data cache somewhere, maybe?
> 
> Does anyone know how to overcome this kind of scenario, and 
> force what --from param says?

I send patches with an explicit "From: Anand Gadiyar "
line in the content. This seems to work okay.

Can you check if this works for you?

- Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 12/19] omap: Fix gpio_resume_after_retention

2010-03-11 Thread Aguirre, Sergio 


> -Original Message-
> From: Tony Lindgren [mailto:t...@atomide.com]
> Sent: Thursday, March 11, 2010 5:57 PM
> To: Aguirre, Sergio
> Cc: linux-arm-ker...@lists.infradead.org; linux-omap@vger.kernel.org
> Subject: Re: [PATCH 12/19] omap: Fix gpio_resume_after_retention
> 
> * Aguirre, Sergio  [100311 15:47]:
> > Hi Tony,
> >
> > > -Original Message-
> > > From: Tony Lindgren [mailto:t...@atomide.com]
> > > Sent: Thursday, March 11, 2010 5:49 PM
> > > To: linux-arm-ker...@lists.infradead.org
> > > Cc: Aguirre, Sergio; linux-omap@vger.kernel.org
> > > Subject: [PATCH 12/19] omap: Fix gpio_resume_after_retention
> > >
> > > From: Tony Lindgren 
> >
> > Something funky mix happened with the authorship here :)
> >
> > Should be:
> >
> > From: Sergio Aguirre 
> 
> Thanks, updated patch below.
> 
> I think this issue is related to applying patches from
> patchwork.kernel.org with email addresses in Lastname, Firstname
> format..

Hmm... I see.

I normally send my patches with this alias:

alias gsend='git send-email --smtp-server /usr/bin/msmtp --from "Sergio Aguirre 
" --envelope-sender="Sergio Aguirre "'

and then just do:

gsend --to='linux-omap@vger.kernel.org' 
patches/forLO_20100311/0001-mypatch.patch

But somehow the patch ends up (I'm guessing through TI LDAP server) changing 
that to "Aguirre, Sergio"...

and also Patchworks seems to continue display my old fullname: "Aguirre 
Rodriguez, Sergio Alberto"... I guess it's in a static data cache somewhere, 
maybe?

Does anyone know how to overcome this kind of scenario, and force what --from 
param says?

Regards,
Sergio

> 
> Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/19] omap: Fix gpio_resume_after_retention

2010-03-11 Thread Tony Lindgren 
* Aguirre, Sergio  [100311 15:47]:
> Hi Tony,
> 
> > -Original Message-
> > From: Tony Lindgren [mailto:t...@atomide.com]
> > Sent: Thursday, March 11, 2010 5:49 PM
> > To: linux-arm-ker...@lists.infradead.org
> > Cc: Aguirre, Sergio; linux-omap@vger.kernel.org
> > Subject: [PATCH 12/19] omap: Fix gpio_resume_after_retention
> > 
> > From: Tony Lindgren 
> 
> Something funky mix happened with the authorship here :)
> 
> Should be:
> 
> From: Sergio Aguirre 

Thanks, updated patch below.

I think this issue is related to applying patches from
patchwork.kernel.org with email addresses in Lastname, Firstname
format..

Tony
>From f00d649703fbedbdeb33d63c4c4731656e11297c Mon Sep 17 00:00:00 2001
From: Sergio Aguirre 
Date: Wed, 3 Mar 2010 16:21:08 +
Subject: [PATCH] omap: Fix gpio_resume_after_retention

For omap4 case, this was wrongly writing GPIO_LEVELDETECTx
registers with OMAP24XX_ offset and OMAP4_ offset.

Bug introduced in commit:

  commit 3f1686a9bfe74979c6ad538c78039730f665f77e
  Author: Tony Lindgren 
  Date:   Mon Feb 15 09:27:25 2010 -0800

  omap: Fix gpio.c for multi-omap for omap4

Signed-off-by: Sergio Aguirre 
Signed-off-by: Tony Lindgren 

diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index 337199e..76a347b 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -2140,18 +2140,18 @@ void omap2_gpio_resume_after_retention(void)
 		if (gen) {
 			u32 old0, old1;
 
-			if (cpu_is_omap24xx() || cpu_is_omap44xx()) {
+			if (cpu_is_omap24xx() || cpu_is_omap34xx()) {
 old0 = __raw_readl(bank->base +
 	OMAP24XX_GPIO_LEVELDETECT0);
 old1 = __raw_readl(bank->base +
 	OMAP24XX_GPIO_LEVELDETECT1);
-			__raw_writel(old0 | gen, bank->base +
+__raw_writel(old0 | gen, bank->base +
 	OMAP24XX_GPIO_LEVELDETECT0);
-			__raw_writel(old1 | gen, bank->base +
+__raw_writel(old1 | gen, bank->base +
 	OMAP24XX_GPIO_LEVELDETECT1);
-			__raw_writel(old0, bank->base +
+__raw_writel(old0, bank->base +
 	OMAP24XX_GPIO_LEVELDETECT0);
-			__raw_writel(old1, bank->base +
+__raw_writel(old1, bank->base +
 	OMAP24XX_GPIO_LEVELDETECT1);
 			}

RE: [PATCH 12/19] omap: Fix gpio_resume_after_retention

2010-03-11 Thread Aguirre, Sergio 
Hi Tony,

> -Original Message-
> From: Tony Lindgren [mailto:t...@atomide.com]
> Sent: Thursday, March 11, 2010 5:49 PM
> To: linux-arm-ker...@lists.infradead.org
> Cc: Aguirre, Sergio; linux-omap@vger.kernel.org
> Subject: [PATCH 12/19] omap: Fix gpio_resume_after_retention
> 
> From: Tony Lindgren 

Something funky mix happened with the authorship here :)

Should be:

From: Sergio Aguirre 

Regards,
Sergio

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html