RE: [PATCH 3/6] omap4: l2x0: Override the default l2x0_disable

2010-09-15 Thread Shilimkar, Santosh
> -Original Message-
> From: Tony Lindgren [mailto:t...@atomide.com]
> Sent: Thursday, September 16, 2010 5:52 AM
> To: Shilimkar, Santosh
> Cc: linux-arm-ker...@lists.infradead.org; t...@linutronix.de;
> catalin.mari...@arm.com; linux-omap@vger.kernel.org
> Subject: Re: [PATCH 3/6] omap4: l2x0: Override the default l2x0_disable
> 
> * Santosh Shilimkar  [100907 00:50]:
> > The machine_kexec() calls outer_disable which can crash on OMAP4
> > becasue of trustzone restrictions.
> >
> > This patch overrides the default l2x0_disable with a OMAP4
> > specific implementation taking care of trustzone
> 
> 
> 
> > @@ -66,6 +73,12 @@ static int __init omap_l2_cache_init(void)
> >
> >  */
> > l2x0_init(l2cache_base, 0x0e05, 0xcfff);
> >
> > +   /*
> > +* Override default outer_cache.disable with a OMAP4
> > +* specific one
> > +   */
> > +   outer_cache.disable = omap4_l2x0_disable;
> > +
> > return 0;
> >  }
> >  early_initcall(omap_l2_cache_init);
> 
> Just to be sure.. No outer_cache functions get set unless
> l2x0_init gets called, right? So omap2 and omap3 functions
> always stay NULL with omap3_defconfig?
> 
Yes.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 3/6] omap4: l2x0: Override the default l2x0_disable

2010-09-15 Thread Tony Lindgren
* Santosh Shilimkar  [100907 00:50]:
> The machine_kexec() calls outer_disable which can crash on OMAP4
> becasue of trustzone restrictions.
> 
> This patch overrides the default l2x0_disable with a OMAP4
> specific implementation taking care of trustzone



> @@ -66,6 +73,12 @@ static int __init omap_l2_cache_init(void)
>
>*/
>   l2x0_init(l2cache_base, 0x0e05, 0xcfff);
>
> + /*
> +  * Override default outer_cache.disable with a OMAP4
> +  * specific one
> + */
> + outer_cache.disable = omap4_l2x0_disable;
> +
>   return 0;
>  }
>  early_initcall(omap_l2_cache_init);

Just to be sure.. No outer_cache functions get set unless
l2x0_init gets called, right? So omap2 and omap3 functions
always stay NULL with omap3_defconfig?

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html