Re: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-29 Thread Sergei Shtylyov 

Hello.

Hema HK wrote:


From: Hema HK  hem...@ti.com


   I think the patch description has clarity issues...

Changed the musb driver to use omap_build_device api instead of 


   I don't see where are you changing the MUSB driver.


platform_device_registration.


   Why underscores here?

The device specific resources defined in 
centralized database will be used. So removed the resource definitions from

the driver file.


   Do you mean usb-musb.c here? This is certainly not a driver.


Signed-off-by: Hema HK hem...@ti.com
Cc: Felipe Balbi felipe.ba...@nokia.com,t...@atomide.com


WBR, Sergei

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-29 Thread Tony Lindgren 
* Kalliguddi, Hema hem...@ti.com [100628 16:52]:

 Yes. The comment is being removed in the patch I posted. I will keep it.

Thanks.

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-29 Thread Kalliguddi, Hema 
 Hello,

-Original Message-
From: Sergei Shtylyov [mailto:sshtyl...@mvista.com] 
Sent: Tuesday, June 29, 2010 4:35 PM
To: Kalliguddi, Hema
Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; 
Felipe Balbi; t...@atomide.com
Subject: Re: [PATCH 4/4]usb : musb:USB driver using 
omap_device_build for device registration.

Hello.

Hema HK wrote:

 From: Hema HK  hem...@ti.com

I think the patch description has clarity issues...

 Changed the musb driver to use omap_build_device api instead of 

I don't see where are you changing the MUSB driver.

There is function name mismatch in the description.it should be 
omap_device_build instead of omap_build_device.
The change is in usb-musb.c file. I agree that it is not a driver file.I will 
change the description appropriately.


 platform_device_registration.

Why underscores here?

I intended to provide the API name here platform_device_register. I will 
correct it.

 The device specific resources defined in 
 centralized database will be used. So removed the resource 
definitions from
 the driver file.

Do you mean usb-musb.c here? This is certainly not a driver.

Agreed not a driver.

Regards,
Hema
 Signed-off-by: Hema HK hem...@ti.com
 Cc: Felipe Balbi felipe.ba...@nokia.com,t...@atomide.com

WBR, Sergei

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-28 Thread Tony Lindgren 
* Hema HK hem...@ti.com [100628 15:12]:
 -
 - /*
 -  * REVISIT: This line can be removed once all the platforms using
 -  * musb_core.c have been converted to use use clkdev.
 -  */
 - musb_plat.clock = ick;

This comment is still valid, please don't remove it.

Regards,

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-28 Thread Kalliguddi, Hema 
 

-Original Message-
From: Tony Lindgren [mailto:t...@atomide.com] 
Sent: Monday, June 28, 2010 6:59 PM
To: Kalliguddi, Hema
Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Felipe Balbi
Subject: Re: [PATCH 4/4]usb : musb:USB driver using 
omap_device_build for device registration.

* Hema HK hem...@ti.com [100628 15:12]:
 -
 -/*
 - * REVISIT: This line can be removed once all the 
platforms using
 - * musb_core.c have been converted to use use clkdev.
 - */
 -musb_plat.clock = ick;

This comment is still valid, please don't remove it.
This is still there. It is moved below under else.

Regards,
Hema

Regards,

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-28 Thread Tony Lindgren 
* Kalliguddi, Hema hem...@ti.com [100628 16:26]:
  
 
 -Original Message-
 From: Tony Lindgren [mailto:t...@atomide.com] 
 Sent: Monday, June 28, 2010 6:59 PM
 To: Kalliguddi, Hema
 Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Felipe Balbi
 Subject: Re: [PATCH 4/4]usb : musb:USB driver using 
 omap_device_build for device registration.
 
 * Hema HK hem...@ti.com [100628 15:12]:
  -
  -  /*
  -   * REVISIT: This line can be removed once all the 
 platforms using
  -   * musb_core.c have been converted to use use clkdev.
  -   */
  -  musb_plat.clock = ick;
 
 This comment is still valid, please don't remove it.
 This is still there. It is moved below under else.

Not in the patch you posted?

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-28 Thread Kalliguddi, Hema 
 

-Original Message-
From: Tony Lindgren [mailto:t...@atomide.com] 
Sent: Monday, June 28, 2010 7:12 PM
To: Kalliguddi, Hema
Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Felipe Balbi
Subject: Re: [PATCH 4/4]usb : musb:USB driver using 
omap_device_build for device registration.

* Kalliguddi, Hema hem...@ti.com [100628 16:26]:
  
 
 -Original Message-
 From: Tony Lindgren [mailto:t...@atomide.com] 
 Sent: Monday, June 28, 2010 6:59 PM
 To: Kalliguddi, Hema
 Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; 
Felipe Balbi
 Subject: Re: [PATCH 4/4]usb : musb:USB driver using 
 omap_device_build for device registration.
 
 * Hema HK hem...@ti.com [100628 15:12]:
  -
  - /*
  -  * REVISIT: This line can be removed once all the 
 platforms using
  -  * musb_core.c have been converted to use use clkdev.
  -  */
  - musb_plat.clock = ick;
 
 This comment is still valid, please don't remove it.
 This is still there. It is moved below under else.

Not in the patch you posted?


-   musb_plat.clock = ick;
-   musb_plat.board_data = board_data;
-   musb_plat.power = board_data-power  1;
-   musb_plat.mode = board_data-mode;
-   musb_plat.extvbus = board_data-extvbus;
-
-   if (platform_device_register(musb_device)  0)
-   printk(KERN_ERR Unable to register HS-USB (MUSB) device\n);
+   char oh_name[MAX_OMAP_MUSB_HWMOD_NAME_LEN];
+   struct omap_hwmod *oh;
+   struct omap_device *od;
+   struct platform_device *pdev;
+   struct device   *dev;
+   int l, bus_id = -1;
+   struct musb_hdrc_platform_data *pdata;
+
+   l = snprintf(oh_name, MAX_OMAP_MUSB_HWMOD_NAME_LEN,
+   usb_otg_hs);
+   WARN(l = MAX_OMAP_MUSB_HWMOD_NAME_LEN,
+   String buffer overflow in MUSB device setup\n);
+   oh = omap_hwmod_lookup(oh_name);
+   if (!oh) {
+   pr_err(Could not look up %s\n, oh_name);
+   } else {
+   musb_plat.clock = ick;
+   musb_plat.board_data = board_data;
+   musb_plat.power = board_data-power  1;
+   musb_plat.mode = board_data-mode;
+   pdata = musb_plat;

It is there in the patch I posted.only the comment is being removed. You are 
refering the comment also? 

Regards,
Hema
Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-28 Thread Kalliguddi, Hema 
 

-Original Message-
From: linux-usb-ow...@vger.kernel.org 
[mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Kalliguddi, Hema
Sent: Monday, June 28, 2010 7:17 PM
To: Tony Lindgren
Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Felipe Balbi
Subject: RE: [PATCH 4/4]usb : musb:USB driver using 
omap_device_build for device registration.

 

-Original Message-
From: Tony Lindgren [mailto:t...@atomide.com] 
Sent: Monday, June 28, 2010 7:12 PM
To: Kalliguddi, Hema
Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; 
Felipe Balbi
Subject: Re: [PATCH 4/4]usb : musb:USB driver using 
omap_device_build for device registration.

* Kalliguddi, Hema hem...@ti.com [100628 16:26]:
  
 
 -Original Message-
 From: Tony Lindgren [mailto:t...@atomide.com] 
 Sent: Monday, June 28, 2010 6:59 PM
 To: Kalliguddi, Hema
 Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; 
Felipe Balbi
 Subject: Re: [PATCH 4/4]usb : musb:USB driver using 
 omap_device_build for device registration.
 
 * Hema HK hem...@ti.com [100628 15:12]:
  -
  -/*
  - * REVISIT: This line can be removed once all the 
 platforms using
  - * musb_core.c have been converted to use use clkdev.
  - */
  -musb_plat.clock = ick;
 
 This comment is still valid, please don't remove it.
 This is still there. It is moved below under else.

Yes. The comment is being removed in the patch I posted. I will keep it.
Regards,
Hema
Tony
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html