Re: [PATCH 5/5] ARM: dts: AM33XX: Add default pinctrl binding for UART0 device

[Matt Porter]

On Wed, Mar 27, 2013 at 12:59:16PM +, Vaibhav Hiremath wrote:
> Add pin control binding for UART0 device nodes in all
> board specific DT files.
> 
> Signed-off-by: Vaibhav Hiremath 
> Cc: Benoit Cousson 

Except for trivial comments below I'll add my

Acked-by: Matt Porter 

> ---
>  arch/arm/boot/dts/am335x-bone.dts  |   10 ++
>  arch/arm/boot/dts/am335x-evm.dts   |   10 ++
>  arch/arm/boot/dts/am335x-evmsk.dts |   10 ++
>  3 files changed, 30 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-bone.dts 
> b/arch/arm/boot/dts/am335x-bone.dts
> index 1d623e4..3c4c66f 100644
> --- a/arch/arm/boot/dts/am335x-bone.dts
> +++ b/arch/arm/boot/dts/am335x-bone.dts
> @@ -43,10 +43,20 @@
>   0x18c 0x30  /* i2c0_scl.i2c0_scl PULLUP | 
> INPUTENABLE | MODE0 */
>   >;
>   };
> +
> + uart0_pins: pinmux_uart0_pins {
> + pinctrl-single,pins = <
> + 0x170 0x30  /* uart0_rxd.uart0_rxd PULLUP | 
> INPUTENABLE | MODE0 */
> + 0x174 0x00  /* uart0_txd.uart0_txd PULLDOWN 
> | MODE0 */
> + >;
> + };
>   };
>  
>   ocp {
>   uart1: serial@44e09000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0_pins>;
> +

Please change this to be uart0 so it all matches.

>   status = "okay";
>   };
>  
> diff --git a/arch/arm/boot/dts/am335x-evm.dts 
> b/arch/arm/boot/dts/am335x-evm.dts
> index 79b3cc8..89e1edd 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -58,10 +58,20 @@
>   0x15c 0x32  /* spi0_cs0.i2c1_scl PULLUP | 
> INPUTENABLE | MODE2 */
>   >;
>   };
> +
> + uart0_pins: pinmux_uart0_pins {
> + pinctrl-single,pins = <
> + 0x170 0x30  /* uart0_rxd.uart0_rxd PULLUP | 
> INPUTENABLE | MODE0 */
> + 0x174 0x00  /* uart0_txd.uart0_txd PULLDOWN 
> | MODE0 */
> + >;
> + };
>   };
>  
>   ocp {
>   uart1: serial@44e09000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0_pins>;
> +

Also here.

>   status = "okay";
>   };
>  
> diff --git a/arch/arm/boot/dts/am335x-evmsk.dts 
> b/arch/arm/boot/dts/am335x-evmsk.dts
> index 21d5a08..0e7f1b8 100644
> --- a/arch/arm/boot/dts/am335x-evmsk.dts
> +++ b/arch/arm/boot/dts/am335x-evmsk.dts
> @@ -58,10 +58,20 @@
>   0x18c 0x30  /* i2c0_scl.i2c0_scl PULLUP | 
> INPUTENABLE | MODE0 */
>   >;
>   };
> +
> + uart0_pins: pinmux_uart0_pins {
> + pinctrl-single,pins = <
> + 0x170 0x30  /* uart0_rxd.uart0_rxd PULLUP | 
> INPUTENABLE | MODE0 */
> + 0x174 0x00  /* uart0_txd.uart0_txd PULLDOWN 
> | MODE0 */
> + >;
> + };
>   };
>  
>   ocp {
>   uart1: serial@44e09000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0_pins>;
> +
>   status = "okay";
>   };

And here.

-Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 5/5] ARM: dts: AM33XX: Add default pinctrl binding for UART0 device

[Hiremath, Vaibhav]

> -Original Message-
> From: Matt Porter [mailto:ohio...@gmail.com] On Behalf Of Porter, Matt
> Sent: Wednesday, March 27, 2013 7:03 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> Cousson, Benoit; devicetree-disc...@lists.ozlabs.org
> Subject: Re: [PATCH 5/5] ARM: dts: AM33XX: Add default pinctrl binding
> for UART0 device
> 
> On Wed, Mar 27, 2013 at 12:59:16PM +, Vaibhav Hiremath wrote:
> > Add pin control binding for UART0 device nodes in all
> > board specific DT files.
> >
> > Signed-off-by: Vaibhav Hiremath 
> > Cc: Benoit Cousson 
> 
> Except for trivial comments below I'll add my
> 
> Acked-by: Matt Porter 
> 
> > ---
> >  arch/arm/boot/dts/am335x-bone.dts  |   10 ++
> >  arch/arm/boot/dts/am335x-evm.dts   |   10 ++
> >  arch/arm/boot/dts/am335x-evmsk.dts |   10 ++
> >  3 files changed, 30 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/am335x-bone.dts
> b/arch/arm/boot/dts/am335x-bone.dts
> > index 1d623e4..3c4c66f 100644
> > --- a/arch/arm/boot/dts/am335x-bone.dts
> > +++ b/arch/arm/boot/dts/am335x-bone.dts
> > @@ -43,10 +43,20 @@
> > 0x18c 0x30  /* i2c0_scl.i2c0_scl PULLUP |
> INPUTENABLE | MODE0 */
> > >;
> > };
> > +
> > +   uart0_pins: pinmux_uart0_pins {
> > +   pinctrl-single,pins = <
> > +   0x170 0x30  /* uart0_rxd.uart0_rxd PULLUP |
> INPUTENABLE | MODE0 */
> > +   0x174 0x00  /* uart0_txd.uart0_txd PULLDOWN 
> > |
> MODE0 */
> > +   >;
> > +   };
> > };
> >
> > ocp {
> > uart1: serial@44e09000 {
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <&uart0_pins>;
> > +
> 
> Please change this to be uart0 so it all matches.
> 
Yes, you are right, this also can be changed now.
I tested it with changed uart numbering and it is working.

I didn’t touch uart, as I recall earlier discussion of
Having 1-based uart numbering and also it is being documented
In DT for hwmod -

ti,hwmods : Must be "uart", n being the instance number (1-based)


I will change it and submit the next version with your acked-by.

Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html