RE: [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes

[Gupta, Pekon]

Hi Tony,

> From: Tony Lindgren
> > * Brian Norris  [131029 21:00]:
> > Tony, you mentioned the DTS update in patch 8 going in via an ARM
> > tree? This patch is not urgent, and it should probably wait until we
> > know what release the rest of the series makes it into. This may
> > depend on David Woodhouse's recommendation, but I'm not sure this
> > series will have enough time baking in linux-next before entering
> > mainline in 3.13 (the merge window is approaching).
> 
> Yes Benoit or I can apply that patch if Pekon pings me or resends
> that patch when it's OK to merge it.
> 
Yes, I'll keep track of this and would resend you and Benoit the .dts patch
separately when this these binding updates are merged in kernel.

with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes

[Tony Lindgren]

* Brian Norris  [131029 21:00]:
> 
> Tony, you mentioned the DTS update in patch 8 going in via an ARM
> tree? This patch is not urgent, and it should probably wait until we
> know what release the rest of the series makes it into. This may
> depend on David Woodhouse's recommendation, but I'm not sure this
> series will have enough time baking in linux-next before entering
> mainline in 3.13 (the merge window is approaching).

Yes Benoit or I can apply that patch if Pekon pings me or resends
that patch when it's OK to merge it.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes

[Gupta, Pekon]

> From: Brian Norris [mailto:computersforpe...@gmail.com]
[...]

> I agree with Ezequiel's thoughts, since the excessive amount of noise
> in this patch series has delayed it significantly. But at this point,
> I think it has stabilized; we have reviews from the DT folks (thanks
> guys; please comment if you have an official "ack" to give), and I
> think we've retained backwards compatibility properly; I've combed
> through it a few times over the months; we have a third-party tester;
> and at this point, I'm sure we're all sick of this.
> 
> So, without further delay: pushed all patches except path 8 to l2-mtd.git.
> 
Thanks much ..
I'll ensure that my next series are more logically aligned.


> Tony, you mentioned the DTS update in patch 8 going in via an ARM
> tree? This patch is not urgent, and it should probably wait until we
> know what release the rest of the series makes it into. This may
> depend on David Woodhouse's recommendation, but I'm not sure this
> series will have enough time baking in linux-next before entering
> mainline in 3.13 (the merge window is approaching).
> 
> Pekon/Ezequiel/others: please feel free to send any follow up cleanups
> for this driver. I'll take a look at what Ezequiel has already sent
> out and see if it's still applicable on top.
> 
Yes, I have other pending series, which I'll resend after rebasing on
this v11. But those are limited to internal NAND driver clean-up only
And do not touch DT or any other dependent driver.


with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes

[Ezequiel Garcia]

On Tue, Oct 29, 2013 at 11:59:57PM -0400, Brian Norris wrote:
> 
> Pekon/Ezequiel/others: please feel free to send any follow up cleanups
> for this driver. I'll take a look at what Ezequiel has already sent
> out and see if it's still applicable on top.
> 

They won't. I'll prepare a new patch in top of latest l2-mtd.

It's good to see this DT discussion finally coming to an end! Good job!
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes

[Brian Norris]

On Thu, Oct 24, 2013 at 9:52 AM, Ezequiel Garcia
 wrote:
> Just as suggestion, I think you should reconsider your 'upstream strategy'.
>
> On Thu, Oct 24, 2013 at 06:20:16PM +0530, Pekon Gupta wrote:
> [..]
>>
>> Pekon Gupta (10):
>>   ARM: OMAP2+: cleaned-up DT support of various ECC schemes
>>   mtd: nand: omap: combine different flavours of 1-bit hamming ecc schemes
>>   mtd: nand: omap: cleanup: replace local references with generic framework 
>> names
>
> IMHO, this patch about the dobule nand_scan_ident():
>>   mtd: nand: omap: use DT specified bus-width only for scanning NAND device
>
> is a fix unrelated to this series and can be pushed independently.
> Maybe you can try to send it as a one-patch fix?
>
>>   mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in 
>> device_probe
>>   mtd: nand: omap: clean-up ecc layout for BCH ecc schemes
>>   mtd: nand: omap: use drivers/mtd/nand/nand_bch.c wrapper for BCH ECC 
>> instead of lib/bch.c
>>   ARM: dts: AM33xx: updated default ECC scheme in nand-ecc-opt
>
> And also this patch:
>>   mtd: nand: omap: updated devm_xx for all resource allocation and free calls
>
> doesn't seem to belong to this series.
>
> I think tou could send those two independently and ask Brian to merge them 
> earlier
> if appropriate.
>
> But again, this is just a suggestion.

I agree with Ezequiel's thoughts, since the excessive amount of noise
in this patch series has delayed it significantly. But at this point,
I think it has stabilized; we have reviews from the DT folks (thanks
guys; please comment if you have an official "ack" to give), and I
think we've retained backwards compatibility properly; I've combed
through it a few times over the months; we have a third-party tester;
and at this point, I'm sure we're all sick of this.

So, without further delay: pushed all patches except path 8 to l2-mtd.git.

Tony, you mentioned the DTS update in patch 8 going in via an ARM
tree? This patch is not urgent, and it should probably wait until we
know what release the rest of the series makes it into. This may
depend on David Woodhouse's recommendation, but I'm not sure this
series will have enough time baking in linux-next before entering
mainline in 3.13 (the merge window is approaching).

Pekon/Ezequiel/others: please feel free to send any follow up cleanups
for this driver. I'll take a look at what Ezequiel has already sent
out and see if it's still applicable on top.

Thanks,
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes

[Ezequiel Garcia]

Pekon,

On Thu, Oct 24, 2013 at 06:20:16PM +0530, Pekon Gupta wrote:
> *changes v10 -> v11*
> - [PATCH v10 04/10] replaced with newer [PATCH v11 04/11] so that
>   nand_scan_ident() is called only once.
>   discussion thread with Brian Norris 
>   
> - No change in any other patch
> 
> 
> *changes v9 -> v10*
> [PATCH 1/10], [PATCH 2/10]
>   swapped [PATCH v9 1/9] and [PATCH v9 2/9] so that DT parsing updates
>   (with backward compatibility) happen before the deprecation of DT values.
>   This way DTB does not break functionally between the patches.
> [PATCH 3/10] 
> [PATCH 4/10] 
>   dropped [PATCH v9 4/9] introducing NAND_BUSWIDTH_AUTO, instead
>   using DT 'nand-bus-width' for device bus-width. Refer discussion thread 
>   
> [PATCH 5/10] 
> [PATCH 6/10] 
> [PATCH 7/10] 
>   separated out drivers/mtd/nand/Kconfig updates into separate [PATCH v10 
> 10/10]
>   cleanup: s/info->nand\./nand_chip->
> [PATCH 8/10] 
> [PATCH 9/10] cleanup: s/out_release_mem_region/return_error
> [PATCH 10/10]  spawned from [PATCH v9 8/9] for Kconfig updates
> 
> 
> *changes v8 -> v9*
> [PATCH 1/9] 
> [PATCH 2/9] 
>  As per feedbacks from Brian Norris  previous
>  revision [PATCH v8 3/6] and [PATCH 4/6] are split into following sub-patches:
> - [PATCH 3/9]  replaces local reference with generic names (mtd, 
> nand_chip)
> - [PATCH 4/9]  enables auto-detection of bus-width
> - [PATCH 5/9]  removes omap3_init_bch: populates ecc-scheme data
> - [PATCH 6/9]  removes omap3_init_bch_tail: populates ecc-layout
> - [PATCH 7/9]  replaces lib/bch.c with nand_bch.c wrapper
> [PATCH 8/9]  [PATCH 9/9] removed devm_free_xx functions
> 
> 
> *Changes v7 -> v8*
> [PATCH 1/6] 
> [PATCH 2/6]
>   - updated DT parsing of "ti,nand-ecc-opts" so that its "ham1" remains
>   compatible to "sw","hw","hw-romcode"
>   - updated DT parsing of "ti,elm-id" to retain compatibility to "elm_id"
>   - using of_parse_phandle() to get ELM device pointer from DT
> [PATCH 3..6/6] 
> 
> 
> *Changes v6 -> v7*
> [PATCH 1/6]  split from [PATCH v6 2/4] as per feedbacks from Brian 
> Norris 
> [PATCH 2/6] incorporated feedbacks from DT maintainers
> [PATCH 3/6] cleaned and incorporated feedbacks from Brian Norris 
> 
> [PATCH 4/6] rebasing changes and cleanup
> [PATCH 5/6] updated omap3430-sdp.dts
> [PATCH 6/6]  updated for devm_xx
> 
> 
> *Changes v5 -> v6*
> [PATCH 1/4]: 
>   - updated DT binding for gpmc-nand based on 'Olof Johansson's feedbacks
>   http://lists.infradead.org/pipermail/linux-mtd/2013-August/048394.html
>   - detection of ELM device via ti,elm-id DT node, moved to gpmc.c driver
> [PATCH 2/4]
>   - removed: support for following obselete ECC schemes
>   OMAP_ECC_HAMMING_CODE_DEFAULT (S/W based 1-bit Hamming ECC)
>   OMAP_ECC_HAMMING_CODE_HW_ROMCODE (H/W based 1-bit Hamming ECC scheme)
>   - updated: using omap_oobinfo as chip->ecc.layout for all ecc-schemes
>   - clean: error messages
> [PATCH 3/4] cleaned to include changes for OMAP_ECC_BCH8_CODE_HW only
> [PATCH 4/4] updated to include DT property changes
> 
> 
> *Changes v4 -> v5*
> - Rebased to linux-next 
> IMPORTANT: Need to revert commit fb1585b, [PATCH 2/4] part of previous version
>   http://lists.infradead.org/pipermail/linux-mtd/2013-July/047441.html
> 
> - Swapped PATCH-1 & PATCH-2 to maintain bisectibility & compilation dependency
>   http://lists.infradead.org/pipermail/linux-mtd/2013-July/047461.html
> 
> - PATCH-2: re-ordered call to is_elm_present() for later updates ELM driver
>   - dropped changes in include/linux/platform_data/elm.h (not needed)
> - PATCH-3: re-ordered call to is_elm_present() for later updates ELM driver
> - Re-formated patch description (replaced tabs with white-spaces)
> 
> 
> *Changes v3 -> v4*
> (Resent with CC: devicetree-disc...@lists.ozlabs.org)
> - [Patch 1/3] removed MTD_NAND_OMAP_BCH8 & MTD_NAND_OMAP_BCH4 from 
> nand/Kconfig
>   ECC scheme selectable via nand DT (nand-ecc-opt).
> - [*] rebased for l2-mtd.git
> 
> 
> *Changes v2 -> v3*
> (Resent with Author Name fixed)
> - PATCH-1: re-arranged code to remove redundancy, added NAND_BUSWIDTH_AUTO
> - PATCH-2: updated nand-ecc-opt DT mapping and Documentation
> - PATCH-3: code-cleaning + changes to match PATCH-1
> - PATCH-4  update DT attribute for ti,nand-ecc-opt 
>   - received feedback to keep DT mapping independent of linuxism
> - PATCH-4: : ARM: dts: AM33xx: updated default ECC scheme in nand-ecc-opt
>   - independent patch for AM335x-evm.dts update based on PATCH-2
> 
> 
> *Changes v1 -> v2*
>   added   [PATCH 3/4] and [PATCH 4/4]
> 
> 
> After this patch series, omap2-nand driver will supports following ECC 
> schemes:
> +---+---+---+
> | ECC scheme|ECC calculation|Error detection|
> +-

Re: [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes

[Ezequiel Garcia]

Hi Pekon,

Just as suggestion, I think you should reconsider your 'upstream strategy'.

On Thu, Oct 24, 2013 at 06:20:16PM +0530, Pekon Gupta wrote:
[..]
> 
> Pekon Gupta (10):
>   ARM: OMAP2+: cleaned-up DT support of various ECC schemes
>   mtd: nand: omap: combine different flavours of 1-bit hamming ecc schemes
>   mtd: nand: omap: cleanup: replace local references with generic framework 
> names

IMHO, this patch about the dobule nand_scan_ident():
>   mtd: nand: omap: use DT specified bus-width only for scanning NAND device

is a fix unrelated to this series and can be pushed independently.
Maybe you can try to send it as a one-patch fix?

>   mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in 
> device_probe
>   mtd: nand: omap: clean-up ecc layout for BCH ecc schemes
>   mtd: nand: omap: use drivers/mtd/nand/nand_bch.c wrapper for BCH ECC 
> instead of lib/bch.c
>   ARM: dts: AM33xx: updated default ECC scheme in nand-ecc-opt

And also this patch:
>   mtd: nand: omap: updated devm_xx for all resource allocation and free calls

doesn't seem to belong to this series.

I think tou could send those two independently and ask Brian to merge them 
earlier
if appropriate.

But again, this is just a suggestion.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html