Re: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
On Wed, Apr 20, 2011 at 10:56:51AM +, kalle.jokini...@nokia.com wrote: > > Thanks for the ack. Now can we get this patch set in? Anton are you reading > > this? > > Let's try another mail address for Anton... Sorry for the delay, folks. The two patches are now applied. Much thanks for your work! -- Anton Vorontsov Email: cbouatmai...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of ext kalle.jokini...@nokia.com > Sent: 20. huhtikuuta 2011 13:38 > To: t...@atomide.com; Krogerus Heikki (Nokia-SD/Helsinki); > cbouatmai...@gmail.com > Cc: linux-...@vger.kernel.org; ba...@ti.com; sshtyl...@mvista.com; > khil...@ti.com; linux-omap@vger.kernel.org; jhnik...@gmail.com > Subject: RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off > > Thanks for the ack. Now can we get this patch set in? Anton are you reading > this? Let's try another mail address for Anton... - Kalle > > If you need refreshed set, I can do that. > > - Kalle > > > -Original Message- > > From: ext Tony Lindgren [mailto:t...@atomide.com] > > Sent: 13. huhtikuuta 2011 9:29 > > To: Krogerus Heikki (Nokia-SD/Helsinki) > > Cc: Jokiniemi Kalle (Nokia-SD/Tampere); linux-...@vger.kernel.org; > > cbouatmai...@gmail.com; ba...@ti.com; sshtyl...@mvista.com; > > khil...@ti.com; linux-omap@vger.kernel.org; jhnik...@gmail.com > > Subject: Re: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off > > > > * Heikki Krogerus [110413 08:07]: > > > Hi, > > > > > > On Wed, Mar 30, 2011 at 08:08:54AM +0300, ext Heikki Krogerus wrote: > > > > On Tue, Mar 29, 2011 at 04:28:00PM +0300, Kalle Jokiniemi wrote: > > > > > The isp1704 usb tranceiver is used for charging and can be > > > > > disabled when not in use. Provide the powering routine to > > > > > the driver via platform data. > > > > > > > > > > Also changed the indent of ".name" variable in rx51_charger_device > > > > > definition to use tabs same way as the new ".dev" variable indent. > > > > > Put this in the same patch since the indent fix is only needed > > > > > when there are multiple members in the struct definition. > > > > > > > > > > Loosely based on earlier patches from Heikki Krogerus in > > > > > Nokia N900 maemo kernel. > > > > > > > > > > Signed-off-by: Kalle Jokiniemi > > > > > Cc: Heikki Krogerus > > > > > > > > Acked-By: Heikki Krogerus > > > > > > Before Anton takes these, this one needs ack from Tony. > > > > Looks good to me: > > > > Acked-by: Tony Lindgren > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
Thanks for the ack. Now can we get this patch set in? Anton are you reading this? If you need refreshed set, I can do that. - Kalle > -Original Message- > From: ext Tony Lindgren [mailto:t...@atomide.com] > Sent: 13. huhtikuuta 2011 9:29 > To: Krogerus Heikki (Nokia-SD/Helsinki) > Cc: Jokiniemi Kalle (Nokia-SD/Tampere); linux-...@vger.kernel.org; > cbouatmai...@gmail.com; ba...@ti.com; sshtyl...@mvista.com; > khil...@ti.com; linux-omap@vger.kernel.org; jhnik...@gmail.com > Subject: Re: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off > > * Heikki Krogerus [110413 08:07]: > > Hi, > > > > On Wed, Mar 30, 2011 at 08:08:54AM +0300, ext Heikki Krogerus wrote: > > > On Tue, Mar 29, 2011 at 04:28:00PM +0300, Kalle Jokiniemi wrote: > > > > The isp1704 usb tranceiver is used for charging and can be > > > > disabled when not in use. Provide the powering routine to > > > > the driver via platform data. > > > > > > > > Also changed the indent of ".name" variable in rx51_charger_device > > > > definition to use tabs same way as the new ".dev" variable indent. > > > > Put this in the same patch since the indent fix is only needed > > > > when there are multiple members in the struct definition. > > > > > > > > Loosely based on earlier patches from Heikki Krogerus in > > > > Nokia N900 maemo kernel. > > > > > > > > Signed-off-by: Kalle Jokiniemi > > > > Cc: Heikki Krogerus > > > > > > Acked-By: Heikki Krogerus > > > > Before Anton takes these, this one needs ack from Tony. > > Looks good to me: > > Acked-by: Tony Lindgren -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
* Heikki Krogerus [110413 08:07]: > Hi, > > On Wed, Mar 30, 2011 at 08:08:54AM +0300, ext Heikki Krogerus wrote: > > On Tue, Mar 29, 2011 at 04:28:00PM +0300, Kalle Jokiniemi wrote: > > > The isp1704 usb tranceiver is used for charging and can be > > > disabled when not in use. Provide the powering routine to > > > the driver via platform data. > > > > > > Also changed the indent of ".name" variable in rx51_charger_device > > > definition to use tabs same way as the new ".dev" variable indent. > > > Put this in the same patch since the indent fix is only needed > > > when there are multiple members in the struct definition. > > > > > > Loosely based on earlier patches from Heikki Krogerus in > > > Nokia N900 maemo kernel. > > > > > > Signed-off-by: Kalle Jokiniemi > > > Cc: Heikki Krogerus > > > > Acked-By: Heikki Krogerus > > Before Anton takes these, this one needs ack from Tony. Looks good to me: Acked-by: Tony Lindgren -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
Hi, On Wed, Mar 30, 2011 at 08:08:54AM +0300, ext Heikki Krogerus wrote: > On Tue, Mar 29, 2011 at 04:28:00PM +0300, Kalle Jokiniemi wrote: > > The isp1704 usb tranceiver is used for charging and can be > > disabled when not in use. Provide the powering routine to > > the driver via platform data. > > > > Also changed the indent of ".name" variable in rx51_charger_device > > definition to use tabs same way as the new ".dev" variable indent. > > Put this in the same patch since the indent fix is only needed > > when there are multiple members in the struct definition. > > > > Loosely based on earlier patches from Heikki Krogerus in > > Nokia N900 maemo kernel. > > > > Signed-off-by: Kalle Jokiniemi > > Cc: Heikki Krogerus > > Acked-By: Heikki Krogerus Before Anton takes these, this one needs ack from Tony. -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
Hi,
> -Original Message-
> From: ext Keshava Munegowda [mailto:keshava_mgo...@ti.com]
> > > > +
> > > > static struct platform_device rx51_charger_device = {
> > > > - .name = "isp1704_charger",
> > ^space here
> >
> >
> >
> > > > + .name = "isp1704_charger",
> > ^tab here
> > >
> > > I don't understand what difference between above two lines?
> > > Is your mail client causing this? Or get send-mail doing this?
> >
> > No, changed space for tab so that all the members are indented same way.
> > I had that (apparently obscure) explanation about this in the commit log
> ;)
>
> Then, I am sorry; I couldn't able to notice this!
No problem, you're not the first one to point that out :)
- Kalle
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
> -Original Message-
> From: kalle.jokini...@nokia.com [mailto:kalle.jokini...@nokia.com]
> Sent: Wednesday, March 30, 2011 12:12 PM
> To: keshava_mgo...@ti.com; linux-...@vger.kernel.org;
cbouatmai...@gmail.com
> Cc: ba...@ti.com; heikki.kroge...@nokia.com; sshtyl...@mvista.com;
t...@atomide.com; khil...@ti.com;
> linux-omap@vger.kernel.org; jhnik...@gmail.com
> Subject: RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
>
> Hi,
>
> > -Original Message-
> > From: ext Keshava Munegowda [mailto:keshava_mgo...@ti.com]
> > Sent: 30. maaliskuuta 2011 9:39
> > To: Jokiniemi Kalle (Nokia-MS/Tampere); linux-...@vger.kernel.org;
> > cbouatmai...@gmail.com
> > Cc: Felipe Balbi; Krogerus Heikki (Nokia-MS/Helsinki);
sshtyl...@mvista.com;
> > t...@atomide.com; Kevin Hilman; linux-omap@vger.kernel.org;
> > jhnik...@gmail.com
> > Subject: RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
> >
> > > +
> > > static struct platform_device rx51_charger_device = {
> > > -.name = "isp1704_charger",
> ^space here
>
>
>
> > > +.name = "isp1704_charger",
> ^tab here
> >
> > I don't understand what difference between above two lines?
> > Is your mail client causing this? Or get send-mail doing this?
>
> No, changed space for tab so that all the members are indented same way.
> I had that (apparently obscure) explanation about this in the commit log
;)
Then, I am sorry; I couldn't able to notice this!
>
> >
> >
> > > +.dev= {
> ^tab here also
>
> > > +.platform_data = &rx51_charger_data,
> > > +},
> > > };
> > >
> > > +static void __init rx51_charger_init(void)
> > > +{
> > > +WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
> > > +GPIOF_OUT_INIT_LOW, "isp1704_reset"));
> > > +
> > > +platform_device_register(&rx51_charger_device);
> > > +}
> > > +
> > > #if defined(CONFIG_KEYBOARD_GPIO) ||
> > defined(CONFIG_KEYBOARD_GPIO_MODULE)
> > >
> > > #define RX51_GPIO_CAMERA_LENS_COVER 110
> > > @@ -981,6 +1004,6 @@ void __init rx51_peripherals_init(void)
> > > if (partition)
> > > omap2_hsmmc_init(mmc);
> > >
> > > -platform_device_register(&rx51_charger_device);
> > > +rx51_charger_init();
> > > }
> > >
> > > --
> > > 1.7.1
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe
linux-usb" in
> > > the body of a message to majord...@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
Hi,
> -Original Message-
> From: ext Keshava Munegowda [mailto:keshava_mgo...@ti.com]
> Sent: 30. maaliskuuta 2011 9:39
> To: Jokiniemi Kalle (Nokia-MS/Tampere); linux-...@vger.kernel.org;
> cbouatmai...@gmail.com
> Cc: Felipe Balbi; Krogerus Heikki (Nokia-MS/Helsinki); sshtyl...@mvista.com;
> t...@atomide.com; Kevin Hilman; linux-omap@vger.kernel.org;
> jhnik...@gmail.com
> Subject: RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
>
> > +
> > static struct platform_device rx51_charger_device = {
> > - .name = "isp1704_charger",
^space here
> > + .name = "isp1704_charger",
^tab here
>
> I don't understand what difference between above two lines?
> Is your mail client causing this? Or get send-mail doing this?
No, changed space for tab so that all the members are indented same way.
I had that (apparently obscure) explanation about this in the commit log ;)
>
>
> > + .dev= {
^tab here also
> > + .platform_data = &rx51_charger_data,
> > + },
> > };
> >
> > +static void __init rx51_charger_init(void)
> > +{
> > + WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
> > + GPIOF_OUT_INIT_LOW, "isp1704_reset"));
> > +
> > + platform_device_register(&rx51_charger_device);
> > +}
> > +
> > #if defined(CONFIG_KEYBOARD_GPIO) ||
> defined(CONFIG_KEYBOARD_GPIO_MODULE)
> >
> > #define RX51_GPIO_CAMERA_LENS_COVER 110
> > @@ -981,6 +1004,6 @@ void __init rx51_peripherals_init(void)
> >if (partition)
> >omap2_hsmmc_init(mmc);
> >
> > - platform_device_register(&rx51_charger_device);
> > + rx51_charger_init();
> > }
> >
> > --
> > 1.7.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> > the body of a message to majord...@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
> +
> static struct platform_device rx51_charger_device = {
> - .name = "isp1704_charger",
> + .name = "isp1704_charger",
I don’t understand what difference between above two lines?
Is your mail client causing this? Or get send-mail doing this?
> + .dev= {
> + .platform_data = &rx51_charger_data,
> + },
> };
>
> +static void __init rx51_charger_init(void)
> +{
> + WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
> + GPIOF_OUT_INIT_LOW, "isp1704_reset"));
> +
> + platform_device_register(&rx51_charger_device);
> +}
> +
> #if defined(CONFIG_KEYBOARD_GPIO) ||
defined(CONFIG_KEYBOARD_GPIO_MODULE)
>
> #define RX51_GPIO_CAMERA_LENS_COVER 110
> @@ -981,6 +1004,6 @@ void __init rx51_peripherals_init(void)
> if (partition)
> omap2_hsmmc_init(mmc);
>
> - platform_device_register(&rx51_charger_device);
> + rx51_charger_init();
> }
>
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
On Tue, Mar 29, 2011 at 04:28:00PM +0300, Kalle Jokiniemi wrote: > The isp1704 usb tranceiver is used for charging and can be > disabled when not in use. Provide the powering routine to > the driver via platform data. > > Also changed the indent of ".name" variable in rx51_charger_device > definition to use tabs same way as the new ".dev" variable indent. > Put this in the same patch since the indent fix is only needed > when there are multiple members in the struct definition. > > Loosely based on earlier patches from Heikki Krogerus in > Nokia N900 maemo kernel. > > Signed-off-by: Kalle Jokiniemi > Cc: Heikki Krogerus Acked-By: Heikki Krogerus -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
