RE: [PATCH v4 1/3] ARM: OMAP2+: nand: unify init functions

2012-06-26 Thread Mohammed, Afzal
Hi Jon,

On Mon, Jun 25, 2012 at 20:59:57, Hunter, Jon wrote:
> On 06/22/2012 04:00 AM, Afzal Mohammed wrote:
> > Helper function for updating nand platform data has been
> > added the capability to take timing structure arguement.
> > Usage of omap_nand_flash_init() has been replaced by modifed
> > one, omap_nand_flash_init was doing things similar to
> > board_nand_init except that NAND CS# were being acquired
> > based on bootloader setting. As CS# is hardwired for a given
> > board, acquiring gpmc CS# has been removed, and updated with
> > the value on board.
> > 
> > NAND CS# used in beagle board was found to be CS0.
> > Thomas Weber  reported
> > that value of devkit8000 to be CS0. Overo board was found
> > to be using CS0 based on u-boot, while google grep says
> > omap3touchbook too has CS0.

> Reviewed-by: Jon Hunter 

Thanks,
Afzal
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v4 1/3] ARM: OMAP2+: nand: unify init functions

2012-06-25 Thread Jon Hunter


On 06/22/2012 04:00 AM, Afzal Mohammed wrote:
> Helper function for updating nand platform data has been
> added the capability to take timing structure arguement.
> Usage of omap_nand_flash_init() has been replaced by modifed
> one, omap_nand_flash_init was doing things similar to
> board_nand_init except that NAND CS# were being acquired
> based on bootloader setting. As CS# is hardwired for a given
> board, acquiring gpmc CS# has been removed, and updated with
> the value on board.
> 
> NAND CS# used in beagle board was found to be CS0.
> Thomas Weber  reported
> that value of devkit8000 to be CS0. Overo board was found
> to be using CS0 based on u-boot, while google grep says
> omap3touchbook too has CS0.
> 
> Signed-off-by: Afzal Mohammed 

Looks good.

Reviewed-by: Jon Hunter 

Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html