RE: [PATCH v4 4/4] OMAP3: DMA: Errata i541: sDMA FIFO draining does not finish
-Original Message- From: Peter Ujfalusi [mailto:peter.ujfal...@nokia.com] Sent: Monday, October 04, 2010 4:13 PM To: G, Manjunath Kondaiah Cc: Tony Lindgren; linux-omap@vger.kernel.org; Jarkko Nikula; linux-arm-ker...@lists.infradead.org Subject: Re: [PATCH v4 4/4] OMAP3: DMA: Errata i541: sDMA FIFO draining does not finish On Monday 04 October 2010 12:17:41 ext G, Manjunath Kondaiah wrote: ... + /* OMAP3 Errata i541: sDMA FIFO draining does not finish */ This logic is required for multiple erratas. As Tony requested, I have added a variable for flags to handle the different erratas. I even added a macro to check that the errata applies, so one can use: if (IS_DMA_ERRATA(DMA_ERRATA_X)) Can we have seperate function for handling this logic. More details at: https://patchwork.kernel.org/patch/126271/ I see. That patch is for hwmod converted dma code, right? We need this fix without the hwmod to applied, and than backport it to earlier kernel releases. As I mentioned in other mail, if you are introducing this feature, it is better to convert existing erratas also to use this feature. The upcoming hwmod conversion will take care of the cleanup. If this is the case, not sure about intention of having dma_errata only for these two erratas since all the erratas are not handled. All the erratas will get cleaned up and errata handling feature will be introduced along with dma hwmod changes. If feel v3 version is better so that I can use these changes along dma hwmod. It is upto Tony to decide. We _need_ these two small fixes ASAP, since it is fixing serious problem in audio (and the same issue might bite other areas as well). It is not the intention of this series to clean up the arc/arm/plat-omap/dma.c. Tony, How about having v3 series + review comments fixed(except comments related errata handling). Errata handling will be done as part dma hwmod. I am waiting for these patches so that I can rebase these patches in DMA hwmod. -Manjunath-- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 4/4] OMAP3: DMA: Errata i541: sDMA FIFO draining does not finish
On Monday 04 October 2010 12:17:41 ext G, Manjunath Kondaiah wrote: ... + /* OMAP3 Errata i541: sDMA FIFO draining does not finish */ This logic is required for multiple erratas. As Tony requested, I have added a variable for flags to handle the different erratas. I even added a macro to check that the errata applies, so one can use: if (IS_DMA_ERRATA(DMA_ERRATA_X)) Can we have seperate function for handling this logic. More details at: https://patchwork.kernel.org/patch/126271/ I see. That patch is for hwmod converted dma code, right? We need this fix without the hwmod to applied, and than backport it to earlier kernel releases. As I mentioned in other mail, if you are introducing this feature, it is better to convert existing erratas also to use this feature. The upcoming hwmod conversion will take care of the cleanup. We _need_ these two small fixes ASAP, since it is fixing serious problem in audio (and the same issue might bite other areas as well). It is not the intention of this series to clean up the arc/arm/plat-omap/dma.c. I have added the dma_errata variable, since Tony asked for it, but even that addition is a bigger change than what I was planning to do here. -- Péter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v4 4/4] OMAP3: DMA: Errata i541: sDMA FIFO draining does not finish
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Peter Ujfalusi Sent: Monday, October 04, 2010 1:48 PM To: Tony Lindgren Cc: linux-omap@vger.kernel.org; Jarkko Nikula; linux-arm-ker...@lists.infradead.org Subject: [PATCH v4 4/4] OMAP3: DMA: Errata i541: sDMA FIFO draining does not finish ... + /* OMAP3 Errata i541: sDMA FIFO draining does not finish */ This logic is required for multiple erratas. Can we have seperate function for handling this logic. More details at: https://patchwork.kernel.org/patch/126271/ ... --- a/arch/arm/plat-omap/include/plat/dma.h +++ b/arch/arm/plat-omap/include/plat/dma.h @@ -335,6 +335,9 @@ #define OMAP2_DMA_MISALIGNED_ERR_IRQ (1 11) #define OMAP_DMA_CCR_EN (1 7) +#define OMAP_DMA_CCR_RD_ACTIVE (1 9) +#define OMAP_DMA_CCR_WR_ACTIVE (1 10) +#define OMAP_DMA_CCR_SEL_SRC_DST_SYNC(1 24) #define OMAP_DMA_CCR_BUFFERING_DISABLE (1 25) As I mentioned in other mail, if you are introducing this feature, it is better to convert existing erratas also to use this feature. -Manjunath-- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 4/4] OMAP3: DMA: Errata i541: sDMA FIFO draining does not finish
* Peter Ujfalusi peter.ujfal...@nokia.com [101004 03:33]: On Monday 04 October 2010 12:17:41 ext G, Manjunath Kondaiah wrote: ... + /* OMAP3 Errata i541: sDMA FIFO draining does not finish */ This logic is required for multiple erratas. As Tony requested, I have added a variable for flags to handle the different erratas. I even added a macro to check that the errata applies, so one can use: if (IS_DMA_ERRATA(DMA_ERRATA_X)) Can we have seperate function for handling this logic. More details at: https://patchwork.kernel.org/patch/126271/ I see. That patch is for hwmod converted dma code, right? We need this fix without the hwmod to applied, and than backport it to earlier kernel releases. As I mentioned in other mail, if you are introducing this feature, it is better to convert existing erratas also to use this feature. The upcoming hwmod conversion will take care of the cleanup. We _need_ these two small fixes ASAP, since it is fixing serious problem in audio (and the same issue might bite other areas as well). It is not the intention of this series to clean up the arc/arm/plat-omap/dma.c. I have added the dma_errata variable, since Tony asked for it, but even that addition is a bigger change than what I was planning to do here. Yeah.. Let's just use your original patch for the fix, then queue adding the errata flag for the upcoming merge window. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
