RE: [RFC part2 v1][PATCH 1/4] omap2/3/4: serial: rename omap_serial_init
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Monday, March 01, 2010 5:49 PM > To: Aguirre, Sergio > Cc: linux-omap@vger.kernel.org > Subject: Re: [RFC part2 v1][PATCH 1/4] omap2/3/4: serial: rename > omap_serial_init > > "Aguirre, Sergio" writes: > > >> -Original Message- > >> From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > >> Sent: Monday, March 01, 2010 3:10 PM > >> To: Aguirre, Sergio > >> Cc: linux-omap@vger.kernel.org > >> Subject: Re: [RFC part2 v1][PATCH 1/4] omap2/3/4: serial: rename > >> omap_serial_init > >> > >> Sergio Aguirre writes: > >> > >> > The name itself doesn't make clear that all UARTs of the platform > >> > are going to be initted. This is just to give more awareness of the > >> > real action being done here. > >> > > >> > Signed-off-by: Sergio Aguirre > >> > >> IMO, I don't think this adds any more clarity. > > > > OK. But, do you mean that this is clear enough already, or that you have > a better suggestion than mine? > > Personally, I think it's clear enough the way it is. Ok, I think I'll drop it from the series, and repost a new version tomorrow. Regards, Sergio > > Kevin > > > > The reason I wanted to propose this change is because, you either use: > > > > omap_serial_init() > > > > or > > > > omap_serial_init_port(number) > > > > And for me it looked more consistent to have it named > omap_serial_init_allports instead... > > > > > >> > >> Kevin > >> > >> > >> > --- > >> > arch/arm/mach-omap2/board-2430sdp.c |2 +- > >> > arch/arm/mach-omap2/board-3430sdp.c |2 +- > >> > arch/arm/mach-omap2/board-4430sdp.c |2 +- > >> > arch/arm/mach-omap2/board-am3517evm.c|2 +- > >> > arch/arm/mach-omap2/board-apollon.c |2 +- > >> > arch/arm/mach-omap2/board-cm-t35.c |2 +- > >> > arch/arm/mach-omap2/board-devkit8000.c |2 +- > >> > arch/arm/mach-omap2/board-generic.c |2 +- > >> > arch/arm/mach-omap2/board-h4.c |2 +- > >> > arch/arm/mach-omap2/board-igep0020.c |2 +- > >> > arch/arm/mach-omap2/board-ldp.c |2 +- > >> > arch/arm/mach-omap2/board-n8x0.c |2 +- > >> > arch/arm/mach-omap2/board-omap3beagle.c |2 +- > >> > arch/arm/mach-omap2/board-omap3evm.c |2 +- > >> > arch/arm/mach-omap2/board-omap3pandora.c |2 +- > >> > arch/arm/mach-omap2/board-omap3touchbook.c |2 +- > >> > arch/arm/mach-omap2/board-overo.c|2 +- > >> > arch/arm/mach-omap2/board-rx51.c |2 +- > >> > arch/arm/mach-omap2/board-zoom-peripherals.c |2 +- > >> > arch/arm/mach-omap2/serial.c |8 > >> > arch/arm/plat-omap/include/plat/serial.h |2 +- > >> > 21 files changed, 24 insertions(+), 24 deletions(-) > >> > mode change 100755 => 100644 arch/arm/mach-omap2/board-zoom- > >> peripherals.c > >> > > >> > diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach- > >> omap2/board-2430sdp.c > >> > index 01d113f..abc55bc 100644 > >> > --- a/arch/arm/mach-omap2/board-2430sdp.c > >> > +++ b/arch/arm/mach-omap2/board-2430sdp.c > >> > @@ -206,7 +206,7 @@ static void __init omap_2430sdp_init(void) > >> > omap2430_i2c_init(); > >> > > >> > platform_add_devices(sdp2430_devices, > ARRAY_SIZE(sdp2430_devices)); > >> > - omap_serial_init(); > >> > + omap_serial_init_allports(); > >> > omap2_hsmmc_init(mmc); > >> > usb_musb_init(&musb_board_data); > >> > board_smc91x_init(); > >> > diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach- > >> omap2/board-3430sdp.c > >> > index f312b15..8c84973 100644 > >> > --- a/arch/arm/mach-omap2/board-3430sdp.c > >> > +++ b/arch/arm/mach-omap2/board-3430sdp.c > >> > @@ -799,7 +799,7 @@ static void __init omap_3430sdp_init(void) > >> > spi_register_board_info(sdp3430_spi_board_info, > >> > ARRAY_SIZE(sdp3430_spi_board_info)); > >> >
Re: [RFC part2 v1][PATCH 1/4] omap2/3/4: serial: rename omap_serial_init
"Aguirre, Sergio" writes:
>> -Original Message-
>> From: Kevin Hilman [mailto:khil...@deeprootsystems.com]
>> Sent: Monday, March 01, 2010 3:10 PM
>> To: Aguirre, Sergio
>> Cc: linux-omap@vger.kernel.org
>> Subject: Re: [RFC part2 v1][PATCH 1/4] omap2/3/4: serial: rename
>> omap_serial_init
>>
>> Sergio Aguirre writes:
>>
>> > The name itself doesn't make clear that all UARTs of the platform
>> > are going to be initted. This is just to give more awareness of the
>> > real action being done here.
>> >
>> > Signed-off-by: Sergio Aguirre
>>
>> IMO, I don't think this adds any more clarity.
>
> OK. But, do you mean that this is clear enough already, or that you have a
> better suggestion than mine?
Personally, I think it's clear enough the way it is.
Kevin
> The reason I wanted to propose this change is because, you either use:
>
> omap_serial_init()
>
> or
>
> omap_serial_init_port(number)
>
> And for me it looked more consistent to have it named
> omap_serial_init_allports instead...
>
>>
>> Kevin
>>
>>
>> > ---
>> > arch/arm/mach-omap2/board-2430sdp.c |2 +-
>> > arch/arm/mach-omap2/board-3430sdp.c |2 +-
>> > arch/arm/mach-omap2/board-4430sdp.c |2 +-
>> > arch/arm/mach-omap2/board-am3517evm.c|2 +-
>> > arch/arm/mach-omap2/board-apollon.c |2 +-
>> > arch/arm/mach-omap2/board-cm-t35.c |2 +-
>> > arch/arm/mach-omap2/board-devkit8000.c |2 +-
>> > arch/arm/mach-omap2/board-generic.c |2 +-
>> > arch/arm/mach-omap2/board-h4.c |2 +-
>> > arch/arm/mach-omap2/board-igep0020.c |2 +-
>> > arch/arm/mach-omap2/board-ldp.c |2 +-
>> > arch/arm/mach-omap2/board-n8x0.c |2 +-
>> > arch/arm/mach-omap2/board-omap3beagle.c |2 +-
>> > arch/arm/mach-omap2/board-omap3evm.c |2 +-
>> > arch/arm/mach-omap2/board-omap3pandora.c |2 +-
>> > arch/arm/mach-omap2/board-omap3touchbook.c |2 +-
>> > arch/arm/mach-omap2/board-overo.c|2 +-
>> > arch/arm/mach-omap2/board-rx51.c |2 +-
>> > arch/arm/mach-omap2/board-zoom-peripherals.c |2 +-
>> > arch/arm/mach-omap2/serial.c |8
>> > arch/arm/plat-omap/include/plat/serial.h |2 +-
>> > 21 files changed, 24 insertions(+), 24 deletions(-)
>> > mode change 100755 => 100644 arch/arm/mach-omap2/board-zoom-
>> peripherals.c
>> >
>> > diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-
>> omap2/board-2430sdp.c
>> > index 01d113f..abc55bc 100644
>> > --- a/arch/arm/mach-omap2/board-2430sdp.c
>> > +++ b/arch/arm/mach-omap2/board-2430sdp.c
>> > @@ -206,7 +206,7 @@ static void __init omap_2430sdp_init(void)
>> > omap2430_i2c_init();
>> >
>> > platform_add_devices(sdp2430_devices, ARRAY_SIZE(sdp2430_devices));
>> > - omap_serial_init();
>> > + omap_serial_init_allports();
>> > omap2_hsmmc_init(mmc);
>> > usb_musb_init(&musb_board_data);
>> > board_smc91x_init();
>> > diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-
>> omap2/board-3430sdp.c
>> > index f312b15..8c84973 100644
>> > --- a/arch/arm/mach-omap2/board-3430sdp.c
>> > +++ b/arch/arm/mach-omap2/board-3430sdp.c
>> > @@ -799,7 +799,7 @@ static void __init omap_3430sdp_init(void)
>> > spi_register_board_info(sdp3430_spi_board_info,
>> > ARRAY_SIZE(sdp3430_spi_board_info));
>> > ads7846_dev_init();
>> > - omap_serial_init();
>> > + omap_serial_init_allports();
>> > usb_musb_init(&musb_board_data);
>> > board_smc91x_init();
>> > sdp_flash_init(sdp_flash_partitions);
>> > diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-
>> omap2/board-4430sdp.c
>> > index 029c6c9..1d47064 100644
>> > --- a/arch/arm/mach-omap2/board-4430sdp.c
>> > +++ b/arch/arm/mach-omap2/board-4430sdp.c
>> > @@ -84,7 +84,7 @@ static struct omap_musb_board_data musb_board_data = {
>> > static void __init omap_4430sdp_init(void)
>> > {
>> > platform_add_devices(sdp4430_devices, ARRAY_SIZE(sdp4430_devices));
>> > - omap_serial_init();
>> > + omap_serial
RE: [RFC part2 v1][PATCH 1/4] omap2/3/4: serial: rename omap_serial_init
> -Original Message-
> From: Kevin Hilman [mailto:khil...@deeprootsystems.com]
> Sent: Monday, March 01, 2010 3:10 PM
> To: Aguirre, Sergio
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [RFC part2 v1][PATCH 1/4] omap2/3/4: serial: rename
> omap_serial_init
>
> Sergio Aguirre writes:
>
> > The name itself doesn't make clear that all UARTs of the platform
> > are going to be initted. This is just to give more awareness of the
> > real action being done here.
> >
> > Signed-off-by: Sergio Aguirre
>
> IMO, I don't think this adds any more clarity.
OK. But, do you mean that this is clear enough already, or that you have a
better suggestion than mine?
The reason I wanted to propose this change is because, you either use:
omap_serial_init()
or
omap_serial_init_port(number)
And for me it looked more consistent to have it named omap_serial_init_allports
instead...
Regards,
Sergio
>
> Kevin
>
>
> > ---
> > arch/arm/mach-omap2/board-2430sdp.c |2 +-
> > arch/arm/mach-omap2/board-3430sdp.c |2 +-
> > arch/arm/mach-omap2/board-4430sdp.c |2 +-
> > arch/arm/mach-omap2/board-am3517evm.c|2 +-
> > arch/arm/mach-omap2/board-apollon.c |2 +-
> > arch/arm/mach-omap2/board-cm-t35.c |2 +-
> > arch/arm/mach-omap2/board-devkit8000.c |2 +-
> > arch/arm/mach-omap2/board-generic.c |2 +-
> > arch/arm/mach-omap2/board-h4.c |2 +-
> > arch/arm/mach-omap2/board-igep0020.c |2 +-
> > arch/arm/mach-omap2/board-ldp.c |2 +-
> > arch/arm/mach-omap2/board-n8x0.c |2 +-
> > arch/arm/mach-omap2/board-omap3beagle.c |2 +-
> > arch/arm/mach-omap2/board-omap3evm.c |2 +-
> > arch/arm/mach-omap2/board-omap3pandora.c |2 +-
> > arch/arm/mach-omap2/board-omap3touchbook.c |2 +-
> > arch/arm/mach-omap2/board-overo.c|2 +-
> > arch/arm/mach-omap2/board-rx51.c |2 +-
> > arch/arm/mach-omap2/board-zoom-peripherals.c |2 +-
> > arch/arm/mach-omap2/serial.c |8
> > arch/arm/plat-omap/include/plat/serial.h |2 +-
> > 21 files changed, 24 insertions(+), 24 deletions(-)
> > mode change 100755 => 100644 arch/arm/mach-omap2/board-zoom-
> peripherals.c
> >
> > diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-
> omap2/board-2430sdp.c
> > index 01d113f..abc55bc 100644
> > --- a/arch/arm/mach-omap2/board-2430sdp.c
> > +++ b/arch/arm/mach-omap2/board-2430sdp.c
> > @@ -206,7 +206,7 @@ static void __init omap_2430sdp_init(void)
> > omap2430_i2c_init();
> >
> > platform_add_devices(sdp2430_devices, ARRAY_SIZE(sdp2430_devices));
> > - omap_serial_init();
> > + omap_serial_init_allports();
> > omap2_hsmmc_init(mmc);
> > usb_musb_init(&musb_board_data);
> > board_smc91x_init();
> > diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-
> omap2/board-3430sdp.c
> > index f312b15..8c84973 100644
> > --- a/arch/arm/mach-omap2/board-3430sdp.c
> > +++ b/arch/arm/mach-omap2/board-3430sdp.c
> > @@ -799,7 +799,7 @@ static void __init omap_3430sdp_init(void)
> > spi_register_board_info(sdp3430_spi_board_info,
> > ARRAY_SIZE(sdp3430_spi_board_info));
> > ads7846_dev_init();
> > - omap_serial_init();
> > + omap_serial_init_allports();
> > usb_musb_init(&musb_board_data);
> > board_smc91x_init();
> > sdp_flash_init(sdp_flash_partitions);
> > diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-
> omap2/board-4430sdp.c
> > index 029c6c9..1d47064 100644
> > --- a/arch/arm/mach-omap2/board-4430sdp.c
> > +++ b/arch/arm/mach-omap2/board-4430sdp.c
> > @@ -84,7 +84,7 @@ static struct omap_musb_board_data musb_board_data = {
> > static void __init omap_4430sdp_init(void)
> > {
> > platform_add_devices(sdp4430_devices, ARRAY_SIZE(sdp4430_devices));
> > - omap_serial_init();
> > + omap_serial_init_allports();
> > /* OMAP4 SDP uses internal transceiver so register nop transceiver
> */
> > usb_nop_xceiv_register();
> > /* FIXME: allow multi-omap to boot until musb is updated for omap4
> */
> > diff --git a/arch/arm/mach-omap2/board-am3517evm.c b/arch/arm/mach-
> omap2/board-am3517evm.c
> > index e6b8967..d88b31f 100644
> > --- a/arch/arm/mach-omap2/board-am3517evm.c
> > +++ b/arch/arm/mach-omap2/board-am3517evm.c
> > @@
Re: [RFC part2 v1][PATCH 1/4] omap2/3/4: serial: rename omap_serial_init
Sergio Aguirre writes:
> The name itself doesn't make clear that all UARTs of the platform
> are going to be initted. This is just to give more awareness of the
> real action being done here.
>
> Signed-off-by: Sergio Aguirre
IMO, I don't think this adds any more clarity.
Kevin
> ---
> arch/arm/mach-omap2/board-2430sdp.c |2 +-
> arch/arm/mach-omap2/board-3430sdp.c |2 +-
> arch/arm/mach-omap2/board-4430sdp.c |2 +-
> arch/arm/mach-omap2/board-am3517evm.c|2 +-
> arch/arm/mach-omap2/board-apollon.c |2 +-
> arch/arm/mach-omap2/board-cm-t35.c |2 +-
> arch/arm/mach-omap2/board-devkit8000.c |2 +-
> arch/arm/mach-omap2/board-generic.c |2 +-
> arch/arm/mach-omap2/board-h4.c |2 +-
> arch/arm/mach-omap2/board-igep0020.c |2 +-
> arch/arm/mach-omap2/board-ldp.c |2 +-
> arch/arm/mach-omap2/board-n8x0.c |2 +-
> arch/arm/mach-omap2/board-omap3beagle.c |2 +-
> arch/arm/mach-omap2/board-omap3evm.c |2 +-
> arch/arm/mach-omap2/board-omap3pandora.c |2 +-
> arch/arm/mach-omap2/board-omap3touchbook.c |2 +-
> arch/arm/mach-omap2/board-overo.c|2 +-
> arch/arm/mach-omap2/board-rx51.c |2 +-
> arch/arm/mach-omap2/board-zoom-peripherals.c |2 +-
> arch/arm/mach-omap2/serial.c |8
> arch/arm/plat-omap/include/plat/serial.h |2 +-
> 21 files changed, 24 insertions(+), 24 deletions(-)
> mode change 100755 => 100644 arch/arm/mach-omap2/board-zoom-peripherals.c
>
> diff --git a/arch/arm/mach-omap2/board-2430sdp.c
> b/arch/arm/mach-omap2/board-2430sdp.c
> index 01d113f..abc55bc 100644
> --- a/arch/arm/mach-omap2/board-2430sdp.c
> +++ b/arch/arm/mach-omap2/board-2430sdp.c
> @@ -206,7 +206,7 @@ static void __init omap_2430sdp_init(void)
> omap2430_i2c_init();
>
> platform_add_devices(sdp2430_devices, ARRAY_SIZE(sdp2430_devices));
> - omap_serial_init();
> + omap_serial_init_allports();
> omap2_hsmmc_init(mmc);
> usb_musb_init(&musb_board_data);
> board_smc91x_init();
> diff --git a/arch/arm/mach-omap2/board-3430sdp.c
> b/arch/arm/mach-omap2/board-3430sdp.c
> index f312b15..8c84973 100644
> --- a/arch/arm/mach-omap2/board-3430sdp.c
> +++ b/arch/arm/mach-omap2/board-3430sdp.c
> @@ -799,7 +799,7 @@ static void __init omap_3430sdp_init(void)
> spi_register_board_info(sdp3430_spi_board_info,
> ARRAY_SIZE(sdp3430_spi_board_info));
> ads7846_dev_init();
> - omap_serial_init();
> + omap_serial_init_allports();
> usb_musb_init(&musb_board_data);
> board_smc91x_init();
> sdp_flash_init(sdp_flash_partitions);
> diff --git a/arch/arm/mach-omap2/board-4430sdp.c
> b/arch/arm/mach-omap2/board-4430sdp.c
> index 029c6c9..1d47064 100644
> --- a/arch/arm/mach-omap2/board-4430sdp.c
> +++ b/arch/arm/mach-omap2/board-4430sdp.c
> @@ -84,7 +84,7 @@ static struct omap_musb_board_data musb_board_data = {
> static void __init omap_4430sdp_init(void)
> {
> platform_add_devices(sdp4430_devices, ARRAY_SIZE(sdp4430_devices));
> - omap_serial_init();
> + omap_serial_init_allports();
> /* OMAP4 SDP uses internal transceiver so register nop transceiver */
> usb_nop_xceiv_register();
> /* FIXME: allow multi-omap to boot until musb is updated for omap4 */
> diff --git a/arch/arm/mach-omap2/board-am3517evm.c
> b/arch/arm/mach-omap2/board-am3517evm.c
> index e6b8967..d88b31f 100644
> --- a/arch/arm/mach-omap2/board-am3517evm.c
> +++ b/arch/arm/mach-omap2/board-am3517evm.c
> @@ -300,7 +300,7 @@ static void __init am3517_evm_init(void)
> platform_add_devices(am3517_evm_devices,
> ARRAY_SIZE(am3517_evm_devices));
>
> - omap_serial_init();
> + omap_serial_init_allports();
> usb_ehci_init(&ehci_pdata);
> /* DSS */
> am3517_evm_display_init();
> diff --git a/arch/arm/mach-omap2/board-apollon.c
> b/arch/arm/mach-omap2/board-apollon.c
> index aa69fb9..6c14392 100644
> --- a/arch/arm/mach-omap2/board-apollon.c
> +++ b/arch/arm/mach-omap2/board-apollon.c
> @@ -331,7 +331,7 @@ static void __init omap_apollon_init(void)
>* if not needed.
>*/
> platform_add_devices(apollon_devices, ARRAY_SIZE(apollon_devices));
> - omap_serial_init();
> + omap_serial_init_allports();
> }
>
> static void __init omap_apollon_map_io(void)
> diff --git a/arch/arm/mach-omap2/board-cm-t35.c
> b/arch/arm/mach-omap2/board-cm-t35.c
> index afa77ca..e148835 100644
> --- a/arch/arm/mach-omap2/board-cm-t35.c
> +++ b/arch/arm/mach-omap2/board-cm-t35.c
> @@ -820,7 +820,7 @@ static struct omap_musb_board_data musb_board_data = {
> static void __init cm_t35_init(void)
> {
> omap3_mux_init(board_mux, OMAP_PACKAGE_CUS);
> - omap_serial_init();
> + omap_serial_init_allports();
