Re: [Regression?] Removed regulator support in ehci-omap
On 12:07 Sun 24 Apr , Keshava Munegowda wrote: I have posted the patches on April 22, 2011. If possible I request you to test this. Hi, Keshava! Sorry for delay - it took some time to find _where_ exactly you have posted the patch (thanks to Alan for giving the link). Anyway, it[1] seems to work as advertised (I also applied GPIO polarity fix [2] and board file patch[3], all on top of 2.6.39-rc4) - at least stuff in /sys/class/regulator looks right, and USB devices are detected. There's probably something still missing in the board file, as USB detection starts to work only if I booted TI's kernel (that came with board) before trying patched 2.6.39-rc4, but I hope that this isn't connected to this regulators issue. [1] http://www.spinics.net/lists/linux-usb/msg45618.html [2] https://lkml.org/lkml/2011/4/14/45 [3] http://arago-project.org/git/projects/?p=linux-omap3.git;a=commitdiff;h=2ec611981ad76256d5034ae36708d807142bed1c -- Best regards, Dmitry MAD Artamonow -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Regression?] Removed regulator support in ehci-omap
On Wed, Apr 27, 2011 at 5:21 PM, Dmitry Artamonow mad_s...@inbox.ru wrote: On 12:07 Sun 24 Apr , Keshava Munegowda wrote: I have posted the patches on April 22, 2011. If possible I request you to test this. Hi, Keshava! Sorry for delay - it took some time to find _where_ exactly you have posted the patch (thanks to Alan for giving the link). Anyway, it[1] seems to work as advertised (I also applied GPIO polarity fix [2] and board file patch[3], all on top of 2.6.39-rc4) - at least stuff in /sys/class/regulator looks right, and USB devices are detected. There's probably something still missing in the board file, as USB detection starts to work only if I booted TI's kernel (that came with board) before trying patched 2.6.39-rc4, but I hope that this isn't connected to this regulators issue. [1] http://www.spinics.net/lists/linux-usb/msg45618.html [2] https://lkml.org/lkml/2011/4/14/45 [3] http://arago-project.org/git/projects/?p=linux-omap3.git;a=commitdiff;h=2ec611981ad76256d5034ae36708d807142bed1c -- Best regards, Dmitry MAD Artamonow I think I am missing something here! In which platform are you testing? keshava munegowda -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Regression?] Removed regulator support in ehci-omap
On 04/24/2011 02:37 AM, Keshava Munegowda wrote: -Original Message- From: Alan Ott [mailto:a...@signal11.us] Sent: Friday, April 22, 2011 6:41 AM To: Keshava Munegowda Cc: Dmitry Artamonow; Steve Sakoman; Steve Calfee; Felipe Balbi; linux-...@vger.kernel.org; linux- o...@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [Regression?] Removed regulator support in ehci-omap On 04/12/2011 12:20 PM, Keshava Munegowda wrote: Ah, so EHCI/OHCI common code was moved into drivers/mfd... Good. But seems regulators support was lost somewhere during transition - the only mentioning about regulators in omap-usb-host.c is #include : mad@macmini:~/kernel-hack/linux-2.6(master)$ grep -i regulator drivers/mfd/omap-usb-host.c Thanks ! I will add some time next week! I have confirmed this on my BeagleBoard-xM. 2.6.38 works, but the 2.6.39-rc4+ head from yesterday did not. It seems that the regulator does not turn the power on for the USB hub which the ethernet is attached to. I connected this issue to bug 33092 in bugzilla[1]. Alan. [1] https://bugzilla.kernel.org/show_bug.cgi?id=33092 I have posted the patches on April 22, 2011. If possible I request you to test this. Hi Keshava, If you mean this patch[1], then I tested it against the head and it didn't fix my problem. I couldn't convince myself that your patch was supposed to be the whole fix to my problem (since it wasn't mentioned on this thread) so I didn't reply with my findings. Sorry about that. Thanks for taking a look, Alan. [1] http://www.spinics.net/lists/linux-usb/msg45618.html signature.asc Description: OpenPGP digital signature
Re: [Regression?] Removed regulator support in ehci-omap
On Mon, Apr 25, 2011 at 7:11 AM, Alan Ott a...@signal11.us wrote: On 04/24/2011 02:37 AM, Keshava Munegowda wrote: -Original Message- From: Alan Ott [mailto:a...@signal11.us] Sent: Friday, April 22, 2011 6:41 AM To: Keshava Munegowda Cc: Dmitry Artamonow; Steve Sakoman; Steve Calfee; Felipe Balbi; linux-...@vger.kernel.org; linux- o...@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [Regression?] Removed regulator support in ehci-omap On 04/12/2011 12:20 PM, Keshava Munegowda wrote: Ah, so EHCI/OHCI common code was moved into drivers/mfd... Good. But seems regulators support was lost somewhere during transition - the only mentioning about regulators in omap-usb-host.c is #include : mad@macmini:~/kernel-hack/linux-2.6(master)$ grep -i regulator drivers/mfd/omap-usb-host.c Thanks ! I will add some time next week! I have confirmed this on my BeagleBoard-xM. 2.6.38 works, but the 2.6.39-rc4+ head from yesterday did not. It seems that the regulator does not turn the power on for the USB hub which the ethernet is attached to. I connected this issue to bug 33092 in bugzilla[1]. Alan. [1] https://bugzilla.kernel.org/show_bug.cgi?id=33092 I have posted the patches on April 22, 2011. If possible I request you to test this. Hi Keshava, If you mean this patch[1], then I tested it against the head and it didn't fix my problem. I couldn't convince myself that your patch was supposed to be the whole fix to my problem (since it wasn't mentioned on this thread) so I didn't reply with my findings. Sorry about that. Same here. The real issue (at least for Overo) turned out to be: https://lkml.org/lkml/2011/4/14/45 Steve -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [Regression?] Removed regulator support in ehci-omap
-Original Message- From: Steve Sakoman [mailto:sako...@gmail.com] Sent: Monday, April 25, 2011 7:46 PM To: Alan Ott Cc: Keshava Munegowda; Dmitry Artamonow; Steve Calfee; Felipe Balbi; linux-...@vger.kernel.org; linux-omap@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [Regression?] Removed regulator support in ehci-omap On Mon, Apr 25, 2011 at 7:11 AM, Alan Ott a...@signal11.us wrote: On 04/24/2011 02:37 AM, Keshava Munegowda wrote: -Original Message- From: Alan Ott [mailto:a...@signal11.us] Sent: Friday, April 22, 2011 6:41 AM To: Keshava Munegowda Cc: Dmitry Artamonow; Steve Sakoman; Steve Calfee; Felipe Balbi; linux-...@vger.kernel.org; linux- o...@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [Regression?] Removed regulator support in ehci-omap On 04/12/2011 12:20 PM, Keshava Munegowda wrote: Ah, so EHCI/OHCI common code was moved into drivers/mfd... Good. But seems regulators support was lost somewhere during transition - the only mentioning about regulators in omap-usb-host.c is #include : mad@macmini:~/kernel-hack/linux-2.6(master)$ grep -i regulator drivers/mfd/omap-usb-host.c Thanks ! I will add some time next week! I have confirmed this on my BeagleBoard-xM. 2.6.38 works, but the 2.6.39-rc4+ head from yesterday did not. It seems that the regulator does not turn the power on for the USB hub which the ethernet is attached to. I connected this issue to bug 33092 in bugzilla[1]. Alan. [1] https://bugzilla.kernel.org/show_bug.cgi?id=33092 I have posted the patches on April 22, 2011. If possible I request you to test this. Hi Keshava, If you mean this patch[1], then I tested it against the head and it didn't fix my problem. I couldn't convince myself that your patch was supposed to be the whole fix to my problem (since it wasn't mentioned on this thread) so I didn't reply with my findings. Sorry about that. Same here. The real issue (at least for Overo) turned out to be: https://lkml.org/lkml/2011/4/14/45 Steve But, I was not aware of the fix of the link: https://lkml.org/lkml/2011/4/14/45 Sorry for this. Same fix works for beagle-XM and I have tested this. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Regression?] Removed regulator support in ehci-omap
On 04/25/11 09:41, Keshava Munegowda wrote: -Original Message- From: Steve Sakoman [mailto:sako...@gmail.com] Sent: Monday, April 25, 2011 7:46 PM To: Alan Ott Cc: Keshava Munegowda; Dmitry Artamonow; Steve Calfee; Felipe Balbi; linux-...@vger.kernel.org; linux-omap@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [Regression?] Removed regulator support in ehci-omap On Mon, Apr 25, 2011 at 7:11 AM, Alan Ott a...@signal11.us wrote: On 04/24/2011 02:37 AM, Keshava Munegowda wrote: -Original Message- From: Alan Ott [mailto:a...@signal11.us] Sent: Friday, April 22, 2011 6:41 AM To: Keshava Munegowda Cc: Dmitry Artamonow; Steve Sakoman; Steve Calfee; Felipe Balbi; linux-...@vger.kernel.org; linux- o...@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [Regression?] Removed regulator support in ehci-omap On 04/12/2011 12:20 PM, Keshava Munegowda wrote: Ah, so EHCI/OHCI common code was moved into drivers/mfd... Good. But seems regulators support was lost somewhere during transition - the only mentioning about regulators in omap-usb-host.c is #include : mad@macmini:~/kernel-hack/linux-2.6(master)$ grep -i regulator drivers/mfd/omap-usb-host.c Thanks ! I will add some time next week! I have confirmed this on my BeagleBoard-xM. 2.6.38 works, but the 2.6.39-rc4+ head from yesterday did not. It seems that the regulator does not turn the power on for the USB hub which the ethernet is attached to. I connected this issue to bug 33092 in bugzilla[1]. Alan. [1] https://bugzilla.kernel.org/show_bug.cgi?id=33092 I have posted the patches on April 22, 2011. If possible I request you to test this. Hi Keshava, If you mean this patch[1], then I tested it against the head and it didn't fix my problem. I couldn't convince myself that your patch was supposed to be the whole fix to my problem (since it wasn't mentioned on this thread) so I didn't reply with my findings. Sorry about that. Same here. The real issue (at least for Overo) turned out to be: https://lkml.org/lkml/2011/4/14/45 Steve But, I was not aware of the fix of the link: https://lkml.org/lkml/2011/4/14/45 Sorry for this. Same fix works for beagle-XM and I have tested this. I just tried your 3 patches on my beagleboardxm. It still fails to boot. Maybe I have a different problem? Your fix did enable usb (at least it found the hub and usbnet driver, but the smsc95xx driver may or may not be working. Here is my failed 2.6.39rc4 boot log. If I back up to 2.6.38 the kernel does find the nfs server and starts. Uncompressing Linux... done, booting the kernel. [0.00] Linux version 2.6.39-rc4+ (calfee@Gracie) (gcc version 4.5.2 (Bu1 [0.00] CPU: ARMv7 Processor [413fc082] revision 2 (ARMv7), cr=10c53c7f [0.00] CPU: VIPT nonaliasing data cache, VIPT aliasing instruction cache [0.00] Machine: OMAP3 Beagle Board [0.00] Memory policy: ECC disabled, Data cache writeback [0.00] OMAP3630 ES1.1 (l2cache iva sgx neon isp 192mhz_clk ) [0.00] SRAM: Mapped pa 0x4020 to va 0xfe40 size: 0x1 [0.00] Clocking rate (Crystal/Core/MPU): 26.0/332/600 MHz [0.00] Reprogramming SDRC clock to 33200 Hz [0.00] Built 1 zonelists in Zone order, mobility grouping on. Total pa8 [0.00] Kernel command line: console=tty0 console=ttyO2,115200n8 mpuratet [0.00] PID hash table entries: 2048 (order: 1, 8192 bytes) [0.00] Dentry cache hash table entries: 65536 (order: 6, 262144 bytes) [0.00] Inode-cache hash table entries: 32768 (order: 5, 131072 bytes) [0.00] Memory: 512MB = 512MB total [0.00] Memory: 508416k/508416k available, 15872k reserved, 0K highmem [0.00] Virtual kernel memory layout: [0.00] vector : 0x - 0x1000 ( 4 kB) [0.00] fixmap : 0xfff0 - 0xfffe ( 896 kB) [0.00] DMA : 0xffc0 - 0xffe0 ( 2 MB) [0.00] vmalloc : 0xe080 - 0xf800 ( 376 MB) [0.00] lowmem : 0xc000 - 0xe000 ( 512 MB) [0.00] modules : 0xbf00 - 0xc000 ( 16 MB) [0.00] .init : 0xc0008000 - 0xc0031000 ( 164 kB) [0.00] .text : 0xc0031000 - 0xc0408638 (3934 kB) [0.00] .data : 0xc040a000 - 0xc05b6500 (1714 kB) [0.00] NR_IRQS:410 [0.00] IRQ: Found an INTC at 0xfa20 (revision 4.0) with 96 interrups [0.00] Total of 96 interrupts on 1 active controller [0.00] omap_hwmod: gpt12_fck: missing clockdomain for gpt12_fck. [0.00] OMAP clockevent source: GPTIMER12 at 32768 Hz [0.00] sched_clock: 32 bits at 32kHz, resolution 30517ns, wraps every 1s [0.00] Console: colour dummy device 80x30 [0.00] console [tty0] enabled [0.00] Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingr [0.00] ... MAX_LOCKDEP_SUBCLASSES: 8 [0.00
Re: [Regression?] Removed regulator support in ehci-omap
On 04/25/11 10:23, Steve Calfee wrote: On 04/25/11 09:41, Keshava Munegowda wrote: -Original Message- From: Steve Sakoman [mailto:sako...@gmail.com] Sent: Monday, April 25, 2011 7:46 PM To: Alan Ott Cc: Keshava Munegowda; Dmitry Artamonow; Steve Calfee; Felipe Balbi; linux-...@vger.kernel.org; linux-omap@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [Regression?] Removed regulator support in ehci-omap On Mon, Apr 25, 2011 at 7:11 AM, Alan Ott a...@signal11.us wrote: On 04/24/2011 02:37 AM, Keshava Munegowda wrote: -Original Message- From: Alan Ott [mailto:a...@signal11.us] Sent: Friday, April 22, 2011 6:41 AM To: Keshava Munegowda Cc: Dmitry Artamonow; Steve Sakoman; Steve Calfee; Felipe Balbi; linux-...@vger.kernel.org; linux- o...@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [Regression?] Removed regulator support in ehci-omap On 04/12/2011 12:20 PM, Keshava Munegowda wrote: Ah, so EHCI/OHCI common code was moved into drivers/mfd... Good. But seems regulators support was lost somewhere during transition - the only mentioning about regulators in omap-usb-host.c is #include : mad@macmini:~/kernel-hack/linux-2.6(master)$ grep -i regulator drivers/mfd/omap-usb-host.c Thanks ! I will add some time next week! I have confirmed this on my BeagleBoard-xM. 2.6.38 works, but the 2.6.39-rc4+ head from yesterday did not. It seems that the regulator does not turn the power on for the USB hub which the ethernet is attached to. I connected this issue to bug 33092 in bugzilla[1]. Alan. [1] https://bugzilla.kernel.org/show_bug.cgi?id=33092 I have posted the patches on April 22, 2011. If possible I request you to test this. Hi Keshava, If you mean this patch[1], then I tested it against the head and it didn't fix my problem. I couldn't convince myself that your patch was supposed to be the whole fix to my problem (since it wasn't mentioned on this thread) so I didn't reply with my findings. Sorry about that. Same here. The real issue (at least for Overo) turned out to be: https://lkml.org/lkml/2011/4/14/45 Steve But, I was not aware of the fix of the link: https://lkml.org/lkml/2011/4/14/45 Sorry for this. Same fix works for beagle-XM and I have tested this. I just tried your 3 patches on my beagleboardxm. It still fails to boot. Maybe I have a different problem? Your fix did enable usb (at least it found the hub and usbnet driver, but the smsc95xx driver may or may not be working. Here is my failed 2.6.39rc4 boot log. If I back up to 2.6.38 the kernel does find the nfs server and starts. snip [4.301788] mmc0: new high speed SDHC card at address 1234 [4.310424] mmcblk0: mmc0:1234 SA04G 3.67 GiB [4.321441] mmcblk0: p1 p2 p3 [4.359619] usb 1-2.1: new high speed USB device number 3 using ehci-omap [4.485046] usb 1-2.1: New USB device found, idVendor=0424, idProduct=ec00 [4.492309] usb 1-2.1: New USB device strings: Mfr=0, Product=0, SerialNumbe0 [4.505432] smsc95xx v1.0.4 [4.596130] smsc95xx 1-2.1:1.0: eth0: register 'smsc95xx' at usb-ehci-omap.0d [ 16.620605] Root-NFS: no NFS server address [ 16.625122] VFS: Unable to mount root fs via NFS, trying floppy. [ 16.632354] List of all partitions: [ 16.636230] b300 3858432 mmcblk0 driver: mmcblk [ 16.641876] b301 1020096 mmcblk0p1 ----0001 [ 16.650634] b302 1028160 mmcblk0p2 ----0002 [ 16.659515] b303 1807312 mmcblk0p3 ----0003 [ 16.668243] No filesystem could mount root, tried: nfs [ 16.673767] Kernel panic - not syncing: VFS: Unable to mount root fs on unkn Hi Keshava, I rebuilt my system to boot from flash and now I see what happened. I even remember it being discussed on this list. Someone renamed my usb ethernet device from usb0 to eth0 !!! The boot log shows it on this line: [4.596130] smsc95xx 1-2.1:1.0: eth0: register 'smsc95xx' at usb-ehci-omap.0d So this broke my init scripts and uboot script... OK, so I can live with this (I hope the name doesn't change too often though). So I can manually configure my system to use eth0 and use the network. I am sure I will get nfs working shortly. I am using the 2.6.39-rc4 with your 3 patches. So from the Beagleboard XM perspective it works and you can include my Tested-by: Steve Calfee stevecal...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [Regression?] Removed regulator support in ehci-omap
Hi Keshava, I rebuilt my system to boot from flash and now I see what happened. I even remember it being discussed on this list. Someone renamed my usb ethernet device from usb0 to eth0 !!! The boot log shows it on this line: [4.596130] smsc95xx 1-2.1:1.0: eth0: register 'smsc95xx' at usb-ehci-omap.0d So this broke my init scripts and uboot script... OK, so I can live with this (I hope the name doesn't change too often though). So I can manually configure my system to use eth0 and use the network. I am sure I will get nfs working shortly. I am using the 2.6.39-rc4 with your 3 patches. So from the Beagleboard XM perspective it works and you can include my Tested-by: Steve Calfee stevecal...@gmail.com Thanks Steve Keshava Munegowda -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [Regression?] Removed regulator support in ehci-omap
-Original Message- From: Alan Ott [mailto:a...@signal11.us] Sent: Friday, April 22, 2011 6:41 AM To: Keshava Munegowda Cc: Dmitry Artamonow; Steve Sakoman; Steve Calfee; Felipe Balbi; linux-...@vger.kernel.org; linux- o...@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [Regression?] Removed regulator support in ehci-omap On 04/12/2011 12:20 PM, Keshava Munegowda wrote: Ah, so EHCI/OHCI common code was moved into drivers/mfd... Good. But seems regulators support was lost somewhere during transition - the only mentioning about regulators in omap-usb-host.c is #include : mad@macmini:~/kernel-hack/linux-2.6(master)$ grep -i regulator drivers/mfd/omap-usb-host.c Thanks ! I will add some time next week! I have confirmed this on my BeagleBoard-xM. 2.6.38 works, but the 2.6.39-rc4+ head from yesterday did not. It seems that the regulator does not turn the power on for the USB hub which the ethernet is attached to. I connected this issue to bug 33092 in bugzilla[1]. Alan. [1] https://bugzilla.kernel.org/show_bug.cgi?id=33092 I have posted the patches on April 22, 2011. If possible I request you to test this. Keshava Munegowda -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Regression?] Removed regulator support in ehci-omap
On 04/12/2011 12:20 PM, Keshava Munegowda wrote: Ah, so EHCI/OHCI common code was moved into drivers/mfd... Good. But seems regulators support was lost somewhere during transition - the only mentioning about regulators in omap-usb-host.c is #include : mad@macmini:~/kernel-hack/linux-2.6(master)$ grep -i regulator drivers/mfd/omap-usb-host.c Thanks ! I will add some time next week! I have confirmed this on my BeagleBoard-xM. 2.6.38 works, but the 2.6.39-rc4+ head from yesterday did not. It seems that the regulator does not turn the power on for the USB hub which the ethernet is attached to. I connected this issue to bug 33092 in bugzilla[1]. Alan. [1] https://bugzilla.kernel.org/show_bug.cgi?id=33092 signature.asc Description: OpenPGP digital signature
RE: [Regression?] Removed regulator support in ehci-omap
-Original Message- From: Dmitry Artamonow [mailto:mad_s...@inbox.ru] Sent: Tuesday, April 12, 2011 9:41 AM To: Keshava Munegowda Cc: Steve Sakoman; Steve Calfee; Felipe Balbi; linux-...@vger.kernel.org; linux-omap@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [Regression?] Removed regulator support in ehci-omap On 02:18 Tue 12 Apr , Keshava Munegowda wrote: Sorry guys! I will work on it coming week; currently I am in travel. Well, regulator is not removed, its moved to usbhs core driver in /driver/mfd/omap xx usb xxx host.c Ah, so EHCI/OHCI common code was moved into drivers/mfd... Good. But seems regulators support was lost somewhere during transition - the only mentioning about regulators in omap-usb-host.c is #include : mad@macmini:~/kernel-hack/linux-2.6(master)$ grep -i regulator drivers/mfd/omap-usb-host.c #include linux/regulator/consumer.h mad@macmini:~/kernel-hack/linux-2.6(master)$ -- Best regards, Dmitry MAD Artamonow Thanks ! I will add some time next week! Keshava Munegowda -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Regression?] Removed regulator support in ehci-omap
On 04/11/11 02:32, Dmitry Artamonow wrote: Hi, guys! Can anyone explain why regulator support has been removed from ehci-omap driver in commit 19403165 (usb: host: omap: ehci and ohci simplification)[1]? In 2.6.37/2.6.38 it was enough to apply simple patch[2] adding regulators description to board file to make USB work on omap3evm board (because USB PHY is powered via regulator). But now it won't work anymore in 2.6.39-rc2. BTW, I suspect that this commit also broke USB on omap3pandora board, as it defines hsusb0 regulator supply in its board file: Yes, And Beagleboard xm (and I suspect other beagleboard versions) has been broken in 2.6.39rc1+. Regards, Steve -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Regression?] Removed regulator support in ehci-omap
On Mon, Apr 11, 2011 at 10:06 AM, Steve Calfee stevecal...@gmail.com wrote: On 04/11/11 02:32, Dmitry Artamonow wrote: Hi, guys! Can anyone explain why regulator support has been removed from ehci-omap driver in commit 19403165 (usb: host: omap: ehci and ohci simplification)[1]? In 2.6.37/2.6.38 it was enough to apply simple patch[2] adding regulators description to board file to make USB work on omap3evm board (because USB PHY is powered via regulator). But now it won't work anymore in 2.6.39-rc2. BTW, I suspect that this commit also broke USB on omap3pandora board, as it defines hsusb0 regulator supply in its board file: Yes, And Beagleboard xm (and I suspect other beagleboard versions) has been broken in 2.6.39rc1+. FWIW, EHCI is also broken on Overo in both rc1 and rc2. Steve -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [Regression?] Removed regulator support in ehci-omap
-Original Message- From: Steve Sakoman [mailto:sako...@gmail.com] Sent: Tuesday, April 12, 2011 1:43 AM To: Steve Calfee Cc: Dmitry Artamonow; Keshava Munegowda; Felipe Balbi; linux-...@vger.kernel.org; linux- o...@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [Regression?] Removed regulator support in ehci-omap On Mon, Apr 11, 2011 at 10:06 AM, Steve Calfee stevecal...@gmail.com wrote: On 04/11/11 02:32, Dmitry Artamonow wrote: Hi, guys! Can anyone explain why regulator support has been removed from ehci-omap driver in commit 19403165 (usb: host: omap: ehci and ohci simplification)[1]? In 2.6.37/2.6.38 it was enough to apply simple patch[2] adding regulators description to board file to make USB work on omap3evm board (because USB PHY is powered via regulator). But now it won't work anymore in 2.6.39-rc2. BTW, I suspect that this commit also broke USB on omap3pandora board, as it defines hsusb0 regulator supply in its board file: Yes, And Beagleboard xm (and I suspect other beagleboard versions) has been broken in 2.6.39rc1+. FWIW, EHCI is also broken on Overo in both rc1 and rc2. Steve Sorry guys! I will work on it coming week; currently I am in travel. Well, regulator is not removed, its moved to usbhs core driver in /driver/mfd/omap xx usb xxx host.c Regards Keshava Munegowda -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Regression?] Removed regulator support in ehci-omap
On 02:18 Tue 12 Apr , Keshava Munegowda wrote: Sorry guys! I will work on it coming week; currently I am in travel. Well, regulator is not removed, its moved to usbhs core driver in /driver/mfd/omap xx usb xxx host.c Ah, so EHCI/OHCI common code was moved into drivers/mfd... Good. But seems regulators support was lost somewhere during transition - the only mentioning about regulators in omap-usb-host.c is #include : mad@macmini:~/kernel-hack/linux-2.6(master)$ grep -i regulator drivers/mfd/omap-usb-host.c #include linux/regulator/consumer.h mad@macmini:~/kernel-hack/linux-2.6(master)$ -- Best regards, Dmitry MAD Artamonow -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
