Re: [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable()

[Munegowda, Keshava]

Thanks samuel


regards
keshava

On Wed, Jul 27, 2011 at 3:23 PM, Samuel Ortiz  wrote:
> Hi Keshava,
>
> On Fri, Jul 22, 2011 at 06:39:30PM +0530, Keshava Munegowda wrote:
>> From: Keshava Munegowda 
>>
>> usbhs_disable function was invoking clk_enable() instead of
>> clk_disable(), thus only increasing the clock usage counter and
>> preventing this particular clock from being ever turned off.
>> Because of this, the power domain of omap4 the USB Host subsystem
>> would never reach lower power states.This patch calls clk_disable()
>> in usbhs_disable function
> I applied this patch now, thanks.
>
> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable()

[Samuel Ortiz]

Hi Keshava,

On Fri, Jul 22, 2011 at 06:39:30PM +0530, Keshava Munegowda wrote:
> From: Keshava Munegowda 
> 
> usbhs_disable function was invoking clk_enable() instead of
> clk_disable(), thus only increasing the clock usage counter and
> preventing this particular clock from being ever turned off.
> Because of this, the power domain of omap4 the USB Host subsystem
> would never reach lower power states.This patch calls clk_disable()
> in usbhs_disable function
I applied this patch now, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable()

[Felipe Balbi]

On Fri, Jul 22, 2011 at 06:39:30PM +0530, Keshava Munegowda wrote:
> From: Keshava Munegowda 
> 
> usbhs_disable function was invoking clk_enable() instead of
> clk_disable(), thus only increasing the clock usage counter and
> preventing this particular clock from being ever turned off.
> Because of this, the power domain of omap4 the USB Host subsystem
> would never reach lower power states.This patch calls clk_disable()
> in usbhs_disable function
> 
> Signed-off-by: Keshava Munegowda 

Acked-by: Felipe Balbi 

Samuel, I guess you can take this via MFD ?

-- 
balbi


signature.asc
Description: Digital signature