Re: [PATCH 09/21] ARM: OMAP: devkit8000: use new display drivers

2013-07-30 Thread Tomi Valkeinen 
On 30/07/13 08:48, Archit Taneja wrote:
 Hi,
 
 On Friday 26 July 2013 12:38 PM, Tomi Valkeinen wrote:
 Use new display drivers for devkit8000 board.

 The new OMAP display drivers were merged for 3.11, and we can now change
 the board files to use the new ones and phase out the old ones.

 Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
 ---
   arch/arm/mach-omap2/board-devkit8000.c | 96
 +++---
   1 file changed, 65 insertions(+), 31 deletions(-)

 diff --git a/arch/arm/mach-omap2/board-devkit8000.c
 b/arch/arm/mach-omap2/board-devkit8000.c
 index f1d91ba..cdc4fb9 100644
 --- a/arch/arm/mach-omap2/board-devkit8000.c
 +++ b/arch/arm/mach-omap2/board-devkit8000.c
 @@ -112,50 +112,81 @@ static struct regulator_consumer_supply
 devkit8000_vio_supply[] = {
   REGULATOR_SUPPLY(vcc, spi2.0),
   };

 -static struct panel_generic_dpi_data lcd_panel = {
 -.name= innolux_at070tn83,
 -/* gpios filled in code */
 +static const struct display_timing devkit8000_lcd_videomode = {
 +.pixelclock= { 0, 4000, 0 },
 
 This is unrelated to the work being done here, but noticed that the
 pixel clock for this panel seems to be too high for the given timings.
 It puts the refresh rate around 90 Hz, which is odd.

So it does... Quick googling found the specs for the panel, but even
with the typical values in the spec I get somewhwat odd refresh rate.

Well, as you said, it's unrelated to these changes. I guess it's better
not to touch it.

 Tomi




signature.asc
Description: OpenPGP digital signature

Re: [PATCH 09/21] ARM: OMAP: devkit8000: use new display drivers

2013-07-29 Thread Archit Taneja 

Hi,

On Friday 26 July 2013 12:38 PM, Tomi Valkeinen wrote:

Use new display drivers for devkit8000 board.

The new OMAP display drivers were merged for 3.11, and we can now change
the board files to use the new ones and phase out the old ones.

Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
  arch/arm/mach-omap2/board-devkit8000.c | 96 +++---
  1 file changed, 65 insertions(+), 31 deletions(-)

diff --git a/arch/arm/mach-omap2/board-devkit8000.c 
b/arch/arm/mach-omap2/board-devkit8000.c
index f1d91ba..cdc4fb9 100644
--- a/arch/arm/mach-omap2/board-devkit8000.c
+++ b/arch/arm/mach-omap2/board-devkit8000.c
@@ -112,50 +112,81 @@ static struct regulator_consumer_supply 
devkit8000_vio_supply[] = {
REGULATOR_SUPPLY(vcc, spi2.0),
  };

-static struct panel_generic_dpi_data lcd_panel = {
-   .name   = innolux_at070tn83,
-   /* gpios filled in code */
+static const struct display_timing devkit8000_lcd_videomode = {
+   .pixelclock = { 0, 4000, 0 },


This is unrelated to the work being done here, but noticed that the 
pixel clock for this panel seems to be too high for the given timings. 
It puts the refresh rate around 90 Hz, which is odd.


Archit
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html