Re: [PATCH 1/1] ARM:OMAP3: Smartreflex disable/enable fix
* Kalle Jokiniemi <[EMAIL PROTECTED]> [080829 04:54]: > On pe, 2008-08-29 at 11:47 +0100, ext Russell King - ARM Linux wrote: > > On Fri, Aug 29, 2008 at 01:05:44PM +0300, Kalle Jokiniemi wrote: > > > Smartreflex modules have to be disabled when device enters WFI. > > > Previously only suspend idle path had these calls. By moving the > > > disable/enable calls to omap_sram_idle, all idle paths will be covered. > > > > Won't deleting the calls from the suspend path break suspend/resume? > > No, since omap3_pm_suspend calls omap_sram_idle. The disabling is just > moves one step later. Also omap3_pm_idle and the idle loop in cpu idle > call omap_sram_idle, so they get covered as well. Pushing today. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] ARM:OMAP3: Smartreflex disable/enable fix
On pe, 2008-08-29 at 11:47 +0100, ext Russell King - ARM Linux wrote: > On Fri, Aug 29, 2008 at 01:05:44PM +0300, Kalle Jokiniemi wrote: > > Smartreflex modules have to be disabled when device enters WFI. > > Previously only suspend idle path had these calls. By moving the > > disable/enable calls to omap_sram_idle, all idle paths will be covered. > > Won't deleting the calls from the suspend path break suspend/resume? No, since omap3_pm_suspend calls omap_sram_idle. The disabling is just moves one step later. Also omap3_pm_idle and the idle loop in cpu idle call omap_sram_idle, so they get covered as well. regards, Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] ARM:OMAP3: Smartreflex disable/enable fix
On Fri, Aug 29, 2008 at 01:05:44PM +0300, Kalle Jokiniemi wrote: > Smartreflex modules have to be disabled when device enters WFI. > Previously only suspend idle path had these calls. By moving the > disable/enable calls to omap_sram_idle, all idle paths will be covered. Won't deleting the calls from the suspend path break suspend/resume? -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
