Re: [PATCH 1/3] i2c: lp5521: remove dead code

2008-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2008 at 12:47:22PM +0300, Daniel Stone wrote:
> On Mon, Oct 06, 2008 at 12:11:29PM +0300, ext Felipe Balbi wrote:
> > That LED_CONNECTED_WRONG was never defined so removing.
> > If someone needs those hooks, add back via proper
> > platform_data instead of nasty ifdefery.
> > 
> > Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]>
> 
> Signed-off-by: Daniel Stone <[EMAIL PROTECTED]>
> 
> IIRC, LED_CONNECTED_WRONG was only for early hardware builds of the
> N810.

yeah and it's really weird to keep that since it was a bad hw mistake
:-p

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/3] i2c: lp5521: remove dead code

2008-10-06 Thread Daniel Stone
On Mon, Oct 06, 2008 at 12:11:29PM +0300, ext Felipe Balbi wrote:
> That LED_CONNECTED_WRONG was never defined so removing.
> If someone needs those hooks, add back via proper
> platform_data instead of nasty ifdefery.
> 
> Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]>

Signed-off-by: Daniel Stone <[EMAIL PROTECTED]>

IIRC, LED_CONNECTED_WRONG was only for early hardware builds of the
N810.

Cheers,
Daniel


signature.asc
Description: Digital signature