Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's
On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote: From: George Cherian george.cher...@ti.com Convert the driver to use gpiod_* API's. Reviewed-by: Roger Quadros rog...@ti.com Signed-off-by: George Cherian george.cher...@ti.com Signed-off-by: Sekhar Nori nsek...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com --- I think it might be useful and appropriate to explain that and why you remove support for active-low pins, instead of hiding it in a seemingly unrelated patch. Also, since you don't use the platform data flag anymore, you might as well remove it to give out-of-tree users a fair warning. Overall, it might be easier to just revert the patch introducing it (5bfbdc9caa7) before converting extcon to gpiod. I am just glad that we stopped using extcon for other reasons ;-) Guenter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's
On Mon, Nov 03, 2014 at 10:01:50AM -0800, Guenter Roeck wrote: On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote: From: George Cherian george.cher...@ti.com Convert the driver to use gpiod_* API's. Reviewed-by: Roger Quadros rog...@ti.com Signed-off-by: George Cherian george.cher...@ti.com Signed-off-by: Sekhar Nori nsek...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com --- I think it might be useful and appropriate to explain that and why you remove support for active-low pins, instead of hiding it in a seemingly unrelated patch. removed ? why removed ? gpio descs handle that for you, read the source code. -- balbi signature.asc Description: Digital signature
Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's
On Mon, Nov 03, 2014 at 12:06:02PM -0600, Felipe Balbi wrote: On Mon, Nov 03, 2014 at 10:01:50AM -0800, Guenter Roeck wrote: On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote: From: George Cherian george.cher...@ti.com Convert the driver to use gpiod_* API's. Reviewed-by: Roger Quadros rog...@ti.com Signed-off-by: George Cherian george.cher...@ti.com Signed-off-by: Sekhar Nori nsek...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com --- I think it might be useful and appropriate to explain that and why you remove support for active-low pins, instead of hiding it in a seemingly unrelated patch. removed ? why removed ? gpio descs handle that for you, read the source code. Well, it for sure looks like it. Care to explain that in the patch, as well as how the platform data flag is used ? Thanks, Guenter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's
Hi, On Mon, Nov 03, 2014 at 10:51:08AM -0800, Guenter Roeck wrote: On Mon, Nov 03, 2014 at 12:06:02PM -0600, Felipe Balbi wrote: On Mon, Nov 03, 2014 at 10:01:50AM -0800, Guenter Roeck wrote: On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote: From: George Cherian george.cher...@ti.com Convert the driver to use gpiod_* API's. Reviewed-by: Roger Quadros rog...@ti.com Signed-off-by: George Cherian george.cher...@ti.com Signed-off-by: Sekhar Nori nsek...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com --- I think it might be useful and appropriate to explain that and why you remove support for active-low pins, instead of hiding it in a seemingly unrelated patch. removed ? why removed ? gpio descs handle that for you, read the source code. Well, it for sure looks like it. Care to explain that in the patch, as well as how the platform data flag is used ? I'll leave that to $author, I just cherry-picked and tested them. Certainly that commit log needs some love. -- balbi signature.asc Description: Digital signature
