Re: [PATCH 1/5] OMAP2xxx: HWMOD: fix DSS opt clocks

2011-08-23 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [110821 08:11]:
 From: Tomi Valkeinen tomi.valkei...@ti.com
 
 Set HWMOD_CONTROL_OPT_CLKS_IN_RESET for dss_core to allow DSS reset
 properly.

Can you please add what this fixes so this can be justified as a fix?
 
 Add missing ick opt-clock for rfbi. Rfbi uses the ick to calculate
 timings.

Here too.
 
 Fix the venc iclk and fclk.

And here.

Regards,

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/5] OMAP2xxx: HWMOD: fix DSS opt clocks

2011-08-23 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [110823 09:20]:
 * Paul Walmsley p...@pwsan.com [110821 08:11]:
  From: Tomi Valkeinen tomi.valkei...@ti.com
  
  Set HWMOD_CONTROL_OPT_CLKS_IN_RESET for dss_core to allow DSS reset
  properly.
 
 Can you please add what this fixes so this can be justified as a fix?
  
  Add missing ick opt-clock for rfbi. Rfbi uses the ick to calculate
  timings.
 
 Here too.
  
  Fix the venc iclk and fclk.
 
 And here.

Looks like the comments for the whole series should be improved
so it's clear to everybody what issues these fix and what caused
the breakage.

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/5] OMAP2xxx: HWMOD: fix DSS opt clocks

2011-08-23 Thread Paul Walmsley
Hi Tomi,

On Tue, 23 Aug 2011, Tony Lindgren wrote:

 * Paul Walmsley p...@pwsan.com [110821 08:11]:
  From: Tomi Valkeinen tomi.valkei...@ti.com
  
  Set HWMOD_CONTROL_OPT_CLKS_IN_RESET for dss_core to allow DSS reset
  properly.
 
 Can you please add what this fixes so this can be justified as a fix?
  
  Add missing ick opt-clock for rfbi. Rfbi uses the ick to calculate
  timings.
 
 Here too.
  
  Fix the venc iclk and fclk.
 
 And here.

Could you please update the patch changelogs per Tony's request?

thanks,

- Paul
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html