Re: [PATCH 16/25] OMAP4: PM: Program CPU1 to hit OFF when off-lined

2011-09-12 Thread Kevin Hilman
Santosh Shilimkar santosh.shilim...@ti.com writes:

 Program non-boot CPUs to hit lowest supported power state
 when it is off-lined using cpu hotplug framework.

 Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com
 Cc: Kevin Hilman khil...@ti.com

[...]

 @@ -39,15 +43,15 @@ void platform_cpu_die(unsigned int cpu)
* we're ready for shutdown now, so do it
*/
   if (omap_modify_auxcoreboot0(0x0, 0x200) != 0x0)
 - printk(KERN_CRIT Secure clear status failed\n);
 + pr_err(Secure clear status failed\n);

nit: pr_crit() exists if you want to keep the same level.  Or did you
lower the level on purpose?

Kevin

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 16/25] OMAP4: PM: Program CPU1 to hit OFF when off-lined

2011-09-12 Thread Santosh

On Tuesday 13 September 2011 02:42 AM, Kevin Hilman wrote:

Santosh Shilimkarsantosh.shilim...@ti.com  writes:


Program non-boot CPUs to hit lowest supported power state
when it is off-lined using cpu hotplug framework.

Signed-off-by: Santosh Shilimkarsantosh.shilim...@ti.com
Cc: Kevin Hilmankhil...@ti.com


[...]


@@ -39,15 +43,15 @@ void platform_cpu_die(unsigned int cpu)
 * we're ready for shutdown now, so do it
 */
if (omap_modify_auxcoreboot0(0x0, 0x200) != 0x0)
-   printk(KERN_CRIT Secure clear status failed\n);
+   pr_err(Secure clear status failed\n);


nit: pr_crit() exists if you want to keep the same level.  Or did you
lower the level on purpose?


I lowered it on purpose since I didn't find it crtical.

Regards
Santosh
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html