Re: [PATCH 3/3] ARM: OMAP2+: Add machine entry for dra72x devices

[Rajendra Nayak]

On Saturday 15 March 2014 07:51 AM, Suman Anna wrote:
> Hi Rajendra,
> 
> On 03/14/2014 04:20 AM, Nayak, Rajendra wrote:
>> The only difference from the dra75x devices is the missing .smp entry.
>>
>> Signed-off-by: Rajendra Nayak 
>> ---
>>   arch/arm/mach-omap2/board-generic.c |   18 ++
>>   1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/mach-omap2/board-generic.c 
>> b/arch/arm/mach-omap2/board-generic.c
>> index 8e3daa1..d803d99 100644
>> --- a/arch/arm/mach-omap2/board-generic.c
>> +++ b/arch/arm/mach-omap2/board-generic.c
>> @@ -253,4 +253,22 @@ DT_MACHINE_START(DRA7XX_DT, "Generic DRA7XX (Flattened 
>> Device Tree)")
>>   .dt_compat= dra7xx_boards_compat,
>>   .restart= omap44xx_restart,
>>   MACHINE_END
>> +
>> +static const char *dra72_boards_compat[] __initdata = {
> 
> How about using dra72x_ instead of dra72_ and keeping it consistent
> at the other places as well?

Sure, I can do that. Thanks.

> 
> regards
> Suman
> 
>> +"ti,dra72x",
>> +"ti,dra7",
>> +NULL,
>> +};
>> +
>> +DT_MACHINE_START(DRA72_DT, "Generic DRA72 (Flattened Device Tree)")
>> +.reserve= omap_reserve,
>> +.map_io= omap5_map_io,
>> +.init_early= dra7xx_init_early,
>> +.init_late= dra7xx_init_late,
>> +.init_irq= omap_gic_of_init,
>> +.init_machine= omap_generic_init,
>> +.init_time= omap5_realtime_timer_init,
>> +.dt_compat= dra72_boards_compat,
>> +.restart= omap44xx_restart,
>> +MACHINE_END
>>   #endif
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] ARM: OMAP2+: Add machine entry for dra72x devices

[Suman Anna]

Hi Rajendra,

On 03/14/2014 04:20 AM, Nayak, Rajendra wrote:

The only difference from the dra75x devices is the missing .smp entry.

Signed-off-by: Rajendra Nayak 
---
  arch/arm/mach-omap2/board-generic.c |   18 ++
  1 file changed, 18 insertions(+)

diff --git a/arch/arm/mach-omap2/board-generic.c 
b/arch/arm/mach-omap2/board-generic.c
index 8e3daa1..d803d99 100644
--- a/arch/arm/mach-omap2/board-generic.c
+++ b/arch/arm/mach-omap2/board-generic.c
@@ -253,4 +253,22 @@ DT_MACHINE_START(DRA7XX_DT, "Generic DRA7XX (Flattened Device 
Tree)")
.dt_compat  = dra7xx_boards_compat,
.restart= omap44xx_restart,
  MACHINE_END
+
+static const char *dra72_boards_compat[] __initdata = {


How about using dra72x_ instead of dra72_ and keeping it consistent
at the other places as well?

regards
Suman


+   "ti,dra72x",
+   "ti,dra7",
+   NULL,
+};
+
+DT_MACHINE_START(DRA72_DT, "Generic DRA72 (Flattened Device Tree)")
+   .reserve= omap_reserve,
+   .map_io = omap5_map_io,
+   .init_early = dra7xx_init_early,
+   .init_late  = dra7xx_init_late,
+   .init_irq   = omap_gic_of_init,
+   .init_machine   = omap_generic_init,
+   .init_time  = omap5_realtime_timer_init,
+   .dt_compat  = dra72_boards_compat,
+   .restart= omap44xx_restart,
+MACHINE_END
  #endif



--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html