Re: [PATCH 3/4] ARM: OMAP3: Switch to use the unified audio driver (omap-twl4030) for selected boards
* Peter Ujfalusi peter.ujfal...@ti.com [120808 02:54]: These boards have similar audio setup and they can all use the same driver for audio support if it is enabled in the kernel config. After the naming changes suggested by Igor: Acked-by: Tony Lindgren t...@atomide.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/4] ARM: OMAP3: Switch to use the unified audio driver (omap-twl4030) for selected boards
On 08/08/2012 04:06 PM, Igor Grinberg wrote: Well, yes I know we will need to adjust the user space. I wanted to change that for a long time and did not get to it... Now, with your patches, it seems like the best time for doing this. Done for the v2. You will have card named cm-t3x. -- Péter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/4] ARM: OMAP3: Switch to use the unified audio driver (omap-twl4030) for selected boards
On 08/09/12 13:21, Peter Ujfalusi wrote: On 08/08/2012 04:06 PM, Igor Grinberg wrote: Well, yes I know we will need to adjust the user space. I wanted to change that for a long time and did not get to it... Now, with your patches, it seems like the best time for doing this. Done for the v2. You will have card named cm-t3x. Thanks! -- Regards, Igor. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/4] ARM: OMAP3: Switch to use the unified audio driver (omap-twl4030) for selected boards
Hi Peter, Thank you very much for the patch series. I probably will have some time to look into it more deeply on the next week. Currently, only a small comment, please see below. On 08/08/12 12:54, Peter Ujfalusi wrote: These boards have similar audio setup and they can all use the same driver for audio support if it is enabled in the kernel config. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-omap2/board-cm-t35.c |1 + arch/arm/mach-omap2/board-devkit8000.c |1 + arch/arm/mach-omap2/board-igep0020.c|1 + arch/arm/mach-omap2/board-omap3beagle.c |1 + arch/arm/mach-omap2/board-omap3evm.c|1 + arch/arm/mach-omap2/board-overo.c |1 + 6 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c index 97d7190..b73fa5c 100644 --- a/arch/arm/mach-omap2/board-cm-t35.c +++ b/arch/arm/mach-omap2/board-cm-t35.c @@ -731,6 +731,7 @@ static void __init cm_t3x_common_init(void) cm_t35_init_ethernet(); cm_t35_init_led(); cm_t35_init_display(); + omap_twl4030_audio_init(overo, 2600); Can the card_name here be cm-t3x ? [...] -- Regards, Igor. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/4] ARM: OMAP3: Switch to use the unified audio driver (omap-twl4030) for selected boards
Hi Igor, On 08/08/2012 03:24 PM, Igor Grinberg wrote: diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c index 97d7190..b73fa5c 100644 --- a/arch/arm/mach-omap2/board-cm-t35.c +++ b/arch/arm/mach-omap2/board-cm-t35.c @@ -731,6 +731,7 @@ static void __init cm_t3x_common_init(void) cm_t35_init_ethernet(); cm_t35_init_led(); cm_t35_init_display(); +omap_twl4030_audio_init(overo, 2600); Can the card_name here be cm-t3x ? I have used the overo as card name here since what I gathered is that cm-t35 used the sound/soc/omap/overo.c machine driver for audio support. If the card name is changing your existing user space might get confused by the card name change. But sure, I can change the card name to cm-t3x if it is better for you. -- Péter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/4] ARM: OMAP3: Switch to use the unified audio driver (omap-twl4030) for selected boards
On 08/08/12 15:29, Peter Ujfalusi wrote: Hi Igor, On 08/08/2012 03:24 PM, Igor Grinberg wrote: diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c index 97d7190..b73fa5c 100644 --- a/arch/arm/mach-omap2/board-cm-t35.c +++ b/arch/arm/mach-omap2/board-cm-t35.c @@ -731,6 +731,7 @@ static void __init cm_t3x_common_init(void) cm_t35_init_ethernet(); cm_t35_init_led(); cm_t35_init_display(); + omap_twl4030_audio_init(overo, 2600); Can the card_name here be cm-t3x ? I have used the overo as card name here since what I gathered is that cm-t35 used the sound/soc/omap/overo.c machine driver for audio support. If the card name is changing your existing user space might get confused by the card name change. But sure, I can change the card name to cm-t3x if it is better for you. Well, yes I know we will need to adjust the user space. I wanted to change that for a long time and did not get to it... Now, with your patches, it seems like the best time for doing this. Thanks -- Regards, Igor. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
