Re: [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon
Hi Felipe, David, On Tue, 14 Oct 2008 14:44:51 -0700, David Brownell wrote: > On Tuesday 14 October 2008, Felipe Balbi wrote: > > I'd say that if it goes to the "wrong" place and doesn't bother anyone, > > will get forgotten. Just like the whole bunch of other drivers sitting > > in linux-omap... You're not merging drivers upstream just to bother people, are you? There's nothing wrong with drivers being forgotten. Each driver gets the level of attention it deserves depending on how broken and useful it is. > I thought the point was to have them sit in mainline. ;) > > > Funny that most of such drivers are for nokia tablets :-p > > Some of these drivers are first-of-a-kind, so these questions wouldn't > necessarily have come up before. That's one of the obstacles to > mainline merge that isn't always acknowledged. Well, as you said before, it seems we have drivers/misc exactly for that case. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon
On Tue, Oct 14, 2008 at 02:44:51PM -0700, David Brownell wrote: > On Tuesday 14 October 2008, Felipe Balbi wrote: > > I'd say that if it goes to the "wrong" place and doesn't bother anyone, > > will get forgotten. Just like the whole bunch of other drivers sitting > > in linux-omap... > > I thought the point was to have them sit in mainline. ;) Exactly :-) > Some of these drivers are first-of-a-kind, so these questions wouldn't > necessarily have come up before. That's one of the obstacles to > mainline merge that isn't always acknowledged. That's also true, but then again most of those drivers got forgotten and never made their way to mainline. If you look at mainline archives, you'll see that most of omap drivers never "tried" to go upstream. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon
On Tuesday 14 October 2008, Felipe Balbi wrote: > I'd say that if it goes to the "wrong" place and doesn't bother anyone, > will get forgotten. Just like the whole bunch of other drivers sitting > in linux-omap... I thought the point was to have them sit in mainline. ;) > Funny that most of such drivers are for nokia tablets :-p Some of these drivers are first-of-a-kind, so these questions wouldn't necessarily have come up before. That's one of the obstacles to mainline merge that isn't always acknowledged. - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon
On Tue, Oct 14, 2008 at 09:00:55AM -0700, David Brownell wrote: > On Tuesday 14 October 2008, Felipe Balbi wrote: > > > > > Nack. Light sensors have nothing to do with hardware monitoring. > > > > > > The only light sensor driver in the kernel tree at the moment > > > is drivers/i2c/chips/tsl2550.c. But I'm not very happy with this > > > either, as my ultimate goal is to delete the drivers/i2c/chips > > > directory completely. So we should find a new home for light sensors. > > > > and that's why I'm moving nokia drivers out of drivers/i2c/chips > > directory. > > > > > Maybe they should go into the new "industrial I/O" subsystem. Or if > > > not, their own drivers/sensors/light directory. > > > > Well, could be. We might need someone else, like Andrew, to answer that > > question. > > My two cents: leave them where they are until a "good" answer exists. > Or if drivers/i2c/chips is sufficiently annoying ... drivers/misc may > be a good interim site. I'd say that if it goes to the "wrong" place and doesn't bother anyone, will get forgotten. Just like the whole bunch of other drivers sitting in linux-omap. They don't bother anyone (probably they bother Tony when API changes upstream and a few defconfigs don't build anymore) so they got forgotten and still sitting in linux-omap. Funny that most of such drivers are for nokia tablets :-p -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon
On Tuesday 14 October 2008, Felipe Balbi wrote: > > > Nack. Light sensors have nothing to do with hardware monitoring. > > > > The only light sensor driver in the kernel tree at the moment > > is drivers/i2c/chips/tsl2550.c. But I'm not very happy with this > > either, as my ultimate goal is to delete the drivers/i2c/chips > > directory completely. So we should find a new home for light sensors. > > and that's why I'm moving nokia drivers out of drivers/i2c/chips > directory. > > > Maybe they should go into the new "industrial I/O" subsystem. Or if > > not, their own drivers/sensors/light directory. > > Well, could be. We might need someone else, like Andrew, to answer that > question. My two cents: leave them where they are until a "good" answer exists. Or if drivers/i2c/chips is sufficiently annoying ... drivers/misc may be a good interim site. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon
On Tue, Oct 14, 2008 at 04:14:26PM +0200, ext Jean Delvare wrote: > I've implied a sysfs interface with my tsl2550 driver, essentially > derived from the hwmon sysfs interface. I hope you followed it in your > driver if possible. When these drivers have a new home, we can document > the sysfs interface. Or, if these drivers end up in the industrial I/O > subsystem, maybe a completely different interface will be used instead > (but then it's in Jonathan's hands.) Hmm, I didn't really write the driver, I'm just fixing a few stuff to prepare for submission to mainline. If we end up with your sysfs interface, I can change that, no problem. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon
On Tue, 14 Oct 2008 16:52:30 +0300, Felipe Balbi wrote:
> On Tue, Oct 14, 2008 at 03:38:24PM +0200, ext Jean Delvare wrote:
> > Hi Felipe,
> >
> > On Tue, 14 Oct 2008 16:01:38 +0300, Felipe Balbi wrote:
> > > Moving the driver to where it should sit. No functional
> > > changes.
> > >
> > > Cc: Jean Delvare <[EMAIL PROTECTED]>
> > > Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]>
> > > ---
> > > drivers/hwmon/Kconfig | 10 ++
> > > drivers/hwmon/Makefile |1 +
> > > drivers/{i2c/chips => hwmon}/tsl2563.c |2 +-
> > > drivers/i2c/chips/Kconfig | 10 --
> > > drivers/i2c/chips/Makefile |1 -
> > > 5 files changed, 12 insertions(+), 12 deletions(-)
> > > rename drivers/{i2c/chips => hwmon}/tsl2563.c (99%)
> > >
> > > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> > > index 390c6fa..dabc148 100644
> > > --- a/drivers/hwmon/Kconfig
> > > +++ b/drivers/hwmon/Kconfig
> > > @@ -670,6 +670,16 @@ config SENSORS_THMC50
> > > This driver can also be built as a module. If so, the module
> > > will be called thmc50.
> > >
> > > +config SENSORS_TSL2563
> > > + tristate "Taos TSL2563 ambient light sensor"
> > > + depends on I2C && HWMON
> > > + help
> > > + If you say yes here you get support for the Taos TSL2563
> > > + ambient light sensor.
> > > +
> > > + This driver can also be built as a module. If so, the module
> > > + will be called tsl2563.
> > > +
> > > config SENSORS_VIA686A
> > > tristate "VIA686A"
> > > depends on PCI
> >
> > Nack. Light sensors have nothing to do with hardware monitoring.
> >
> > The only light sensor driver in the kernel tree at the moment
> > is drivers/i2c/chips/tsl2550.c. But I'm not very happy with this
> > either, as my ultimate goal is to delete the drivers/i2c/chips
> > directory completely. So we should find a new home for light sensors.
>
> and that's why I'm moving nokia drivers out of drivers/i2c/chips
> directory.
>
> > Maybe they should go into the new "industrial I/O" subsystem. Or if
> > not, their own drivers/sensors/light directory.
>
> Well, could be. We might need someone else, like Andrew, to answer that
> question.
I'd rather ask the question to Jonathan Cameron (Cc'd.)
> Andrew, do you have any comments if we should create a directory for
> light sensors ? In that case, looks like we're gonna need some
> abstraction layer, right ?
I've implied a sysfs interface with my tsl2550 driver, essentially
derived from the hwmon sysfs interface. I hope you followed it in your
driver if possible. When these drivers have a new home, we can document
the sysfs interface. Or, if these drivers end up in the industrial I/O
subsystem, maybe a completely different interface will be used instead
(but then it's in Jonathan's hands.)
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon
On Tue, Oct 14, 2008 at 03:38:24PM +0200, ext Jean Delvare wrote:
> Hi Felipe,
>
> On Tue, 14 Oct 2008 16:01:38 +0300, Felipe Balbi wrote:
> > Moving the driver to where it should sit. No functional
> > changes.
> >
> > Cc: Jean Delvare <[EMAIL PROTECTED]>
> > Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]>
> > ---
> > drivers/hwmon/Kconfig | 10 ++
> > drivers/hwmon/Makefile |1 +
> > drivers/{i2c/chips => hwmon}/tsl2563.c |2 +-
> > drivers/i2c/chips/Kconfig | 10 --
> > drivers/i2c/chips/Makefile |1 -
> > 5 files changed, 12 insertions(+), 12 deletions(-)
> > rename drivers/{i2c/chips => hwmon}/tsl2563.c (99%)
> >
> > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> > index 390c6fa..dabc148 100644
> > --- a/drivers/hwmon/Kconfig
> > +++ b/drivers/hwmon/Kconfig
> > @@ -670,6 +670,16 @@ config SENSORS_THMC50
> > This driver can also be built as a module. If so, the module
> > will be called thmc50.
> >
> > +config SENSORS_TSL2563
> > + tristate "Taos TSL2563 ambient light sensor"
> > + depends on I2C && HWMON
> > + help
> > + If you say yes here you get support for the Taos TSL2563
> > + ambient light sensor.
> > +
> > + This driver can also be built as a module. If so, the module
> > + will be called tsl2563.
> > +
> > config SENSORS_VIA686A
> > tristate "VIA686A"
> > depends on PCI
>
> Nack. Light sensors have nothing to do with hardware monitoring.
>
> The only light sensor driver in the kernel tree at the moment
> is drivers/i2c/chips/tsl2550.c. But I'm not very happy with this
> either, as my ultimate goal is to delete the drivers/i2c/chips
> directory completely. So we should find a new home for light sensors.
and that's why I'm moving nokia drivers out of drivers/i2c/chips
directory.
> Maybe they should go into the new "industrial I/O" subsystem. Or if
> not, their own drivers/sensors/light directory.
Well, could be. We might need someone else, like Andrew, to answer that
question.
Andrew, do you have any comments if we should create a directory for
light sensors ? In that case, looks like we're gonna need some
abstraction layer, right ?
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] tsl2563: move tsl2563 to drivers/hwmon
Hi Felipe,
On Tue, 14 Oct 2008 16:01:38 +0300, Felipe Balbi wrote:
> Moving the driver to where it should sit. No functional
> changes.
>
> Cc: Jean Delvare <[EMAIL PROTECTED]>
> Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]>
> ---
> drivers/hwmon/Kconfig | 10 ++
> drivers/hwmon/Makefile |1 +
> drivers/{i2c/chips => hwmon}/tsl2563.c |2 +-
> drivers/i2c/chips/Kconfig | 10 --
> drivers/i2c/chips/Makefile |1 -
> 5 files changed, 12 insertions(+), 12 deletions(-)
> rename drivers/{i2c/chips => hwmon}/tsl2563.c (99%)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 390c6fa..dabc148 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -670,6 +670,16 @@ config SENSORS_THMC50
> This driver can also be built as a module. If so, the module
> will be called thmc50.
>
> +config SENSORS_TSL2563
> + tristate "Taos TSL2563 ambient light sensor"
> + depends on I2C && HWMON
> + help
> + If you say yes here you get support for the Taos TSL2563
> + ambient light sensor.
> +
> + This driver can also be built as a module. If so, the module
> + will be called tsl2563.
> +
> config SENSORS_VIA686A
> tristate "VIA686A"
> depends on PCI
Nack. Light sensors have nothing to do with hardware monitoring.
The only light sensor driver in the kernel tree at the moment
is drivers/i2c/chips/tsl2550.c. But I'm not very happy with this
either, as my ultimate goal is to delete the drivers/i2c/chips
directory completely. So we should find a new home for light sensors.
Maybe they should go into the new "industrial I/O" subsystem. Or if
not, their own drivers/sensors/light directory.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
