Re: [PATCH v1 3/3] ARM:OMAP4 iommu:provide build support for omap4 iommu

2009-08-05 Thread Russell King - ARM Linux
On Wed, Aug 05, 2009 at 07:35:38AM +0300, Hiroshi DOYU wrote:
 From: ext Russell King - ARM Linux li...@arm.linux.org.uk
 Subject: Re: [PATCH v1 3/3] ARM:OMAP4 iommu:provide build support for omap4 
 iommu
 Date: Wed, 5 Aug 2009 00:42:41 +0200
 
  On Tue, Aug 04, 2009 at 05:32:12PM -0500, Kanigeri, Hari wrote:
   diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
   index efe85d0..50aaefb 100644
   --- a/arch/arm/plat-omap/Kconfig
   +++ b/arch/arm/plat-omap/Kconfig
   @@ -118,8 +118,11 @@ config OMAP_MBOX_FWK
   DSP, IVA1.0 and IVA2 in OMAP1/2/3.

config OMAP_IOMMU
   - tristate
   -
   + tristate iommu
  
  Insufficiently verbose description.  OMAP IOMMU Support would be
  better.  I thought the idea here was to arrange for things to select
  OMAP_IOMMU when they require it rather than offering it as a separate
  configuration option.
  
  The former way has the advantage that you don't need to know that you
  need IOMMU support to (eg) use the Camera - enabling the Camera
  should automatically enable IOMMU support.
 
 The following is the original discussion.
 
 http://lists.arm.linux.org.uk/lurker/message/20090518.130233.3f238e72.en.html

Quite.  I'm repeating myself.  So the question is why the original
discussion didn't produce a change.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PATCH v1 3/3] ARM:OMAP4 iommu:provide build support for omap4 iommu

2009-08-05 Thread Kanigeri, Hari
Hi Russell and Hiroshi,

Thanks for your comments. Please see my below comments.

 -Original Message-
 From: Hiroshi DOYU [mailto:hiroshi.d...@nokia.com]
 Sent: Tuesday, August 04, 2009 11:36 PM
 To: Kanigeri, Hari
 Cc: linux-omap@vger.kernel.org; t...@atomide.com; li...@arm.linux.org.uk;
 Shilimkar, Santosh
 Subject: Re: [PATCH v1 3/3] ARM:OMAP4 iommu:provide build support for
 omap4 iommu
 
 From: ext Russell King - ARM Linux li...@arm.linux.org.uk
 Subject: Re: [PATCH v1 3/3] ARM:OMAP4 iommu:provide build support for
 omap4 iommu
 Date: Wed, 5 Aug 2009 00:42:41 +0200
 
  On Tue, Aug 04, 2009 at 05:32:12PM -0500, Kanigeri, Hari wrote:
   diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
   index efe85d0..50aaefb 100644
   --- a/arch/arm/plat-omap/Kconfig
   +++ b/arch/arm/plat-omap/Kconfig
   @@ -118,8 +118,11 @@ config OMAP_MBOX_FWK
   DSP, IVA1.0 and IVA2 in OMAP1/2/3.
  
config OMAP_IOMMU
   - tristate
   -
   + tristate iommu
 
  Insufficiently verbose description.  OMAP IOMMU Support would be
  better.  I thought the idea here was to arrange for things to select
  OMAP_IOMMU when they require it rather than offering it as a separate
  configuration option.
 
  The former way has the advantage that you don't need to know that you
  need IOMMU support to (eg) use the Camera - enabling the Camera
  should automatically enable IOMMU support.
 
 The following is the original discussion.
 
 http://lists.arm.linux.org.uk/lurker/message/20090518.130233.3f238e72.en.h
 tml

-- I agree with your comments from OMAP3 point of view. 
For OMAP4, I guess Camera is not going to use IOMMU module. IOMMU modules will 
be used only by the IPC that are communicating with 2 remote Cores (Ducati and 
Tesla). Having said this, there might not be any clients of IOMMU in the Kernel 
space as we are looking at the option of using the IOMMU as a character driver 
from User-space. For this reason, I think we should have the configuration 
option to build iommu. Please let me know your comments.

Thank you,
Best regards,
Hari


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v1 3/3] ARM:OMAP4 iommu:provide build support for omap4 iommu

2009-08-04 Thread Russell King - ARM Linux
On Tue, Aug 04, 2009 at 05:32:12PM -0500, Kanigeri, Hari wrote:
 diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
 index efe85d0..50aaefb 100644
 --- a/arch/arm/plat-omap/Kconfig
 +++ b/arch/arm/plat-omap/Kconfig
 @@ -118,8 +118,11 @@ config OMAP_MBOX_FWK
 DSP, IVA1.0 and IVA2 in OMAP1/2/3.
  
  config OMAP_IOMMU
 - tristate
 -
 + tristate iommu

Insufficiently verbose description.  OMAP IOMMU Support would be
better.  I thought the idea here was to arrange for things to select
OMAP_IOMMU when they require it rather than offering it as a separate
configuration option.

The former way has the advantage that you don't need to know that you
need IOMMU support to (eg) use the Camera - enabling the Camera
should automatically enable IOMMU support.


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html