Re: [PATCH v2] omap4: i2c: add post idle reset registers flag

2011-11-08 Thread Kevin Hilman 
Shubhrajyoti  writes:

> On Tuesday 08 November 2011 03:01 AM, David Anders wrote:
>> omap44xx i2c devices need to have the registers reset post idle
>> similar to omap3xxx devices. this adds the additional flag for
>> OMAP_I2C_FLAG_RESET_REGS_POSTIDLE to the omap44xx i2c_dev_attr.
>
> Hello Anders a similar patch is already posted
> http://www.spinics.net/lists/linux-i2c/msg05913.html

Benoit/Paul,

Can one of you queue the original hwmod data fix from Shubhrajyoti (link
above) for v3.2-rc1?

Thanks,

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] omap4: i2c: add post idle reset registers flag

2011-11-08 Thread David Anders 

On 11/08/2011 02:11 AM, Shubhrajyoti wrote:

On Tuesday 08 November 2011 03:01 AM, David Anders wrote:
   

omap44xx i2c devices need to have the registers reset post idle
similar to omap3xxx devices. this adds the additional flag for
OMAP_I2C_FLAG_RESET_REGS_POSTIDLE to the omap44xx i2c_dev_attr.
 

Hello Anders a similar patch is already posted
http://www.spinics.net/lists/linux-i2c/msg05913.html

   


oops, i did a quick search of the mailing lists but didn't see your 
patch, so submitted this one.


are you going to babysit this one through?


Signed-off-by: David Anders
---
  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c 
b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 7695e5d..e93dc40 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -2257,7 +2257,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = 
{
  };

  static struct omap_i2c_dev_attr i2c_dev_attr = {
-   .flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
+   .flags  = OMAP_I2C_FLAG_RESET_REGS_POSTIDLE |
+ OMAP_I2C_FLAG_BUS_SHIFT_NONE,
  };

  /* i2c1 */
 
   


Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] omap4: i2c: add post idle reset registers flag

2011-11-08 Thread Shubhrajyoti 
On Tuesday 08 November 2011 03:01 AM, David Anders wrote:
> omap44xx i2c devices need to have the registers reset post idle
> similar to omap3xxx devices. this adds the additional flag for
> OMAP_I2C_FLAG_RESET_REGS_POSTIDLE to the omap44xx i2c_dev_attr.
Hello Anders a similar patch is already posted
http://www.spinics.net/lists/linux-i2c/msg05913.html

> Signed-off-by: David Anders 
> ---
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c 
> b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index 7695e5d..e93dc40 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -2257,7 +2257,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class 
> = {
>  };
>  
>  static struct omap_i2c_dev_attr i2c_dev_attr = {
> - .flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
> + .flags  = OMAP_I2C_FLAG_RESET_REGS_POSTIDLE |
> +   OMAP_I2C_FLAG_BUS_SHIFT_NONE,
>  };
>  
>  /* i2c1 */

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html