Re: [PATCH v2 0/4] ARM: OMAP2+: dmtimer: cleanup related to devm API and clk usage
* DebBarma, Tarun Kanti [120705 04:46]: > > Patch 3: Comment was about adding summary in patch 0/x why we have > not removed iclk in OMAP2/3 platform. In other words there was no > specific changes needed on patch 3 as such. BTW, patch 3 is already merged. ... > I will rebase on top of cleanup-part2 are repost patch 4. OK thanks! Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/4] ARM: OMAP2+: dmtimer: cleanup related to devm API and clk usage
Hi Tony, On Thu, Jul 5, 2012 at 2:58 PM, Tony Lindgren wrote: > * DebBarma, Tarun Kanti [120704 21:07]: >> On Thu, Jun 14, 2012 at 4:28 PM, Shilimkar, Santosh >> wrote: >> > >> > Just to let you know that this cleanup is essential for Benoit's OMAP4 >> > hwmod cleanup >> > and OMAP5 minimal support series. >> >> This is a gentle reminder in case you have missed somehow!! >> Let me know if anything else needs to be done. > > Now with the hwmod patch 2/4 pulled into cleanup-part2 from Paul, > I've also applied patch 1/4 there. Patches 3 and 4 have still some pending > comments from Kevin it seems? Yes > > Also at least patch 3 won't apply, so please check Kevin's comments > and repost patches 3 and 4 on top of cleanup-part2 at commit 74dd9ec62. Patch 3: Comment was about adding summary in patch 0/x why we have not removed iclk in OMAP2/3 platform. In other words there was no specific changes needed on patch 3 as such. BTW, patch 3 is already merged. Patch 4: --- [Kevin's comment] --- >> >> Comment applies to PATCH 4/4 also. > You mean removing iclk from clkdev table? That is already done in this patch!! I meant why can't OMAP2/3 data be removed in PATCH 4/4 also, which only touches OMAP4. --- [end] --- In patch 4 the only change done in the clock table was to correct the name mis-match of functional clock names for OMAP4 between clock data and hwmod data. For OMAP2/3 the names are already matching. As the comment was given in patch 3 where iclk entries got removed for OMAP4, he must have expected similar cleanup is done for fclk in patch 4. But as I said, only the name mis-match is corrected. In summary, there is no specific changes needed in the patch. I will rebase on top of cleanup-part2 are repost patch 4. -- Tarun > > Regards, > > Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/4] ARM: OMAP2+: dmtimer: cleanup related to devm API and clk usage
* DebBarma, Tarun Kanti [120704 21:07]: > On Thu, Jun 14, 2012 at 4:28 PM, Shilimkar, Santosh > wrote: > > > > Just to let you know that this cleanup is essential for Benoit's OMAP4 > > hwmod cleanup > > and OMAP5 minimal support series. > > This is a gentle reminder in case you have missed somehow!! > Let me know if anything else needs to be done. Now with the hwmod patch 2/4 pulled into cleanup-part2 from Paul, I've also applied patch 1/4 there. Patches 3 and 4 have still some pending comments from Kevin it seems? Also at least patch 3 won't apply, so please check Kevin's comments and repost patches 3 and 4 on top of cleanup-part2 at commit 74dd9ec62. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/4] ARM: OMAP2+: dmtimer: cleanup related to devm API and clk usage
Hi Tony, On Thu, Jun 14, 2012 at 4:28 PM, Shilimkar, Santosh wrote: > Tony, > > On Thu, Jun 14, 2012 at 4:24 PM, DebBarma, Tarun Kanti > wrote: >> On Fri, Apr 20, 2012 at 6:09 PM, Tarun Kanti DebBarma >> wrote: >>> The devm API usage in probe() simplifies error handling operation. >>> Since iclk is not used in the driver it is removed from wherever >>> not needed. >>> Corrected the timer fck name mis-match between clock44xx_data.c and >>> omap_hwmod_44xx_data.c. >>> Added omap_hwmod_get_main_clk() API. There is no more need to construct >>> clock names using sprintf() to be used in clk_get() during initialization. >>> >>> Reference: >>> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git >>> Commit: e816b57a337ea3b755de72bec38c10c864f23015 (Linux 3.4-rc3) >>> >>> Series is available here for reference: >>> git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev >>> dmtimer_cleanup_for_3.5 >>> >>> Tested on following platforms: >>> OMAP5, OMAP4430SDP, OMAP3430SDP, OMAP2430SDP. >>> Could not test on OMAP2420 due to unavailability of board. >>> >>> v2: >>> - Use devm_request_and_ioremap() instead of request_mem_region() and >>> ioremap() >>> - Add omap_hwmod_get_main_clk() API >>> - Reverted changes of clock names from OMAP2 and OMAP3 platforms >>> >>> Cc: Cousson, Benoit >>> Cc: Paul Walmsley >>> Cc: Tony Lindgren >>> Cc: Kevin Hilman >>> Cc: Rajendra Nayak >>> Cc: Santosh Shilimkar >>> >>> Tarun Kanti DebBarma (4): >>> ARM: OMAP: dmtimer: use devm_ API and do some cleanup in probe() >>> ARM: OMAP2+: hwmod: add omap_hwmod_get_main_clk() API >>> ARM: OMAP2+: dmtimer: cleanup iclk usage >>> ARM: OMAP2+: dmtimer: cleanup fclk usage >> [ping] >> Only one of the patches in the series (ARM: OMAP2+: dmtimer: cleanup iclk >> usage) >> has been taken. I just applied the remaining patches on top of Linux 3.5-rc2 >> and >> tested on OMAP3 and OMAP4. Can the remaining patches be taken as well? > > Just to let you know that this cleanup is essential for Benoit's OMAP4 > hwmod cleanup > and OMAP5 minimal support series. This is a gentle reminder in case you have missed somehow!! Let me know if anything else needs to be done. Thanks. -- Tarun -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/4] ARM: OMAP2+: dmtimer: cleanup related to devm API and clk usage
Tony, On Thu, Jun 14, 2012 at 4:24 PM, DebBarma, Tarun Kanti wrote: > On Fri, Apr 20, 2012 at 6:09 PM, Tarun Kanti DebBarma > wrote: >> The devm API usage in probe() simplifies error handling operation. >> Since iclk is not used in the driver it is removed from wherever >> not needed. >> Corrected the timer fck name mis-match between clock44xx_data.c and >> omap_hwmod_44xx_data.c. >> Added omap_hwmod_get_main_clk() API. There is no more need to construct >> clock names using sprintf() to be used in clk_get() during initialization. >> >> Reference: >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git >> Commit: e816b57a337ea3b755de72bec38c10c864f23015 (Linux 3.4-rc3) >> >> Series is available here for reference: >> git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev >> dmtimer_cleanup_for_3.5 >> >> Tested on following platforms: >> OMAP5, OMAP4430SDP, OMAP3430SDP, OMAP2430SDP. >> Could not test on OMAP2420 due to unavailability of board. >> >> v2: >> - Use devm_request_and_ioremap() instead of request_mem_region() and >> ioremap() >> - Add omap_hwmod_get_main_clk() API >> - Reverted changes of clock names from OMAP2 and OMAP3 platforms >> >> Cc: Cousson, Benoit >> Cc: Paul Walmsley >> Cc: Tony Lindgren >> Cc: Kevin Hilman >> Cc: Rajendra Nayak >> Cc: Santosh Shilimkar >> >> Tarun Kanti DebBarma (4): >> ARM: OMAP: dmtimer: use devm_ API and do some cleanup in probe() >> ARM: OMAP2+: hwmod: add omap_hwmod_get_main_clk() API >> ARM: OMAP2+: dmtimer: cleanup iclk usage >> ARM: OMAP2+: dmtimer: cleanup fclk usage > [ping] > Only one of the patches in the series (ARM: OMAP2+: dmtimer: cleanup iclk > usage) > has been taken. I just applied the remaining patches on top of Linux 3.5-rc2 > and > tested on OMAP3 and OMAP4. Can the remaining patches be taken as well? Just to let you know that this cleanup is essential for Benoit's OMAP4 hwmod cleanup and OMAP5 minimal support series. Regards santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/4] ARM: OMAP2+: dmtimer: cleanup related to devm API and clk usage
On Fri, Apr 20, 2012 at 6:09 PM, Tarun Kanti DebBarma wrote: > The devm API usage in probe() simplifies error handling operation. > Since iclk is not used in the driver it is removed from wherever > not needed. > Corrected the timer fck name mis-match between clock44xx_data.c and > omap_hwmod_44xx_data.c. > Added omap_hwmod_get_main_clk() API. There is no more need to construct > clock names using sprintf() to be used in clk_get() during initialization. > > Reference: > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git > Commit: e816b57a337ea3b755de72bec38c10c864f23015 (Linux 3.4-rc3) > > Series is available here for reference: > git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev > dmtimer_cleanup_for_3.5 > > Tested on following platforms: > OMAP5, OMAP4430SDP, OMAP3430SDP, OMAP2430SDP. > Could not test on OMAP2420 due to unavailability of board. > > v2: > - Use devm_request_and_ioremap() instead of request_mem_region() and ioremap() > - Add omap_hwmod_get_main_clk() API > - Reverted changes of clock names from OMAP2 and OMAP3 platforms > > Cc: Cousson, Benoit > Cc: Paul Walmsley > Cc: Tony Lindgren > Cc: Kevin Hilman > Cc: Rajendra Nayak > Cc: Santosh Shilimkar > > Tarun Kanti DebBarma (4): > ARM: OMAP: dmtimer: use devm_ API and do some cleanup in probe() > ARM: OMAP2+: hwmod: add omap_hwmod_get_main_clk() API > ARM: OMAP2+: dmtimer: cleanup iclk usage > ARM: OMAP2+: dmtimer: cleanup fclk usage [ping] Only one of the patches in the series (ARM: OMAP2+: dmtimer: cleanup iclk usage) has been taken. I just applied the remaining patches on top of Linux 3.5-rc2 and tested on OMAP3 and OMAP4. Can the remaining patches be taken as well? -- Tarun > > arch/arm/mach-omap2/clock44xx_data.c | 33 ++--- > arch/arm/mach-omap2/omap_hwmod.c | 15 > arch/arm/mach-omap2/timer.c | 10 +- > arch/arm/plat-omap/dmtimer.c | 51 > -- > arch/arm/plat-omap/include/plat/dmtimer.h | 2 +- > arch/arm/plat-omap/include/plat/omap_hwmod.h | 2 + > 6 files changed, 46 insertions(+), 67 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
