Re: [PATCH v2 8/9] wlcore: sdio: get clocks from device tree
On Wed, 2013-07-03 at 00:32 +0300, Felipe Balbi wrote: > On Tue, Jul 02, 2013 at 11:19:54PM +0300, Luciano Coelho wrote: > > On Tue, 2013-07-02 at 18:35 +0300, Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Jul 02, 2013 at 05:55:47PM +0300, Luciano Coelho wrote: > > > > @@ -294,6 +316,8 @@ static int wl1271_probe(struct sdio_func *func, > > > > /* Use block mode for transferring over one block size of data > > > > */ > > > > func->card->quirks |= MMC_QUIRK_BLKSZ_FOR_BYTE_MODE; > > > > > > > > + sdio_set_drvdata(func, glue); > > > > > > is this move really necessary ? > > > > It is, because I use the glue in wlcore_get_pdata_from_of(), so I need > > to call sdio_set_drvdata() earlier. I reckoned it wouldn't hurt to move > > this, so I wouldn't have to pass the glue in the > > wlcore_get_pdata_from_of() call. > > that's alright, it does look like it deserves a mention in changelog > though. Other than that: Uh, ok. This was so tiny (and I thought so obvious) a change that I didn't mention it. But if you asked about it, it was not obvious enough. ;) I'll add a small comment about it in the commit message. > Reviewed-by: Felipe Balbi Thanks! -- Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 8/9] wlcore: sdio: get clocks from device tree
On Tue, Jul 02, 2013 at 11:19:54PM +0300, Luciano Coelho wrote: > On Tue, 2013-07-02 at 18:35 +0300, Felipe Balbi wrote: > > Hi, > > > > On Tue, Jul 02, 2013 at 05:55:47PM +0300, Luciano Coelho wrote: > > > @@ -294,6 +316,8 @@ static int wl1271_probe(struct sdio_func *func, > > > /* Use block mode for transferring over one block size of data */ > > > func->card->quirks |= MMC_QUIRK_BLKSZ_FOR_BYTE_MODE; > > > > > > + sdio_set_drvdata(func, glue); > > > > is this move really necessary ? > > It is, because I use the glue in wlcore_get_pdata_from_of(), so I need > to call sdio_set_drvdata() earlier. I reckoned it wouldn't hurt to move > this, so I wouldn't have to pass the glue in the > wlcore_get_pdata_from_of() call. that's alright, it does look like it deserves a mention in changelog though. Other than that: Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital signature
Re: [PATCH v2 8/9] wlcore: sdio: get clocks from device tree
On Tue, 2013-07-02 at 18:35 +0300, Felipe Balbi wrote: > Hi, > > On Tue, Jul 02, 2013 at 05:55:47PM +0300, Luciano Coelho wrote: > > @@ -294,6 +316,8 @@ static int wl1271_probe(struct sdio_func *func, > > /* Use block mode for transferring over one block size of data */ > > func->card->quirks |= MMC_QUIRK_BLKSZ_FOR_BYTE_MODE; > > > > + sdio_set_drvdata(func, glue); > > is this move really necessary ? It is, because I use the glue in wlcore_get_pdata_from_of(), so I need to call sdio_set_drvdata() earlier. I reckoned it wouldn't hurt to move this, so I wouldn't have to pass the glue in the wlcore_get_pdata_from_of() call. -- Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 8/9] wlcore: sdio: get clocks from device tree
Hi, On Tue, Jul 02, 2013 at 05:55:47PM +0300, Luciano Coelho wrote: > @@ -294,6 +316,8 @@ static int wl1271_probe(struct sdio_func *func, > /* Use block mode for transferring over one block size of data */ > func->card->quirks |= MMC_QUIRK_BLKSZ_FOR_BYTE_MODE; > > + sdio_set_drvdata(func, glue); is this move really necessary ? -- balbi signature.asc Description: Digital signature
