RE: [PATCH v6 0/12] dmtimer adaptation to platform_driver

2010-12-16 Thread DebBarma, Tarun Kanti
> -Original Message-
> From: DebBarma, Tarun Kanti
> Sent: Wednesday, December 15, 2010 9:35 AM
> To: linux-omap@vger.kernel.org
> Cc: DebBarma, Tarun Kanti
> Subject: [PATCH v6 0/12] dmtimer adaptation to platform_driver
> 
> dmtimer adaptation to platform_driver.
> 
> This patch series is adaptation of dmtimer code to platform driver
> using omap_device and omap_hwmod abstraction.
> 
> Tested on following platforms:
> OMAP4430, OMAP3430, OMAP3630, OMAP2430
> OMAP2420, OMAP1710(in-progress)

While validating on OMAP1710 I discovered that probe() is not triggered.
I will fix this problem in the next series.

--
Tarun

> 
> Baseline:
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> 
> v6:
> (1) Removed reset functions to mach-omap1/dmtimer.c.
> Access to reset function from plat-omap/dmtimer.c is provided by means
> of function pointer.
> 
> (2) Remove multiple calls to omap_device_build() for registering timer
> devices
> during early and regular initialization. Regular device registration is
> now done
> by reading data from temporary list. This list is populated during early
> init
> where timer data is read from hwmod database and corresponding memory
> allocated.
> 
> (3) kfree(pdata) under error condition since platform_device_unregister
> does
> not free its pdata.
> 
> (4) Removed extra header inclusion in mach-omap2 and plat-omap
> 
> NOTE: omap_dm_timer. field could not be removed because during regular
> boot
> there is no mechanism to match the current pdev with corresponding entry
> in the
> timer list which was partially initialized during early boot.
> 
> 
> TODO:
> (1) OFF Mode support
> 
> (2) Upgrade timeout implementation in low-level read/write access to
> return
> error condition to EXPORT APIs. This is re-frained in the present
> implementation
> because that would involve change to EXPORTED APIs. Besides, there is no
> clear
> design as yet which is agreed upon by the community.
> 
> 
> v4:
> (1) clock aliases are renamed as "32k_ck", "sys_ck" and "alt_ck"
> (2) incorporate missing clk_put() for corresponding clk_get()
> (3) modified clk_get()/clk_put() to be called once once in platform
> driver.
> (4) consistent header for new files
> (5) check return value of omap_hwmod_for_each_by_class() in device init
> routines.
> (6) remove is_abe_timer field in dmtimer_platform_data structure. this is
> no longer needed with new input clock source aliasing.
> (7) proper splitting of patch series
> (8) remove register map from hwmod database.
> (9) remove clock source strings array from hwmod database and associated
> structure declaration from plat/dmtimer.h. this is no longer needed.
> (10) remove dev_attr from hwmod database. this is no longer needed.
> (11) use register offsets to identify OMAP 4 registers instead of register
> map.
> (12) remove clock source name strings from hwmod database.
> (13) introduce new mechanism for getting struct clk associated with clock
> source
> names. this is achieved by adding clock alisases for all supported clock
> sources.
> (14) remove clock setup functions in mach-omap2 for populating struct clk
> associated with all input clock sources because this is no longer needed
> with
> above implementation.
> (15) device names changed from dmtimer to omap-timer
> (16) device index starts from 1 instead of 0
> (17) remove .init_name from hwmod database. this is not needed.
> (18) introduce separate functions for reading/writing interrupt registers
> instead of
> doing all operations within a single function.
> 
> v3:
> (1) multi-line comment error correction
> (2) provision to allow any of the available dmtimers as early timers
> instead of restricting them to millisecond timers only.
> (3) in 'struct omap_dmtimer{}' is_initialized flag is redundant and
> so must be removed. if the element is found in the list it is already
> initialized.
> (4) remove 'found' flag in omap_dm_timer_request() and
> omap_dm_timer_request_specific() functions.
> this is not needed with alternate implementation.
> (5) use .init_name to initialize device names so that it can be identified
> during early boot as well. This is to avoid duplicate functions for clock
> manipulations during early boot and later.
> (6) remove redundant functions from mach-omap2 which are created just to
> call pm functions like: pm_runtime_get_sync(),pm_runtime_put_sync(),..
> and instead call them directly from plat-omap function api's.
> (7) timer clock source names made part of hwmod database. source_clock[]
> of type 'struct clk' is made part of platform data.
> (8) clockactivity field initialized in hwmod database to preserve fclk
> during idle. code which manipulate OCP config removed since they are
> already taken care by hwmod framework.
> (9) omap2_dm_timer_set_src() is optimized. Clock enable/disbale routines
> moved to plat-omap layer and simplfied to the level so as not to sacrifice
> intended functionality.
> NOTE: During early boot clock management was reques

Re: [PATCH v6 0/12] dmtimer adaptation to platform_driver

2010-12-17 Thread Tony Lindgren
* Tarun Kanti DebBarma  [101214 09:03]:
> dmtimer adaptation to platform_driver.
> 
> This patch series is adaptation of dmtimer code to platform driver
> using omap_device and omap_hwmod abstraction.
> 
> Tested on following platforms:
> OMAP4430, OMAP3430, OMAP3630, OMAP2430
> OMAP2420, OMAP1710(in-progress)

Looks like this we need to wait on for 2.6.39 merge window to
get all the needed testing done.

With the pending GPIO and DMA changes we are already struggling
to have them tested properly and I'm not planning on merging any more
intrusive code for this merge window after the we get the DMA
changes in hopefully today.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html