Re: [PATCHv3 20/22] OMAP3: PM: VP force update method of voltage scaling

2010-04-27 Thread Kevin Hilman
Thara Gopinath th...@ti.com writes:

 This patch introduces VP force update method of voltage scaling
 and enables it by default. The older method of vc bypass is now
 configuratble through a menu config option. VP force update is the
 hardware recommended method of voltage scaling.

 Signed-off-by: Thara Gopinath th...@ti.com

Hi Thara,

Could you (re) test this along with my changes to the PRCM IRQ handler:

  https://patchwork.kernel.org/patch/95450/

I made a change (suggested by Mike Turquette) that affects how that
ISR clears PRCM interrupts.  Previously, it would possibly interfere
with events you're polling for here, but it may never have seen.

[...]

 diff --git a/arch/arm/mach-omap2/voltage.h b/arch/arm/mach-omap2/voltage.h
 index 8800369..473a953 100644
 --- a/arch/arm/mach-omap2/voltage.h
 +++ b/arch/arm/mach-omap2/voltage.h
 @@ -14,7 +14,10 @@
  #define VDD1 0
  #define VDD2 1
  
 +#define VOLTSCALE_VPFORCEUPDATE  1
 +#define VOLTSCALE_VCBYPASS   2
  
 +#define PRM_IRQSTATUS_REG_OFFSET OMAP3_PRM_IRQSTATUS_MPU_OFFSET

Don't use another #define, just use OMAP3_PRM_IRQSTATUS_MPU_OFFSET in
code directly Please.

Kevin
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCHv3 20/22] OMAP3: PM: VP force update method of voltage scaling

2010-04-27 Thread Kevin Hilman
Thara Gopinath th...@ti.com writes:

 This patch introduces VP force update method of voltage scaling
 and enables it by default. The older method of vc bypass is now
 configuratble through a menu config option. VP force update is the
 hardware recommended method of voltage scaling.

changelog needs update.  It is no longer a menuconfig option.

Kevin

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html