Re: [PATCHv4 16/20] ASoC: OMAP: Enable DMA burst mode
Hi Tony On Mon, Aug 17, 2009 at 04:01:29PM +0200, ext Tony Lindgren wrote: > * Jarkko Nikula [090817 16:23]: > > On Mon, 17 Aug 2009 14:51:15 +0300 > > Eduardo Valentin wrote: > > > > > From: Eduardo Valentin > > > > > > Signed-off-by: Eduardo Valentin > > > --- > > > sound/soc/omap/omap-pcm.c |3 +++ > > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > > > diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c > > > index f769a52..f037db0 100644 > > > --- a/sound/soc/omap/omap-pcm.c > > > +++ b/sound/soc/omap/omap-pcm.c > > > @@ -193,6 +193,9 @@ static int omap_pcm_prepare(struct snd_pcm_substream > > > *substream) > > > omap_enable_dma_irq(prtd->dma_ch, OMAP_DMA_FRAME_IRQ | > > > (cpu_is_omap1510() ? OMAP_DMA_LAST_IRQ : 0)); > > > > > > + omap_set_dma_src_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16); > > > + omap_set_dma_dest_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16); > > > + > > > return 0; > > > > This seems to be based on first version of Janusz's "[RFC] [PATCH 3/3] > > ASoC: OMAP: Enhance OMAP1510 DMA progress software counter". > > > > I Attached a version which is based on "[PATCH 3/3 v3] ASoC: OMAP: > > Enhance OMAP1510 DMA progress software counter. > > Needs also a patch description. I've added patch description for those which were missing and sent them in reply to your commented reply. If you prefer I can send version 5 of this series. BR, > > Tony > > > > > > > -- > > Jarkko > > > From a5eb199316c4731c11c7f5f8d02612ede4de7199 Mon Sep 17 00:00:00 2001 > > From: Eduardo Valentin > > Date: Mon, 17 Aug 2009 14:51:15 +0300 > > Subject: [PATCH] ASoC: OMAP: Enable DMA burst mode > > > > Signed-off-by: Eduardo Valentin > > --- > > sound/soc/omap/omap-pcm.c |3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c > > index eab4533..b9633d5 100644 > > --- a/sound/soc/omap/omap-pcm.c > > +++ b/sound/soc/omap/omap-pcm.c > > @@ -195,6 +195,9 @@ static int omap_pcm_prepare(struct snd_pcm_substream > > *substream) > > else > > omap_enable_dma_irq(prtd->dma_ch, OMAP_DMA_FRAME_IRQ); > > > > + omap_set_dma_src_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16); > > + omap_set_dma_dest_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16); > > + > > return 0; > > } > > > > -- > > 1.6.3.3 > > > > -- > To unsubscribe from this list: send the line "unsubscribe alsa-devel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Eduardo Valentin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv4 16/20] ASoC: OMAP: Enable DMA burst mode
* Jarkko Nikula [090817 16:23]: > On Mon, 17 Aug 2009 14:51:15 +0300 > Eduardo Valentin wrote: > > > From: Eduardo Valentin > > > > Signed-off-by: Eduardo Valentin > > --- > > sound/soc/omap/omap-pcm.c |3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c > > index f769a52..f037db0 100644 > > --- a/sound/soc/omap/omap-pcm.c > > +++ b/sound/soc/omap/omap-pcm.c > > @@ -193,6 +193,9 @@ static int omap_pcm_prepare(struct snd_pcm_substream > > *substream) > > omap_enable_dma_irq(prtd->dma_ch, OMAP_DMA_FRAME_IRQ | > > (cpu_is_omap1510() ? OMAP_DMA_LAST_IRQ : 0)); > > > > + omap_set_dma_src_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16); > > + omap_set_dma_dest_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16); > > + > > return 0; > > This seems to be based on first version of Janusz's "[RFC] [PATCH 3/3] > ASoC: OMAP: Enhance OMAP1510 DMA progress software counter". > > I Attached a version which is based on "[PATCH 3/3 v3] ASoC: OMAP: > Enhance OMAP1510 DMA progress software counter. Needs also a patch description. Tony > > > -- > Jarkko > From a5eb199316c4731c11c7f5f8d02612ede4de7199 Mon Sep 17 00:00:00 2001 > From: Eduardo Valentin > Date: Mon, 17 Aug 2009 14:51:15 +0300 > Subject: [PATCH] ASoC: OMAP: Enable DMA burst mode > > Signed-off-by: Eduardo Valentin > --- > sound/soc/omap/omap-pcm.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c > index eab4533..b9633d5 100644 > --- a/sound/soc/omap/omap-pcm.c > +++ b/sound/soc/omap/omap-pcm.c > @@ -195,6 +195,9 @@ static int omap_pcm_prepare(struct snd_pcm_substream > *substream) > else > omap_enable_dma_irq(prtd->dma_ch, OMAP_DMA_FRAME_IRQ); > > + omap_set_dma_src_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16); > + omap_set_dma_dest_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16); > + > return 0; > } > > -- > 1.6.3.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv4 16/20] ASoC: OMAP: Enable DMA burst mode
On Mon, 17 Aug 2009 14:51:15 +0300 Eduardo Valentin wrote: > From: Eduardo Valentin > > Signed-off-by: Eduardo Valentin > --- > sound/soc/omap/omap-pcm.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c > index f769a52..f037db0 100644 > --- a/sound/soc/omap/omap-pcm.c > +++ b/sound/soc/omap/omap-pcm.c > @@ -193,6 +193,9 @@ static int omap_pcm_prepare(struct snd_pcm_substream > *substream) > omap_enable_dma_irq(prtd->dma_ch, OMAP_DMA_FRAME_IRQ | > (cpu_is_omap1510() ? OMAP_DMA_LAST_IRQ : 0)); > > + omap_set_dma_src_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16); > + omap_set_dma_dest_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16); > + > return 0; This seems to be based on first version of Janusz's "[RFC] [PATCH 3/3] ASoC: OMAP: Enhance OMAP1510 DMA progress software counter". I Attached a version which is based on "[PATCH 3/3 v3] ASoC: OMAP: Enhance OMAP1510 DMA progress software counter. -- Jarkko >From a5eb199316c4731c11c7f5f8d02612ede4de7199 Mon Sep 17 00:00:00 2001 From: Eduardo Valentin Date: Mon, 17 Aug 2009 14:51:15 +0300 Subject: [PATCH] ASoC: OMAP: Enable DMA burst mode Signed-off-by: Eduardo Valentin --- sound/soc/omap/omap-pcm.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c index eab4533..b9633d5 100644 --- a/sound/soc/omap/omap-pcm.c +++ b/sound/soc/omap/omap-pcm.c @@ -195,6 +195,9 @@ static int omap_pcm_prepare(struct snd_pcm_substream *substream) else omap_enable_dma_irq(prtd->dma_ch, OMAP_DMA_FRAME_IRQ); + omap_set_dma_src_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16); + omap_set_dma_dest_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16); + return 0; } -- 1.6.3.3