Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
On Mon, Jul 6, 2015 at 11:20 AM, Pali Rohár wrote: > On Monday 06 July 2015 17:22:58 Rob Herring wrote: >> On Mon, Jul 6, 2015 at 8:12 AM, Pali Rohár wrote: >> > On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: >> >> * Pali Rohár [150706 05:25]: >> >> > into which file should I put documentation about new DT >> >> > properties? >> >> >> >> If it's Linux generic like linux,revision, then how about >> >> Documentation/devicetree/bindings/revision.txt? >> >> >> >> For the ATAGs, Documentation/devicetree/bindings/arm/atag.txt? >> >> >> >> Regards, >> >> >> >> Tony >> > >> > Hm... now I'm thinking into which DT field should I put atags and >> > revision. In previous emails you wrote to use "linux,atags", now >> > "arm,atags"? And put them into root node? Or other? >> > >> > In arch/arm/boot/compressed/atags_to_fdt.c code I see that most >> > atag properties are converted into "/chosen" node in DT... >> > >> > So what do you prefer for "revision" and what for "atags"? >> > >> > Some mentioned examples: >> > >> > "/revision" >> >> This one. This is a top level h/w property. >> >> > "/chosen/revision" >> > "/linux,revision" >> > "/chosen/linux,revision" >> > ... >> > >> > "/atags" >> > "/chosen/atags" >> > "/linux,atags" >> > "/chosen/linux,atags" >> >> This one. ATAGs are a Linux data struct. >> >> Rob >> > > Ok, and how read that property "/chosen/linux,atags" in function > setup_machine_fdt() from file arch/arm/kernel/devtree.c ? > > of_get_flat_dt_prop() cannot be used unless somebody get me offset to > node "/chosen"... Why can't you get the offset yourself? However, why does this need to be early? It is only used to populate /proc, right? Rob -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
On Monday 06 July 2015 18:20:35 Pali Rohár wrote:
> > > "/chosen/linux,atags"
> >
> > This one. ATAGs are a Linux data struct.
> >
> > Rob
>
> Ok, and how read that property "/chosen/linux,atags" in function
> setup_machine_fdt() from file arch/arm/kernel/devtree.c ?
>
> of_get_flat_dt_prop() cannot be used unless somebody get me offset to
> node "/chosen"...
>
> Any idea?
>
fdt_path_offset() from libfdt.h seems to work...
Is solution like this one acceptable?
#include
#include "atags.h"
... setup_machine_fdt(unsigned int dt_phys) {
dt_virt = phys_to_virt(dt_phys);
dt_chosen = fdt_path_offset(dt_virt, "/chosen");
atags = of_get_flat_dt_prop(dt_chosen, "linux,atags", NULL);
save_atags(atags);
}
(this is without checks for errors)
--
Pali Rohár
pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
On Monday 06 July 2015 17:22:58 Rob Herring wrote: > On Mon, Jul 6, 2015 at 8:12 AM, Pali Rohár wrote: > > On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: > >> * Pali Rohár [150706 05:25]: > >> > into which file should I put documentation about new DT > >> > properties? > >> > >> If it's Linux generic like linux,revision, then how about > >> Documentation/devicetree/bindings/revision.txt? > >> > >> For the ATAGs, Documentation/devicetree/bindings/arm/atag.txt? > >> > >> Regards, > >> > >> Tony > > > > Hm... now I'm thinking into which DT field should I put atags and > > revision. In previous emails you wrote to use "linux,atags", now > > "arm,atags"? And put them into root node? Or other? > > > > In arch/arm/boot/compressed/atags_to_fdt.c code I see that most > > atag properties are converted into "/chosen" node in DT... > > > > So what do you prefer for "revision" and what for "atags"? > > > > Some mentioned examples: > > > > "/revision" > > This one. This is a top level h/w property. > > > "/chosen/revision" > > "/linux,revision" > > "/chosen/linux,revision" > > ... > > > > "/atags" > > "/chosen/atags" > > "/linux,atags" > > "/chosen/linux,atags" > > This one. ATAGs are a Linux data struct. > > Rob > Ok, and how read that property "/chosen/linux,atags" in function setup_machine_fdt() from file arch/arm/kernel/devtree.c ? of_get_flat_dt_prop() cannot be used unless somebody get me offset to node "/chosen"... Any idea? > > "/arm,atags" > > "/chosen/arm,atags" > > ... > > > > -- > > Pali Rohár > > pali.ro...@gmail.com -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
* Rob Herring [150706 08:23]: > On Mon, Jul 6, 2015 at 7:31 AM, Tony Lindgren wrote: > > * Pali Rohár [150706 05:25]: > >> > >> into which file should I put documentation about new DT properties? > > > > If it's Linux generic like linux,revision, then how about > > Just "revision" at the top level please. I'd prefer a string still, > but either is fine. OK works for me thanks. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
On Mon, Jul 6, 2015 at 8:12 AM, Pali Rohár wrote: > On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: >> * Pali Rohár [150706 05:25]: >> > into which file should I put documentation about new DT properties? >> >> If it's Linux generic like linux,revision, then how about >> Documentation/devicetree/bindings/revision.txt? >> >> For the ATAGs, Documentation/devicetree/bindings/arm/atag.txt? >> >> Regards, >> >> Tony > > Hm... now I'm thinking into which DT field should I put atags and > revision. In previous emails you wrote to use "linux,atags", now > "arm,atags"? And put them into root node? Or other? > > In arch/arm/boot/compressed/atags_to_fdt.c code I see that most atag > properties are converted into "/chosen" node in DT... > > So what do you prefer for "revision" and what for "atags"? > > Some mentioned examples: > > "/revision" This one. This is a top level h/w property. > "/chosen/revision" > "/linux,revision" > "/chosen/linux,revision" > ... > > "/atags" > "/chosen/atags" > "/linux,atags" > "/chosen/linux,atags" This one. ATAGs are a Linux data struct. Rob > "/arm,atags" > "/chosen/arm,atags" > ... > > -- > Pali Rohár > pali.ro...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
On Mon, Jul 6, 2015 at 7:31 AM, Tony Lindgren wrote: > * Pali Rohár [150706 05:25]: >> >> into which file should I put documentation about new DT properties? > > If it's Linux generic like linux,revision, then how about Just "revision" at the top level please. I'd prefer a string still, but either is fine. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
* Pali Rohár [150706 06:14]: > On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: > > * Pali Rohár [150706 05:25]: > > > into which file should I put documentation about new DT properties? > > > > If it's Linux generic like linux,revision, then how about > > Documentation/devicetree/bindings/revision.txt? > > > > For the ATAGs, Documentation/devicetree/bindings/arm/atag.txt? > > Hm... now I'm thinking into which DT field should I put atags and > revision. In previous emails you wrote to use "linux,atags", now > "arm,atags"? And put them into root node? Or other? > > In arch/arm/boot/compressed/atags_to_fdt.c code I see that most atag > properties are converted into "/chosen" node in DT... > > So what do you prefer for "revision" and what for "atags"? I'd prefer linux,revision and arm,atags. Chances are the ATAGs won't be used on other architectures. I'm find with linux,atags too if people prefer that. Regards, Tony > Some mentioned examples: > > "/revision" > "/chosen/revision" > "/linux,revision" > "/chosen/linux,revision" > ... > > "/atags" > "/chosen/atags" > "/linux,atags" > "/chosen/linux,atags" > "/arm,atags" > "/chosen/arm,atags" > ... > > -- > Pali Rohár > pali.ro...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: > * Pali Rohár [150706 05:25]: > > into which file should I put documentation about new DT properties? > > If it's Linux generic like linux,revision, then how about > Documentation/devicetree/bindings/revision.txt? > > For the ATAGs, Documentation/devicetree/bindings/arm/atag.txt? > > Regards, > > Tony Hm... now I'm thinking into which DT field should I put atags and revision. In previous emails you wrote to use "linux,atags", now "arm,atags"? And put them into root node? Or other? In arch/arm/boot/compressed/atags_to_fdt.c code I see that most atag properties are converted into "/chosen" node in DT... So what do you prefer for "revision" and what for "atags"? Some mentioned examples: "/revision" "/chosen/revision" "/linux,revision" "/chosen/linux,revision" ... "/atags" "/chosen/atags" "/linux,atags" "/chosen/linux,atags" "/arm,atags" "/chosen/arm,atags" ... -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
* Pali Rohár [150706 05:25]: > > into which file should I put documentation about new DT properties? If it's Linux generic like linux,revision, then how about Documentation/devicetree/bindings/revision.txt? For the ATAGs, Documentation/devicetree/bindings/arm/atag.txt? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
On Thursday 25 June 2015 07:01:38 Tony Lindgren wrote: > * Pali Rohár [150506 04:45]: > > On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: > > > > It needs to be done in this code, so "system_rev" variable is > > > > set properly... > > > > > > What I mean is which code accesses this variable that early? > > > > ATAG code is doing it at same early stage, so I added it to same > > early stage... > > Yes we should do this early like the other atags. > > > > > > Also, it seems strange to have a string property and then use > > > > > kstrtouint to convert it into a number. I think it should > > > > > either be specified in a DT binding to be a string and then > > > > > have the kernel not assume that it is a number, or we should > > > > > define it to be binary. > > > > > > > > > > Arnd > > > > > > > > Variable "system_rev" is number and it always was. So chaning > > > > type will break more parts. > > > > > > > > And it is string DT property to be human readable. Some other > > > > developers suggested for v2 to change it to string (from > > > > number). > > > > > > Both of them would be human readable, you just use something else > > > to read them ;-) > > > > > > If we have a string here, we should just change all uses of > > > system_rev > > > > in the kernel accordingly, there are only a few of them: > Let's just keep it as a hex as it was. After all it's an existing > interface in /proc that user space programs may expect to be in > hex format already. > > Pali, care to repost the whole set again right after -rc1 with > with rev property naming and documentation added? Just keep it > as hex and let's forget any string conversion. > > Regards, > > Tony Hello Tony, into which file should I put documentation about new DT properties? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
On Wed, May 06, 2015 at 01:44:17PM +0200, Pali Rohár wrote: > On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: > > What I mean is which code accesses this variable that early? > > > > ATAG code is doing it at same early stage, so I added it to same early > stage... ATAG code does it early because ATAGs are only available early on, and it's simpler to parse them all in one go, rather than having to do multiple passes over the structure - especially when most instances are just storing an integer to some BSS variable. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
* Pali Rohár [150625 00:29]: > On Thursday 25 June 2015 00:22:05 Tony Lindgren wrote: > > * Pali Rohár [150625 00:21]: > > > > > > Ok, but what do you mean to forget any string conversion? > > > > No need for tohexstr() in the uncommpress code if the system_rev > > value is a number coming from the dts. > > So /revision DT property will be (binary) value, right? Right just u32 value. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
On Thursday 25 June 2015 00:22:05 Tony Lindgren wrote: > * Pali Rohár [150625 00:21]: > > > > Ok, but what do you mean to forget any string conversion? > > No need for tohexstr() in the uncommpress code if the system_rev > value is a number coming from the dts. > > Regards, > > Tony So /revision DT property will be (binary) value, right? -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
* Pali Rohár [150625 00:21]: > > Ok, but what do you mean to forget any string conversion? No need for tohexstr() in the uncommpress code if the system_rev value is a number coming from the dts. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
On Wednesday 24 June 2015 22:01:38 Tony Lindgren wrote: > * Pali Rohár [150506 04:45]: > > On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: > > > > > > > > It needs to be done in this code, so "system_rev" variable is set > > > > properly... > > > > > > What I mean is which code accesses this variable that early? > > > > > > > ATAG code is doing it at same early stage, so I added it to same early > > stage... > > Yes we should do this early like the other atags. > > > > > > Also, it seems strange to have a string property and then use > > > > > kstrtouint > > > > > to convert it into a number. I think it should either be specified in > > > > > a DT > > > > > binding to be a string and then have the kernel not assume that it is > > > > > a number, > > > > > or we should define it to be binary. > > > > > > > > > > Arnd > > > > > > > > Variable "system_rev" is number and it always was. So chaning type will > > > > break more parts. > > > > > > > > And it is string DT property to be human readable. Some other developers > > > > suggested for v2 to change it to string (from number). > > > > > > Both of them would be human readable, you just use something else to > > > read them ;-) > > > > > > If we have a string here, we should just change all uses of system_rev > > > in the kernel accordingly, there are only a few of them: > > Let's just keep it as a hex as it was. After all it's an existing > interface in /proc that user space programs may expect to be in > hex format already. > > Pali, care to repost the whole set again right after -rc1 with > with rev property naming and documentation added? Just keep it > as hex and let's forget any string conversion. > > Regards, > > Tony Ok, but what do you mean to forget any string conversion? -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision
* Pali Rohár [150506 04:45]: > On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: > > > > > > It needs to be done in this code, so "system_rev" variable is set > > > properly... > > > > What I mean is which code accesses this variable that early? > > > > ATAG code is doing it at same early stage, so I added it to same early > stage... Yes we should do this early like the other atags. > > > > Also, it seems strange to have a string property and then use kstrtouint > > > > to convert it into a number. I think it should either be specified in a > > > > DT > > > > binding to be a string and then have the kernel not assume that it is a > > > > number, > > > > or we should define it to be binary. > > > > > > > > Arnd > > > > > > Variable "system_rev" is number and it always was. So chaning type will > > > break more parts. > > > > > > And it is string DT property to be human readable. Some other developers > > > suggested for v2 to change it to string (from number). > > > > Both of them would be human readable, you just use something else to > > read them ;-) > > > > If we have a string here, we should just change all uses of system_rev > > in the kernel accordingly, there are only a few of them: Let's just keep it as a hex as it was. After all it's an existing interface in /proc that user space programs may expect to be in hex format already. Pali, care to repost the whole set again right after -rc1 with with rev property naming and documentation added? Just keep it as hex and let's forget any string conversion. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
