Re: [alsa-devel] [PATCH RFC v2 0/2] Fix simple-card *-master DT parameter handling
Hi Jyri > This patch-set was never merged as such. Instead there is another > patch-set that has been applied by Mark to cover this issue [1]. The > patch maintains backward compatibility, with the Nicolin Chen's patch > [2]. In other words, old style "bitclock-master" and "frame-master" > boolean parameters are read from the codec node if they can not be found > from the top level node. The backward compatibility does not apply to > multi-link [3] configurations. Thank you ! I could find them -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [alsa-devel] [PATCH RFC v2 0/2] Fix simple-card *-master DT parameter handling
On 04/14/2014 08:07 AM, Kuninori Morimoto wrote: Hi Jyri, Mark ... Could you please teach me current status of this patch ? Hi, This patch-set was never merged as such. Instead there is another patch-set that has been applied by Mark to cover this issue [1]. The patch maintains backward compatibility, with the Nicolin Chen's patch [2]. In other words, old style "bitclock-master" and "frame-master" boolean parameters are read from the codec node if they can not be found from the top level node. The backward compatibility does not apply to multi-link [3] configurations. Best regards, Jyri [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2014-March/074717.html [2] http://mailman.alsa-project.org/pipermail/alsa-devel/2014-March/074219.html [3] http://mailman.alsa-project.org/pipermail/alsa-devel/2014-March/074592.html ps. The discussions that lead to the current solution can be found here: http://mailman.alsa-project.org/pipermail/alsa-devel/2014-March/074388.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [alsa-devel] [PATCH RFC v2 0/2] Fix simple-card *-master DT parameter handling
Hi Jyri, Mark
> >>> but anyway, if my understanding is correct,
> >>>
> >>> simple-audio-card,cpu {
> >>> ...
> >>> bitclock-master;
> >>> frame-master;
> >>> };
> >>>
> >>> simple-audio-card,codec {
> >>> ...
> >>> bitclock-master;
> >>> frame-master;
> >>> };
> >>>
> >>> This will be
> >>> cpu : SND_SOC_DAIFMT_CBS_CFS
> >>> codec : SND_SOC_DAIFMT_CBM_CFM
> >>>
> >>
> >> Yes, That's also what my understanding of this patches.
> >
> > Thank you. I understand.
> > (and I need to send fixup patches :)
> >
> > # "codec-is-bitclock-master" seems understandable than
> > # current "bitclock-master"...
> >
>
> Sounds great to me!
Could you please teach me current status of this patch ?
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [alsa-devel] [PATCH RFC v2 0/2] Fix simple-card *-master DT parameter handling
On Wed, Mar 12, 2014 at 01:00:02PM +0800, Richard Lee wrote:
> But, IMO, if you want the CPU DAI be CBS_CFS and CODEC be CBM_CFM,
> you could just do it like this:
> simple-audio-card,cpu {
> ...
> };
>
> simple-audio-card,codec {
> ...
> bitclock-master;
> frame-master;
> };
> and vice versa.
> Thanks,
> (I could find this mails in my Freescale acount, so I will reply it here.)
Yes, that'd been what I'd thought the binding did (and it's what Jyri's
patch makes it do).
signature.asc
Description: Digital signature
Re: [alsa-devel] [PATCH RFC v2 0/2] Fix simple-card *-master DT parameter handling
On 03/12/2014 08:11 AM, Kuninori Morimoto wrote:
Hi Richard
but anyway, if my understanding is correct,
simple-audio-card,cpu {
...
bitclock-master;
frame-master;
};
simple-audio-card,codec {
...
bitclock-master;
frame-master;
};
This will be
cpu : SND_SOC_DAIFMT_CBS_CFS
codec : SND_SOC_DAIFMT_CBM_CFM
Yes, That's also what my understanding of this patches.
Thank you. I understand.
(and I need to send fixup patches :)
# "codec-is-bitclock-master" seems understandable than
# current "bitclock-master"...
Sounds great to me!
Best regards,
Jyri
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [alsa-devel] [PATCH RFC v2 0/2] Fix simple-card *-master DT parameter handling
Hi Richard
> > but anyway, if my understanding is correct,
> >
> > simple-audio-card,cpu {
> > ...
> > bitclock-master;
> > frame-master;
> > };
> >
> > simple-audio-card,codec {
> > ...
> > bitclock-master;
> > frame-master;
> > };
> >
> > This will be
> > cpu : SND_SOC_DAIFMT_CBS_CFS
> > codec : SND_SOC_DAIFMT_CBM_CFM
> >
>
> Yes, That's also what my understanding of this patches.
Thank you. I understand.
(and I need to send fixup patches :)
# "codec-is-bitclock-master" seems understandable than
# current "bitclock-master"...
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [alsa-devel] [PATCH RFC v2 0/2] Fix simple-card *-master DT parameter handling
On Wed, Mar 12, 2014 at 9:13 AM, Kuninori Morimoto
wrote:
>
> Hi Jyri
>
>> Since RFC:
>> - fixed commit msg typo
>> - added include/sound/soc.h changes too
>>
>> The sematics of bitclock-master and frame-master DT parameters
>> should depend on whether they are found from a cpu-dai or codec
>> sub-node.
>>
>> - bitclock-master in cpu-dai node means Codec-Bitclock-Slave
>> - frame-master in cpu-dai node means Codec-Frame-Slave
>> - bitclock-master in codec node means Codec-Bitclock-Master
>> - frame-master in codec node means Codec-Frame-Master
>>
>> For example in a cpu-dai mode bitclock-master parameter should produce
>> SND_SOC_DAIFMT_CBS_* daifmt flags and a codec node
>> SND_SOC_DAIFMT_CBM_* flags.
>
> SND_SOC_DAIFMT_xxx comment indicates "codec clk/FRM" indeed.
> but does this "codec" means "codec chip" ??
> I'm not sure.
>
> but anyway, if my understanding is correct,
>
> simple-audio-card,cpu {
> ...
> bitclock-master;
> frame-master;
> };
>
> simple-audio-card,codec {
> ...
> bitclock-master;
> frame-master;
> };
>
> This will be
> cpu : SND_SOC_DAIFMT_CBS_CFS
> codec : SND_SOC_DAIFMT_CBM_CFM
>
Yes, That's also what my understanding of this patches.
But, IMO, if you want the CPU DAI be CBS_CFS and CODEC be CBM_CFM,
you could just do it like this:
simple-audio-card,cpu {
...
};
simple-audio-card,codec {
...
bitclock-master;
frame-master;
};
and vice versa.
Thanks,
(I could find this mails in my Freescale acount, so I will reply it here.)
--
Best Regards,
Xiubo
> but, it is un-understandable/confusable for me,
> and it breaks our sound card.
>
> ${LINUX}/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> ${LINUX}/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
>
> I guess you want like this ?
>
> codec-bitclock-master;
> codec-frame-master;
>
> simple-audio-card,cpu {
> ...
> };
>
> simple-audio-card,codec {
> ...
> };
>
> # And I guess [1/2] and [2/2] should be 1 patch.
> # otherwise, it breaks git-bisect :P
>
>
> Best regards
> ---
> Kuninori Morimoto
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [alsa-devel] [PATCH RFC v2 0/2] Fix simple-card *-master DT parameter handling
Hi Mark, Jyri
> > Since RFC:
> > - fixed commit msg typo
> > - added include/sound/soc.h changes too
> >
> > The sematics of bitclock-master and frame-master DT parameters
> > should depend on whether they are found from a cpu-dai or codec
> > sub-node.
> >
> > - bitclock-master in cpu-dai node means Codec-Bitclock-Slave
> > - frame-master in cpu-dai node means Codec-Frame-Slave
> > - bitclock-master in codec node means Codec-Bitclock-Master
> > - frame-master in codec node means Codec-Frame-Master
> >
> > For example in a cpu-dai mode bitclock-master parameter should produce
> > SND_SOC_DAIFMT_CBS_* daifmt flags and a codec node
> > SND_SOC_DAIFMT_CBM_* flags.
I had misunderstood about SND_SOC_DAIFMT_xxx
So, please ignore my previous comment.
But, I wounder, if cpu/codec use identical format flags,
then, asoc_simple_dai don't need fmt ?
struct asoc_simple_dai {
const char *name;
unsigned int fmt; <= we can/should remove this ?
unsigned int sysclk;
};
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [alsa-devel] [PATCH RFC v2 0/2] Fix simple-card *-master DT parameter handling
Hi Jyri
> Since RFC:
> - fixed commit msg typo
> - added include/sound/soc.h changes too
>
> The sematics of bitclock-master and frame-master DT parameters
> should depend on whether they are found from a cpu-dai or codec
> sub-node.
>
> - bitclock-master in cpu-dai node means Codec-Bitclock-Slave
> - frame-master in cpu-dai node means Codec-Frame-Slave
> - bitclock-master in codec node means Codec-Bitclock-Master
> - frame-master in codec node means Codec-Frame-Master
>
> For example in a cpu-dai mode bitclock-master parameter should produce
> SND_SOC_DAIFMT_CBS_* daifmt flags and a codec node
> SND_SOC_DAIFMT_CBM_* flags.
SND_SOC_DAIFMT_xxx comment indicates "codec clk/FRM" indeed.
but does this "codec" means "codec chip" ??
I'm not sure.
but anyway, if my understanding is correct,
simple-audio-card,cpu {
...
bitclock-master;
frame-master;
};
simple-audio-card,codec {
...
bitclock-master;
frame-master;
};
This will be
cpu : SND_SOC_DAIFMT_CBS_CFS
codec : SND_SOC_DAIFMT_CBM_CFM
but, it is un-understandable/confusable for me,
and it breaks our sound card.
${LINUX}/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
${LINUX}/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
I guess you want like this ?
codec-bitclock-master;
codec-frame-master;
simple-audio-card,cpu {
...
};
simple-audio-card,codec {
...
};
# And I guess [1/2] and [2/2] should be 1 patch.
# otherwise, it breaks git-bisect :P
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
