Re: [alsa-devel] [PATCH v4 - resend 00/13] OMAP4: ASoC: Support for PandaBoard family

2012-01-27 Thread Jassi Brar
Hi Sebastien,

On 28 January 2012 04:21, Guiriec, Sebastien  wrote:
>>>
>> Hi Peter,
>>     I tried the patchset on my 4430 Panda. Playback works ok, but not 
>> Capture.
>> All is get is a hiss.
>>    Is capture supposed to work ? If yes, any amixer settings that need
>> to be done?
>
> Hi Jassi,
>
> With the next update the PandaBoard 4430 is working fine.
> cpu_is_omap4430() macro is not define. We should use cpu_is_omap443x()
> macro in order to select correctly PandaBoard and not PandaBoardES
> board. Due to this error the heaset Mic pin is not enable so record is not
> working (use for Panda 4430 recording).
>
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-
> omap2/board-omap4panda.c
> index 5f27387..6a397e9 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -580,7 +580,7 @@ void omap4_panda_display_init(void)
>
>  static void omap4_panda_init_rev(void)
>  {
> -       if (cpu_is_omap4430()) {
> +       if (cpu_is_omap443x()) {
>                /* PandaBoard 4430 */
>                /* ASoC audio configuration */
>                panda_abe_audio_data.card_name = "PandaBoard";
>
Thanks, the patch make it work for Panda-4430 too.

Thanks Peter for the amixer settings.

Cheers,
Jassi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [alsa-devel] [PATCH v4 - resend 00/13] OMAP4: ASoC: Support for PandaBoard family

2012-01-27 Thread Guiriec, Sebastien
On 01/25/2012 11:50 AM, Jassi Brar wrote:
> On 24 January 2012 17:22, Peter Ujfalusi  wrote:
>> Hello,
>>
>> the following series will add ASoC support for PandaBoards.
>> PandaBoards have different audio routings compared to SDP4430/Blaze boards, 
>> but
>> the differences not that big to justify a new ASoC machine driver.
>>
>> The v3 series did not made it to 3.3 kernel.
>> This set contains all the patches needed to enable the audio support on the
>> PandaBoard family.
>> The machine driver has been converted to a generic OMAP4 driver which can
>> support wide range of machines using OMAP4 with twl6040 codec.
>>
>> I have remove the hardcoded MCLK clock frequency use in the machine driver
>> (there can be devices with different MCLK configuration). This changed
>> patch 04, 05, and 12. Since this does not affect the functionality I kept the
>> acks for these patches. Patch 11 did not existed in the v3 series.
>>
> Hi Peter,
> I tried the patchset on my 4430 Panda. Playback works ok, but not Capture.
> All is get is a hiss.
>Is capture supposed to work ? If yes, any amixer settings that need
> to be done?

Hi Jassi,

With the next update the PandaBoard 4430 is working fine.
cpu_is_omap4430() macro is not define. We should use cpu_is_omap443x()
macro in order to select correctly PandaBoard and not PandaBoardES
board. Due to this error the heaset Mic pin is not enable so record is not
working (use for Panda 4430 recording).

diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-
omap2/board-omap4panda.c
index 5f27387..6a397e9 100644
--- a/arch/arm/mach-omap2/board-omap4panda.c
+++ b/arch/arm/mach-omap2/board-omap4panda.c
@@ -580,7 +580,7 @@ void omap4_panda_display_init(void)

 static void omap4_panda_init_rev(void)
 {
-   if (cpu_is_omap4430()) {
+   if (cpu_is_omap443x()) {
/* PandaBoard 4430 */
/* ASoC audio configuration */
panda_abe_audio_data.card_name = "PandaBoard";
-- 
1.7.4.1


Sebastien.

>
> Thanks,
> -Jassi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [alsa-devel] [PATCH v4 - resend 00/13] OMAP4: ASoC: Support for PandaBoard family

2012-01-25 Thread Peter Ujfalusi
On 01/25/2012 12:50 PM, Jassi Brar wrote:
> Hi Peter,
>I tried the patchset on my 4430 Panda. Playback works ok, but not Capture.
> All is get is a hiss.
>   Is capture supposed to work ? If yes, any amixer settings that need
> to be done?

Thanks for testing the series.

I do not have Panda on my own, but the capture depends on Panda version:
PandaBoard (4430): You record from HSMIC
PandaBoardES (4460): You record from AFML (line in).

Can you try:
amixer sset 'Analog Left' 'Headset Mic'
amixer sset 'Analog Right' 'Headset Mic'
Or
amixer sset 'Analog Left' 'Aux/FM Left'
amixer sset 'Analog Right' 'Aux/FM Right'

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [alsa-devel] [PATCH v4 - resend 00/13] OMAP4: ASoC: Support for PandaBoard family

2012-01-25 Thread Jassi Brar
On 24 January 2012 17:22, Peter Ujfalusi  wrote:
> Hello,
>
> the following series will add ASoC support for PandaBoards.
> PandaBoards have different audio routings compared to SDP4430/Blaze boards, 
> but
> the differences not that big to justify a new ASoC machine driver.
>
> The v3 series did not made it to 3.3 kernel.
> This set contains all the patches needed to enable the audio support on the
> PandaBoard family.
> The machine driver has been converted to a generic OMAP4 driver which can
> support wide range of machines using OMAP4 with twl6040 codec.
>
> I have remove the hardcoded MCLK clock frequency use in the machine driver
> (there can be devices with different MCLK configuration). This changed
> patch 04, 05, and 12. Since this does not affect the functionality I kept the
> acks for these patches. Patch 11 did not existed in the v3 series.
>
Hi Peter,
   I tried the patchset on my 4430 Panda. Playback works ok, but not Capture.
All is get is a hiss.
  Is capture supposed to work ? If yes, any amixer settings that need
to be done?

Thanks,
-Jassi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html