Re: musb crash on suspend

2011-09-13 Thread Dat
Cliff Brake  gmail.com> writes:

> 
> On Thu, Jul 28, 2011 at 5:05 PM, Cliff Brake  gmail.com> 
wrote:
> 
> My kernel config is:
> 
> CONFIG_USB_MUSB_HDRC=y
> # CONFIG_USB_MUSB_TUSB6010 is not set
> CONFIG_USB_MUSB_OMAP2PLUS=y
> # CONFIG_USB_MUSB_AM35X is not set
> # CONFIG_USB_MUSB_HOST is not set
> # CONFIG_USB_MUSB_PERIPHERAL is not set
> CONFIG_USB_MUSB_OTG=y
> CONFIG_USB_GADGET_MUSB_HDRC=y
> CONFIG_USB_MUSB_HDRC_HCD=y
> # CONFIG_MUSB_PIO_ONLY is not set
> CONFIG_USB_INVENTRA_DMA=y
> 
> Its interesting that if I plug a host cable into the port, then it
> seems to suspend.  Its only when a host cable is not plugged in (ID
> pin is not grounded) that I get this crash.
> 
> Cliff
> 



Hi Cliff,

I have the same problem as you. Did you ever fix the problem? I don't think it 
is working when you have the usb cable plugged in. You don't see the error 
because it doesn't really go into suspend mode when the cable is plugged in. 
You 
should see something like "core_domain failed to suspend error 1" when you 
resume from suspend.

I found the error to be in musb_core.c, musb_save_context(), when executing 
this 
line:

musb->context.power = musb_readb(musb_base, MUSB_POWER);   

I wonder if the memory is suspending before the USB can save the context.

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: musb crash on suspend

2011-08-12 Thread Felipe Balbi
Hi,

On Thu, Jul 28, 2011 at 05:05:13PM -0400, Cliff Brake wrote:
> Hello, I'm running 2.6.39 on omap3530 with a number of patches and am
> seeing the below crash on suspend.  Questions:
> 
> 1) does anyone have musb suspending with 2.6.39?
> 2) are there any fixes or suggestions?
> 
> Thanks,
> Cliff
> 
> musb-hdrc musb-hdrc: suspend
> Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab00c
> Internal error: : 1028 [#1] PREEMPT
> last sysfs file: /sys/power/state
> Modules linked in: mac80211 cfg80211
> CPU: 0Tainted: GW(2.6.39+ #182)
> PC is at musb_save_context+0x14/0x150
> LR is at musb_suspend+0x2c/0x60
> pc : []lr : []psr: 2093
> sp : cc26de48  ip : fb02  fp : c05c34d8
> r10: c06124d4  r9 :   r8 : 0002
> r7 :   r6 :   r5 : cc8d3e08  r4 : a013
> r3 : 0003  r2 : 0001  r1 : fa0ab000  r0 : cc9380ec
> Flags: nzCv  IRQs off  FIQs on  Mode SVC_32  ISA ARM  Segment user
> Control: 10c5387d  Table: 8c014019  DAC: 0015
> Process sh (pid: 1884, stack limit = 0xcc26c2e8)
> Stack: (0xcc26de48 to 0xcc26e000)
> de40:   a013 cc8d3e08   0002 
> de60: c06124d4 c02b1bd8 cc842640 c023d948 cc842640 c0240a94 cc8d3e08 cc842640
> de80:   cc8d3e08 0002  cc8d3e3c c06124d4 c02414cc
> dea0: cc8d3e08 0002 cc8d3e08  cc8d3e68 0002 c05e00d4 c0241918
> dec0: 0bead162 0007 0bead162 0007   0003 0003
> dee0: 0004 c0413714 0004 c0506ab1 000a3008 c0090ad4 c0506ab1 0003
> df00:  c0090d50 cc10f000 0003 0003 c0090364 cc812908 ccb3f818
> df20: cc26df80 c042e650 ccb3f800 0004 cc820b00 c01e00ec cc812908 c0118350
> df40: 0004 cc33db40 4006c000 cc26df80 0004 cc26c000  c00c4a2c
> df60: cc33db40 4006c000 cc33db40 4006c000   0004 c00c4b60
> df80:   0004  0004 4006c000 403525d0 0004
> dfa0: c003cf68 c003cdc0 0004 4006c000 0001 4006c000 0004 
> dfc0: 0004 4006c000 403525d0 0004 0004 000a33f0 0001 000a3008
> dfe0:  beff85c0 40290028 402e332c 6010 0001 8801 1500
> [] (musb_save_context+0x14/0x150) from []
> (musb_suspend+0x2c/0x60)
> [] (musb_suspend+0x2c/0x60) from []
> (platform_pm_suspend+0x2c/0x54)
> [] (platform_pm_suspend+0x2c/0x54) from [] 
> (pm_op+0x4c/0xb4)
> [] (pm_op+0x4c/0xb4) from [] 
> (__device_suspend+0x134/0x1f0)
> [] (__device_suspend+0x134/0x1f0) from []
> (dpm_suspend_start+0x34c/0x458)
> [] (dpm_suspend_start+0x34c/0x458) from []
> (suspend_devices_and_enter+0x3c/0x1f8)
> [] (suspend_devices_and_enter+0x3c/0x1f8) from []
> (enter_state+0xc0/0x128)
> [] (enter_state+0xc0/0x128) from [] 
> (state_store+0xa0/0xb4)
> [] (state_store+0xa0/0xb4) from []
> (kobj_attr_store+0x18/0x1c)
> [] (kobj_attr_store+0x18/0x1c) from []
> (sysfs_write_file+0x108/0x13c)
> [] (sysfs_write_file+0x108/0x13c) from []
> (vfs_write+0xac/0x134)
> [] (vfs_write+0xac/0x134) from [] (sys_write+0x3c/0x68)
> [] (sys_write+0x3c/0x68) from [] 
> (ret_fast_syscall+0x0/0x30)
> Code: e92d47f0 e3530002 e5901208 0a05 (e1d130bc)
> [ cut here ]
> WARNING: at arch/arm/mach-omap2/omap_l3_smx.c:162 
> omap3_l3_app_irq+0xf8/0x150()
> In-band Error Error seen by MPU  at address 0

quite interesting that you got In-band Error...
oh well, you say it's already fixed, but if you see again errors from
omap3_l3, let us know again ;-)

-- 
balbi


signature.asc
Description: Digital signature


Re: musb crash on suspend

2011-07-28 Thread Felipe Balbi
On Thu, Jul 28, 2011 at 05:32:14PM -0400, Cliff Brake wrote:
> On Thu, Jul 28, 2011 at 5:12 PM, Haslam, Axel  wrote:
> > Cliff,
> > Im not sure if you have are seeing the same issue, but maybe something
> > like this may help:
> > commit 39b7060345141b3ed2567fc6bc104ccab545fc0e

I don't have that commit. Can someone send that patch so I can queue it
for mailine and stable trees ?

-- 
balbi


signature.asc
Description: Digital signature


Re: musb crash on suspend

2011-07-28 Thread Cliff Brake
On Thu, Jul 28, 2011 at 5:12 PM, Haslam, Axel  wrote:
> Cliff,
> Im not sure if you have are seeing the same issue, but maybe something
> like this may help:
> commit 39b7060345141b3ed2567fc6bc104ccab545fc0e
> Author: Axel Haslam 
> Date:   Thu Jun 2 16:35:44 2011 -0500
>     MUSB: Dont save context, if driver is suspended by runtime
>     Doing a save context on the suspend handler when
>     the clock are cut by runtime_pm, will cause
>     data aborts.

That seems to have fixed it.  Thank you very much!

Cliff

-- 
=
http://bec-systems.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: musb crash on suspend

2011-07-28 Thread Cliff Brake
On Thu, Jul 28, 2011 at 5:05 PM, Cliff Brake  wrote:

My kernel config is:

CONFIG_USB_MUSB_HDRC=y
# CONFIG_USB_MUSB_TUSB6010 is not set
CONFIG_USB_MUSB_OMAP2PLUS=y
# CONFIG_USB_MUSB_AM35X is not set
# CONFIG_USB_MUSB_HOST is not set
# CONFIG_USB_MUSB_PERIPHERAL is not set
CONFIG_USB_MUSB_OTG=y
CONFIG_USB_GADGET_MUSB_HDRC=y
CONFIG_USB_MUSB_HDRC_HCD=y
# CONFIG_MUSB_PIO_ONLY is not set
CONFIG_USB_INVENTRA_DMA=y

Its interesting that if I plug a host cable into the port, then it
seems to suspend.  Its only when a host cable is not plugged in (ID
pin is not grounded) that I get this crash.

Cliff

-- 
=
http://bec-systems.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html